mirror of https://github.com/OpenIdentityPlatform/OpenDJ.git

Ludovic Poitou
27.33.2013 28693743c89bc6e4f3927a48db1e6170f868c757
Fix for OpenDJ-909 : ControlPanel.app exits during startup.
There are a number of issues with the Mac Apps, and this commit fixes most of them, but we should also change the icon name and picture once we have a logo for OpenDJ.
The version and revision numbers are now automatically set when packaging.
The -client JVM option is deprecated and thus removed. And we properly set the ServerRoot to allow ControlPanel to work when double clicking the icon.
Note that Mac App are dependant on the JavaApplicationStub that only supports Java6. We fine for now, since OpenDJ is built with target 1.6, but we will need to redo the Apps when/if we switch to 1.7 by default.

4 files modified
37 ■■■■ changed files
opendj-sdk/opends/build.xml 19 ●●●●● patch | view | raw | blame | history
opendj-sdk/opends/resource/mac/ControlPanel.app/Contents/Info.plist 6 ●●●●● patch | view | raw | blame | history
opendj-sdk/opends/resource/mac/QuickSetup.app/Contents/Info.plist 6 ●●●●● patch | view | raw | blame | history
opendj-sdk/opends/resource/mac/Uninstall.app/Contents/Info.plist 6 ●●●●● patch | view | raw | blame | history
opendj-sdk/opends/build.xml
@@ -201,6 +201,7 @@
       compilation. -->
  <presetdef name="javac">
    <javac optimize="true" includeantruntime="false"
           source="1.6" target="1.6"
        debug="on" debuglevel="${build.debuglevel}"
        deprecation="true" fork="true"
        memoryInitialSize="${MEM}" memoryMaximumSize="${MEM}">
@@ -1213,6 +1214,12 @@
    <copy todir="${pdir}/QuickSetup.app">
      <fileset dir="${resource.dir}/mac/QuickSetup.app" />
    </copy>
    <replace file="${pdir}/QuickSetup.app/Contents/Info.plist"
             token="@version@"
             value="${MAJOR_VERSION}.${MINOR_VERSION}.${POINT_VERSION}"/>
    <replace file="${pdir}/QuickSetup.app/Contents/Info.plist"
             token="@revision@"
             value="${REVISION_NUMBER}"/>
    <chmod perm="755">
      <fileset dir="${pdir}">
        <include name="QuickSetup.app/Contents/MacOS/JavaApplicationStub" />
@@ -1221,6 +1228,12 @@
    <copy todir="${pdir}/Uninstall.app">
      <fileset dir="${resource.dir}/mac/Uninstall.app" />
    </copy>
    <replace file="${pdir}/Uninstall.app/Contents/Info.plist"
             token="@version@"
             value="${MAJOR_VERSION}.${MINOR_VERSION}.${POINT_VERSION}"/>
    <replace file="${pdir}/Uninstall.app/Contents/Info.plist"
             token="@revision@"
             value="${REVISION_NUMBER}"/>
    <chmod perm="755">
      <fileset dir="${pdir}">
        <include name="Uninstall.app/Contents/MacOS/JavaApplicationStub" />
@@ -1229,6 +1242,12 @@
    <copy todir="${pdir}/bin/ControlPanel.app">
      <fileset dir="${resource.dir}/mac/ControlPanel.app" />
    </copy>
    <replace file="${pdir}/bin/ControlPanel.app/Contents/Info.plist"
             token="@version@"
             value="${MAJOR_VERSION}.${MINOR_VERSION}.${POINT_VERSION}"/>
    <replace file="${pdir}/bin/ControlPanel.app/Contents/Info.plist"
             token="@revision@"
             value="${REVISION_NUMBER}"/>
    <chmod perm="755">
      <fileset dir="${pdir}/bin">
        <include name="ControlPanel.app/Contents/MacOS/JavaApplicationStub" />
opendj-sdk/opends/resource/mac/ControlPanel.app/Contents/Info.plist
@@ -6,8 +6,10 @@
    <string>OpenDJ Control Panel</string>
    <key>CFBundleIdentifier</key>
    <string>org.opends.guitools.controlpanel.ControlPanelLauncher</string>
    <key>CFBundleShortVersionString</key>
    <string>@version@</string>
    <key>CFBundleVersion</key>
    <string>2.3.0</string>
    <string>@revision@</string>
    <key>CFBundleAllowMixedLocalizations</key>
    <string>true</string>
    <key>CFBundleExecutable</key>
@@ -25,7 +27,7 @@
    <key>Java</key>
    <dict>
        <key>VMOptions</key>
        <string>-client</string>
        <string>-Dorg.opends.server.ServerRoot=$APP_PACKAGE/../..</string>
        <key>MainClass</key>
        <string>org.opends.guitools.controlpanel.ControlPanelLauncher</string>
        <key>JVMVersion</key>
opendj-sdk/opends/resource/mac/QuickSetup.app/Contents/Info.plist
@@ -6,8 +6,10 @@
    <string>OpenDJ QuickSetup</string>
    <key>CFBundleIdentifier</key>
    <string>org.opends.quicksetup.installer.SetupLauncher</string>
    <key>CFBundleShortVersionString</key>
    <string>@version@</string>
    <key>CFBundleVersion</key>
    <string>2.3.0</string>
    <string>@revision@</string>
    <key>CFBundleAllowMixedLocalizations</key>
    <string>true</string>
    <key>CFBundleExecutable</key>
@@ -25,7 +27,7 @@
    <key>Java</key>
    <dict>
        <key>VMOptions</key>
        <string>-client</string>
        <string>-Dorg.opends.server.ServerRoot=$APP_PACKAGE/..</string>
        <key>MainClass</key>
        <string>org.opends.quicksetup.installer.SetupLauncher</string>
        <key>JVMVersion</key>
opendj-sdk/opends/resource/mac/Uninstall.app/Contents/Info.plist
@@ -6,8 +6,10 @@
    <string>OpenDJ Uninstall</string>
    <key>CFBundleIdentifier</key>
    <string>org.opends.guitools.uninstaller.UninstallLauncher</string>
    <key>CFBundleShortVersionString</key>
    <string>@version@</string>
    <key>CFBundleVersion</key>
    <string>2.3.0</string>
    <string>@revision@</string>
    <key>CFBundleAllowMixedLocalizations</key>
    <string>true</string>
    <key>CFBundleExecutable</key>
@@ -25,7 +27,7 @@
    <key>Java</key>
    <dict>
        <key>VMOptions</key>
        <string>-client</string>
        <string>-Dorg.opends.server.ServerRoot=$APP_PACKAGE/..</string>
        <key>MainClass</key>
        <string>org.opends.guitools.uninstaller.UninstallLauncher</string>
        <key>JVMVersion</key>