AutoRefactor'ed replacing StringBuilder.append(obj.toString()) with StringB...

Jean-Noel Rouvignac

13.22.2014 30ab041f5cc91deeb2765d03557c90a2a7651d13

AutoRefactor'ed replacing StringBuilder.append(obj.toString()) with StringBuilder.append(obj).

AttributeFilter.java:
In toString(), removed use of 'isFirst' local variable by checking the StringBuilder's length.

 opendj-cli/src/main/java/com/forgerock/opendj/cli/ArgumentParser.java

@@ -1481,7 +1481,7 @@

        if (a.needsValue() && a.getDefaultValue() != null && a.getDefaultValue().length() > 0) {
            buffer.append(INDENT);
            buffer.append(INFO_ARGPARSER_USAGE_DEFAULT_VALUE.get(a.getDefaultValue()).toString());
            buffer.append(INFO_ARGPARSER_USAGE_DEFAULT_VALUE.get(a.getDefaultValue()));
            buffer.append(EOL);
        }
    }

 opendj-cli/src/main/java/com/forgerock/opendj/cli/SubCommandArgumentParser.java

@@ -978,7 +978,7 @@
                    if (lineLength > MAX_LINE_WIDTH) {
                        buffer.append(EOL);
                    }
                    buffer.append(newBuffer.toString());
                    buffer.append(newBuffer);
                }

                buffer.append(EOL);

 opendj-config/src/main/java/org/forgerock/opendj/config/DurationPropertyDefinition.java

@@ -408,7 +408,7 @@
        StringBuilder builder = new StringBuilder();
        builder.append(value);
        builder.append(' ');
        builder.append(baseUnit.toString());
        builder.append(baseUnit);
        return builder.toString();
    }


 opendj-config/src/main/java/org/forgerock/opendj/config/SizePropertyDefinition.java

@@ -259,7 +259,7 @@
        // anyway as the best-fit unit should result in an exact conversion).
        builder.append((long) unit.fromBytes(value));
        builder.append(' ');
        builder.append(unit.toString());
        builder.append(unit);
        return builder.toString();
    }


 opendj-config/src/main/java/org/forgerock/opendj/config/client/spi/PropertySet.java

@@ -228,7 +228,7 @@
        for (Map.Entry<PropertyDefinition<?>, MyProperty<?>> entry : properties.entrySet()) {
            builder.append(entry.getKey().getName());
            builder.append('=');
            builder.append(entry.getValue().toString());
            builder.append(entry.getValue());
            builder.append(' ');
        }
        builder.append('}');

 opendj-config/src/main/java/org/forgerock/opendj/config/server/ConfigChangeResult.java

@@ -173,7 +173,7 @@
     */
    public void toString(StringBuilder buffer) {
        buffer.append("ConfigChangeResult(result=");
        buffer.append(resultCode.toString());
        buffer.append(resultCode);
        buffer.append(", adminActionRequired=");
        buffer.append(adminActionRequired);
        buffer.append(", messages={");

 opendj-core/src/main/java/org/forgerock/opendj/ldap/AttributeFilter.java

@@ -174,8 +174,7 @@
                 */
                return new Iterable<Attribute>() {
                    private boolean hasNextMustIterate = true;
                    private final Iterator<Attribute> iterator = entry.getAllAttributes()
                            .iterator();
                    private final Iterator<Attribute> iterator = entry.getAllAttributes().iterator();
                    private Attribute next = null;

                    @Override
@@ -187,11 +186,9 @@
                                    hasNextMustIterate = false;
                                    while (iterator.hasNext()) {
                                        final Attribute attribute = iterator.next();
                                        final AttributeDescription ad =
                                                attribute.getAttributeDescription();
                                        final AttributeDescription ad = attribute.getAttributeDescription();
                                        final AttributeType at = ad.getAttributeType();
                                        final AttributeDescription requestedAd =
                                                requestedAttributes.get(ad);
                                        final AttributeDescription requestedAd = requestedAttributes.get(ad);
                                        if (requestedAd != null) {
                                            next = renameAttribute(attribute, requestedAd);
                                            return true;
@@ -371,32 +368,29 @@

    @Override
    public String toString() {
        if (!includeAllOperationalAttributes && !includeAllUserAttributes
        if (!includeAllOperationalAttributes
                && !includeAllUserAttributes
                && requestedAttributes.isEmpty()) {
            return "1.1";
        } else {
            boolean isFirst = true;
            final StringBuilder builder = new StringBuilder();
            if (includeAllUserAttributes) {
                builder.append('*');
                isFirst = false;
            }
            if (includeAllOperationalAttributes) {
                if (!isFirst) {
                    builder.append(", ");
                }
                builder.append('+');
                isFirst = false;
            }
            for (final AttributeDescription requestedAttribute : requestedAttributes.keySet()) {
                if (!isFirst) {
                    builder.append(", ");
                }
                builder.append(requestedAttribute.toString());
                isFirst = false;
            }
            return builder.toString();
        }

        final StringBuilder builder = new StringBuilder();
        if (includeAllUserAttributes) {
            builder.append('*');
        }
        if (includeAllOperationalAttributes) {
            if (builder.length() > 0) {
                builder.append(", ");
            }
            builder.append('+');
        }
        for (final AttributeDescription requestedAttribute : requestedAttributes.keySet()) {
            if (builder.length() > 0) {
                builder.append(", ");
            }
            builder.append(requestedAttribute);
        }
        return builder.toString();
    }

    /**

 opendj-core/src/main/java/org/forgerock/opendj/ldap/DN.java

@@ -912,7 +912,7 @@
            rdn.toString(builder);
            if (!parent.isRootDN()) {
                builder.append(',');
                builder.append(parent.toString());
                builder.append(parent);
            }
            stringValue = builder.toString();
        }

 opendj-core/src/main/java/org/forgerock/opendj/ldap/RDN.java

@@ -406,6 +406,6 @@
    }

    StringBuilder toString(final StringBuilder builder) {
        return builder.append(toString());
        return builder.append(this);
    }
}

 opendj-core/src/main/java/org/forgerock/opendj/ldap/controls/AssertionRequestControl.java

@@ -200,7 +200,7 @@
        builder.append(", criticality=");
        builder.append(isCritical());
        builder.append(", filter=\"");
        builder.append(filter.toString());
        builder.append(filter);
        builder.append("\")");
        return builder.toString();
    }

 opendj-core/src/main/java/org/forgerock/opendj/ldap/controls/EntryChangeNotificationResponseControl.java

@@ -347,7 +347,7 @@
        builder.append(", criticality=");
        builder.append(isCritical());
        builder.append(", changeType=");
        builder.append(changeType.toString());
        builder.append(changeType);
        builder.append(", previousDN=\"");
        builder.append(previousName);
        builder.append("\"");

 opendj-core/src/main/java/org/forgerock/opendj/ldap/schema/AttributeType.java

@@ -627,7 +627,7 @@

        if (attributeUsage != null) {
            buffer.append(" USAGE ");
            buffer.append(attributeUsage.toString());
            buffer.append(attributeUsage);
        }

        if (approximateMatchingRuleOID != null) {

 opendj-core/src/main/java/org/forgerock/opendj/ldap/schema/ObjectClass.java

@@ -415,7 +415,7 @@

        if (objectClassType != null) {
            buffer.append(" ");
            buffer.append(objectClassType.toString());
            buffer.append(objectClassType);
        }

        if (!requiredAttributeOIDs.isEmpty()) {

 opendj-core/src/test/java/org/forgerock/opendj/ldap/spi/BasicLDAPListener.java

@@ -75,7 +75,7 @@
    public String toString() {
        final StringBuilder builder = new StringBuilder();
        builder.append("LDAPListener(");
        builder.append(getSocketAddress().toString());
        builder.append(getSocketAddress());
        builder.append(')');
        return builder.toString();
    }

 opendj-grizzly/src/main/java/org/forgerock/opendj/grizzly/GrizzlyLDAPListener.java

@@ -147,7 +147,7 @@
    public String toString() {
        final StringBuilder builder = new StringBuilder();
        builder.append("LDAPListener(");
        builder.append(getSocketAddress().toString());
        builder.append(getSocketAddress());
        builder.append(')');
        return builder.toString();
    }