ConfigChangeResult.java: Added setResultCodeIfSuccess() to mirror what is i...

Jean-Noel Rouvignac

13.11.2015 41f0fa32acb3d3c105e2eb1ccd91f7941d39bf3f

ConfigChangeResult.java:
Added setResultCodeIfSuccess() to mirror what is in opendj server.

 opendj-sdk/opendj-config/src/main/java/org/forgerock/opendj/config/server/ConfigChangeResult.java

@@ -42,7 +42,7 @@
     * A set of messages describing the changes that were made, any
     * action that may be required, or any problems that were encountered.
     */
    private List<LocalizableMessage> messages = new ArrayList<LocalizableMessage>();
    private final List<LocalizableMessage> messages = new ArrayList<LocalizableMessage>();

    /**
     * Indicates whether one or more of the changes requires
@@ -82,6 +82,19 @@
    }

    /**
     * Sets the provided result code for this config change result
     * if the current result code is success.
     *
     * @param newResultCode
     *          The new result code for this config change result.
     */
    public void setResultCodeIfSuccess(ResultCode newResultCode) {
        if (getResultCode() == ResultCode.SUCCESS) {
            setResultCode(newResultCode);
        }
    }

    /**
     * Indicates whether administrative action is required before one or more of
     * the changes will take effect.
     *
@@ -155,11 +168,8 @@
        buffer.append(", messages={");

        if (!messages.isEmpty()) {
            Iterator<LocalizableMessage> iterator = messages.iterator();

            LocalizableMessage firstMessage = iterator.next();
            buffer.append(firstMessage);

            final Iterator<LocalizableMessage> iterator = messages.iterator();
            buffer.append(iterator.next());
            while (iterator.hasNext()) {
                buffer.append(",");
                buffer.append(iterator.next());