mirror of https://github.com/OpenIdentityPlatform/OpenDJ.git

Chris Ridd
12.46.2015 5adf347d468c93b593cf48883eacfa94ee8b2839
OPENDJ-2339 Avoid double escaping RDN values
3 files modified
31 ■■■■■ changed files
opendj-core/src/test/java/org/forgerock/opendj/ldap/RDNTestCase.java 14 ●●●●● patch | view | raw | blame | history
opendj-server-legacy/src/main/java/org/opends/server/types/RDN.java 3 ●●●●● patch | view | raw | blame | history
opendj-server-legacy/src/test/java/org/opends/server/types/TestRDN.java 14 ●●●●● patch | view | raw | blame | history
opendj-core/src/test/java/org/forgerock/opendj/ldap/RDNTestCase.java
@@ -22,7 +22,7 @@
 *
 *
 *      Copyright 2010 Sun Microsystems, Inc.
 *      Portions copyright 2011 ForgeRock AS.
 *      Portions copyright 2011-2015 ForgeRock AS.
 */
package org.forgerock.opendj.ldap;
@@ -417,6 +417,18 @@
    }
    /**
     * Test escaping of single space values.
     *
     * @throws Exception
     *             If the test failed unexpectedly.
     */
    @Test
    public void testEscaping() {
        RDN rdn = new RDN(ATTR_TYPE_DC, ByteString.valueOf(" "));
        assertEquals(rdn.toString(), "dc=\\ ");
    }
    /**
     * Test RDN hashCode
     *
     * @param first
opendj-server-legacy/src/main/java/org/opends/server/types/RDN.java
@@ -497,6 +497,9 @@
    if (c == ' ' || c == '#') {
      buffer.append('\\');
      buffer.append(c);
      if (length == 1) {
        return buffer.toString();
      }
      start = 1;
    }
opendj-server-legacy/src/test/java/org/opends/server/types/TestRDN.java
@@ -55,7 +55,6 @@
  private ByteString AV_CN;
  /**
   * Set up the environment for performing the tests in this suite.
   *
@@ -182,6 +181,19 @@
  /**
   * Test escaping of single space values.
   *
   * @throws Exception  If the test failed unexpectedly.
   */
  @Test
  public void testEscaping() {
    RDN rdn = new RDN(AT_DC, ByteString.valueOf(" "));
    assertEquals(rdn.toString(), "dc=\\ ");
  }
  /**
   * RDN test data provider.
   *
   * @return The array of test RDN strings.