Fix a bug in the MakeLDIF tool in which it is possible to attempt to access...

neil_a_wilson

04.08.2007 5fbd7fb2f9aec0dad7165495bd532e44307c243b

Fix a bug in the MakeLDIF tool in which it is possible to attempt to access a
slot beyond the end of the last name array when processing gets to the point at
which it reaches the end of the first and last name lists simultaneously.  In
that case, the first name counter was being reset but the last name counter was
not.

OpenDS Issue Number:  1482

 opends/src/server/org/opends/server/tools/makeldif/MakeLDIF.java

@@ -346,7 +346,7 @@
    {
      int    msgID   = MSGID_MAKELDIF_ERROR_WRITING_LDIF;
      String message = getMessage(msgID, ldifFile.getValue(),
                                  String.valueOf(e));
                                  stackTraceToSingleLineString(e));
      System.err.println(wrapText(message, MAX_LINE_WIDTH));
      return 1;
    }
@@ -402,7 +402,7 @@
    {
      int    msgID   = MSGID_MAKELDIF_CANNOT_WRITE_ENTRY;
      String message = getMessage(msgID, String.valueOf(entry.getDN()),
                                  String.valueOf(e));
                                  stackTraceToSingleLineString(e));
      throw new MakeLDIFException(msgID, message, e);
    }
  }

 opends/src/server/org/opends/server/tools/makeldif/TemplateFile.java

@@ -530,7 +530,8 @@
        }
      }
    }
    else if (lastNameIndex >= lastNames.length)

    if (lastNameIndex >= lastNames.length)
    {
      // We're at the end of the last name list, so start over.  If the last
      // name list is larger than the first name list, then we'll also need to