Fix minor issues and optimizations suggested by FindBugs and NetBeans.

Ludovic Poitou

03.43.2012 63a2096d8a12bcf1004d79532201dda28a65c8b5

Fix minor issues and optimizations suggested by FindBugs and NetBeans.

 opends/src/server/org/opends/server/protocols/internal/InternalClientConnection.java

@@ -23,7 +23,7 @@
 *
 *
 *      Copyright 2006-2009 Sun Microsystems, Inc.
 *      Portions copyright 2011 ForgeRock AS
 *      Portions copyright 2011-2012 ForgeRock AS
 */
package org.opends.server.protocols.internal;

@@ -880,14 +880,10 @@
   */
  public AddOperation processAdd(Entry entry, List<Control> controls)
  {
    if (controls == null)
    {
      controls = new ArrayList<Control>(0);
    }

    return processAdd(entry.getDN(), entry.getObjectClasses(),
                      entry.getUserAttributes(),
                      entry.getOperationalAttributes());
                      entry.getOperationalAttributes(),
                      controls);
  }