Tidy-up code after running FindBugs. Rename method clone() to duplicate() t...

Ludovic Poitou

09.39.2011 75c5db9a3f6e3cee5d4ba1fa0713ac286b3de04f

Tidy-up code after running FindBugs. Rename method clone() to duplicate() to avoid confusion with the Cloneable interface.

 opends/src/guitools/org/opends/guitools/controlpanel/datamodel/CustomSearchResult.java

@@ -23,6 +23,7 @@
 *
 *
 *      Copyright 2008-2010 Sun Microsystems, Inc.
 *      Portions Copyright 2011 ForgeRock AS
 */

package org.opends.guitools.controlpanel.datamodel;
@@ -65,7 +66,8 @@
 * exceptions that most of the methods in SearchResult throw.
 *
 */
public class CustomSearchResult implements Comparable<CustomSearchResult> {
public class CustomSearchResult implements Comparable<CustomSearchResult>
{
  private String dn;
  private Map<String, List<Object>> attributes;
  private SortedSet<String> attrNames;
@@ -213,7 +215,7 @@
  /**
   * {@inheritDoc}
   */
  public CustomSearchResult clone()
  public CustomSearchResult duplicate()
  {
    CustomSearchResult sr = new CustomSearchResult(dn);
    sr.attributes = new HashMap<String, List<Object>>(attributes);

 opends/src/guitools/org/opends/guitools/controlpanel/ui/ViewEntryPanel.java

@@ -23,6 +23,7 @@
 *
 *
 *      Copyright 2008-2010 Sun Microsystems, Inc.
 *      Portions Copyright 2011 ForgeRock AS
 */

package org.opends.guitools.controlpanel.ui;
@@ -658,7 +659,7 @@
      }
      else
      {
        filteredSr = sr.clone();
        filteredSr = sr.duplicate();
        filteredSr.set(EntryHistorical.HISTORICALATTRIBUTENAME, newValues);
      }
    }