Code cleanup removing potential issues detected by FindBugs

Ludovic Poitou

21.43.2011 7c07b3eddbd6c8d1922bdc8f0b0dbd9bc0dfe259

Code cleanup removing potential issues detected by FindBugs

 opendj-sdk/opends/src/server/org/opends/server/tools/dsconfig/HelpSubCommandHandler.java

@@ -23,6 +23,7 @@
 *
 *
 *      Copyright 2007-2008 Sun Microsystems, Inc.
 *      Portions Copyright 2011 ForgeRock AS
 */
package org.opends.server.tools.dsconfig;

@@ -800,7 +801,7 @@

    // Get the tag mapping, creating it if necessary.
    for (Tag tag : d.getAllTags()) {
      subTypes = tagMap.get(baseName);
      subTypes = tagMap.get(tag);
      if (subTypes == null) {
        subTypes = new TreeMap<String, AbstractManagedObjectDefinition<?, ?>>();
        tagMap.put(tag, subTypes);

 opendj-sdk/opends/src/server/org/opends/server/tools/dsconfig/SubCommandHandler.java

@@ -23,6 +23,7 @@
 *
 *
 *      Copyright 2007-2010 Sun Microsystems, Inc.
 *      Portions Copyright 2011 ForgeRock AS
 */
package org.opends.server.tools.dsconfig;

@@ -1257,7 +1258,7 @@
        catch (Throwable t)
        {
          // Bug
          new RuntimeException("Unexpected exception: "+t, t);
          throw new RuntimeException("Unexpected exception: "+t, t);
        }
        return MenuResult.success(children.get(children.firstKey()));
      } else {