Fix for issue 4156.

boli

30.19.2009 7cb885d39d1bda97e32574c9d65a494c3fcbf4b8

Fix for issue 4156. 

- Disconnect notifications are no longer sent when IO errors or client disconnects are encountered. 
- TLSByteChannel now  throws SSLException if SSLEngine.wrap did not produce any bytes.

 opends/src/server/org/opends/server/extensions/TLSByteChannel.java

@@ -35,11 +35,8 @@
import java.util.LinkedHashMap;
import java.util.Map;
import java.util.Set;
import javax.net.ssl.SSLContext;
import javax.net.ssl.SSLEngine;
import javax.net.ssl.SSLEngineResult;
import javax.net.ssl.SSLPeerUnverifiedException;
import javax.net.ssl.SSLSession;
import javax.net.ssl.*;

import org.opends.server.admin.std.server.LDAPConnectionHandlerCfg;
import org.opends.server.api.ClientConnection;
import org.opends.server.loggers.debug.DebugTracer;
@@ -359,6 +356,12 @@
            netData.clear();
            SSLEngineResult res = sslEngine.wrap(clearData, netData);
            netData.flip();
            if(netData.remaining() == 0)
            {
              // wrap didn't produce any data from our clear buffer.
              // Throw exception to prevent looping.
              throw new SSLException("SSLEngine.wrap produced 0 bytes");
            }
            if(res.getStatus() != SSLEngineResult.Status.OK)
                throw new ClosedChannelException();
            if (hsStatus == SSLEngineResult.HandshakeStatus.NEED_TASK ||

 opends/src/server/org/opends/server/protocols/ldap/LDAPClientConnection.java

@@ -845,7 +845,7 @@
      }

      // FIXME -- Log a message or something
      disconnect(DisconnectReason.SERVER_ERROR, true, null);
      disconnect(DisconnectReason.SERVER_ERROR, false, null);
      return;
    }
  }
@@ -1469,7 +1469,7 @@
        Message m =
            ERR_LDAP_CLIENT_DECODE_LDAP_MESSAGE_FAILED.get(String
                .valueOf(e));
        disconnect(DisconnectReason.PROTOCOL_ERROR, true, m);
        disconnect(DisconnectReason.PROTOCOL_ERROR, false, m);
        return false;
      }
    }