Most of the Exceptions that were thrown when a bug was detected where Illeg...

jvergara

28.09.2009 95b972d6e249498f9a5fa44d166a47eb52cf0853

Most of the Exceptions that were thrown when a bug was detected where IllegalStateException.  This was not very strict, so when that usage is not appropriate RuntimeException is used.

Fixed also a couple of typos in the thrown runtime exceptions.

 opends/src/guitools/org/opends/guitools/controlpanel/browser/BrowserController.java

@@ -1338,7 +1338,7 @@
      catch (IOException ioe)
      {
        // Bug
        throw new IllegalStateException("Unexpected encoding exception: "+ioe,
        throw new RuntimeException("Unexpected encoding exception: "+ioe,
            ioe);
      }
    }
@@ -1521,7 +1521,7 @@
    }

    if (node.isLeaf() && (node.getChildCount() >= 1)) {
      throw new IllegalStateException("Inconsistent node: " + node.getDN());
      throw new RuntimeException("Inconsistent node: " + node.getDN());
    }

  }

 opends/src/guitools/org/opends/guitools/controlpanel/browser/LDAPConnectionPool.java

@@ -22,7 +22,7 @@
 * CDDL HEADER END
 *
 *
 *      Copyright 2008 Sun Microsystems, Inc.
 *      Copyright 2008-2009 Sun Microsystems, Inc.
 */

package org.opends.guitools.controlpanel.browser;
@@ -370,7 +370,7 @@
          ConnectionUtils.getBindPassword(ctx), false);
    }
    catch (NamingException x) {
      throw new IllegalStateException("Bug");
      throw new RuntimeException("Bug");
    }
  }


 opends/src/guitools/org/opends/guitools/controlpanel/browser/NodeRefresher.java

@@ -22,7 +22,7 @@
 * CDDL HEADER END
 *
 *
 *      Copyright 2008 Sun Microsystems, Inc.
 *      Copyright 2008-2009 Sun Microsystems, Inc.
 */

package org.opends.guitools.controlpanel.browser;
@@ -681,7 +681,7 @@
      }
      catch (Throwable t)
      {
        throw new IllegalStateException("Error decoding dn: "+parentDn+" . "+t,
        throw new RuntimeException("Error decoding dn: "+parentDn+" . "+t,
            t);
      }
      NamingEnumeration<SearchResult> entries = ctx.search(
@@ -714,7 +714,7 @@
          }
          catch (Throwable t)
          {
            throw new IllegalStateException("Error decoding dns: "+t, t);
            throw new RuntimeException("Error decoding dns: "+t, t);
          }

          if (!add)
@@ -743,7 +743,7 @@
              }
              catch (Throwable t)
              {
                throw new IllegalStateException("Error decoding dn: "+
                throw new RuntimeException("Error decoding dn: "+
                    addedEntry.getName()+" . "+t, t);
              }
            }
@@ -771,7 +771,7 @@
                      }
                      catch (Throwable t)
                      {
                        throw new IllegalStateException("Error decoding dn: "+
                        throw new RuntimeException("Error decoding dn: "+
                            node.getDN()+" . "+t, t);
                      }
                    }

 opends/src/guitools/org/opends/guitools/controlpanel/datamodel/BinaryValue.java

@@ -22,7 +22,7 @@
 * CDDL HEADER END
 *
 *
 *      Copyright 2008 Sun Microsystems, Inc.
 *      Copyright 2008-2009 Sun Microsystems, Inc.
 */

package org.opends.guitools.controlpanel.datamodel;
@@ -222,7 +222,7 @@
              }
              catch (ParseException pe)
              {
                throw new IllegalStateException(
                throw new RuntimeException(
                    "Unexpected error getting bytes: "+pe, pe);
              }
            }

 opends/src/guitools/org/opends/guitools/controlpanel/datamodel/ConnectionHandlerTableModel.java

@@ -337,7 +337,7 @@
        break;

      default:
        throw new IllegalStateException("Unknown state: "+desc.getState());
        throw new RuntimeException("Unknown state: "+desc.getState());
      }
      dataArray.add(s);
    }

 opends/src/guitools/org/opends/guitools/controlpanel/datamodel/ControlPanelInfo.java

@@ -1177,7 +1177,7 @@
      }
      break;
    default:
      throw new IllegalStateException("Unknown policy: "+getConnectionPolicy());
      throw new RuntimeException("Unknown policy: "+getConnectionPolicy());
    }
    return url;
  }

 opends/src/guitools/org/opends/guitools/controlpanel/datamodel/IndexTableModel.java

@@ -22,7 +22,7 @@
 * CDDL HEADER END
 *
 *
 *      Copyright 2008 Sun Microsystems, Inc.
 *      Copyright 2008-2009 Sun Microsystems, Inc.
 */

package org.opends.guitools.controlpanel.datamodel;
@@ -168,7 +168,7 @@
        v = INFO_CTRL_PANEL_INDEX_APPROXIMATE.get();
        break;
      default:
        throw new IllegalStateException("Unknown index type: "+type);
        throw new RuntimeException("Unknown index type: "+type);
      }
      if (sb.length() > 0)
      {

 opends/src/guitools/org/opends/guitools/controlpanel/datamodel/ScheduleType.java

@@ -199,7 +199,7 @@
      toString = "Schedule Type: periodical schedule "+cronValue;
      break;
      default:
        throw new IllegalStateException("Invalid type: "+type);
        throw new RuntimeException("Invalid type: "+type);
    }
    return toString;
  }

 opends/src/guitools/org/opends/guitools/controlpanel/datamodel/VLVIndexTableModel.java

@@ -22,7 +22,7 @@
 * CDDL HEADER END
 *
 *
 *      Copyright 2008 Sun Microsystems, Inc.
 *      Copyright 2008-2009 Sun Microsystems, Inc.
 */

package org.opends.guitools.controlpanel.datamodel;
@@ -141,7 +141,7 @@
      s = "Subordinate Subtree";
      break;
    default:
      throw new IllegalStateException("Unknow scope: "+i.getScope());
      throw new RuntimeException("Unknown scope: "+i.getScope());
    }
    return s;
  }

 opends/src/guitools/org/opends/guitools/controlpanel/event/BrowseActionListener.java

@@ -22,7 +22,7 @@
 * CDDL HEADER END
 *
 *
 *      Copyright 2008 Sun Microsystems, Inc.
 *      Copyright 2008-2009 Sun Microsystems, Inc.
 */

package org.opends.guitools.controlpanel.event;
@@ -242,7 +242,7 @@
      break;

    default:
      throw new IllegalStateException("Unknown type: " + type);
      throw new RuntimeException("Unknown type: " + type);
    }

    if (returnVal == JFileChooser.APPROVE_OPTION)

 opends/src/guitools/org/opends/guitools/controlpanel/task/DeleteEntryTask.java

@@ -108,7 +108,7 @@
      }
      catch (DirectoryException de)
      {
        throw new IllegalStateException("Unexpected error parsing dn: "+
        throw new RuntimeException("Unexpected error parsing dn: "+
            node.getDN(), de);
      }
    }
@@ -253,7 +253,7 @@
        }
        catch (DirectoryException de)
        {
          throw new IllegalStateException("Unexpected error parsing dn: "+
          throw new RuntimeException("Unexpected error parsing dn: "+
              node.getDN(), de);
        }
      }

 opends/src/guitools/org/opends/guitools/controlpanel/task/ModifyEntryTask.java

@@ -122,7 +122,7 @@
    }
    catch (OpenDsException ode)
    {
      throw new IllegalStateException("Could not parse DN: "+oldEntry.getDN(),
      throw new RuntimeException("Could not parse DN: "+oldEntry.getDN(),
          ode);
    }
    modifications = getModifications(newEntry, oldEntry, getInfo());
@@ -314,7 +314,7 @@
          }
          catch (Throwable t)
          {
            throw new IllegalStateException("Unexpected error: "+t, t);
            throw new RuntimeException("Unexpected error: "+t, t);
          }
        }
        else
@@ -343,7 +343,7 @@
      catch (NamingException ne)
      {
        // This should not happen
        throw new IllegalStateException("Unexpected exception: "+ne, ne);
        throw new RuntimeException("Unexpected exception: "+ne, ne);
      }
    }
  }
@@ -549,7 +549,7 @@
      }
      catch (DirectoryException de)
      {
        throw new IllegalStateException("Unexpected error parsing DN: "+
        throw new RuntimeException("Unexpected error parsing DN: "+
            oldEntry.getDN(), de);
      }
      for (int i=0; i<oldRDN.getNumValues(); i++)

 opends/src/guitools/org/opends/guitools/controlpanel/task/NewEntryTask.java

@@ -364,7 +364,7 @@
      catch (Throwable t)
      {
        // Bug
        throw new IllegalStateException("Unexpected error: "+t, t);
        throw new RuntimeException("Unexpected error: "+t, t);
      }
    }
    return parentNode;

 opends/src/guitools/org/opends/guitools/controlpanel/task/ResetUserPasswordTask.java

@@ -100,7 +100,7 @@
    }
    catch (OpenDsException ode)
    {
      throw new IllegalStateException("Could not parse DN: "+node.getDN(), ode);
      throw new RuntimeException("Could not parse DN: "+node.getDN(), ode);
    }
    try
    {

 opends/src/guitools/org/opends/guitools/controlpanel/task/Task.java

@@ -979,7 +979,7 @@
        catch (NamingException ne)
        {
          // Bug
          throw new IllegalStateException(
          throw new RuntimeException(
              "Unexpected error parsing modifications: "+ne, ne);
        }
      }

 opends/src/guitools/org/opends/guitools/controlpanel/ui/AbstractBrowseEntriesPanel.java

@@ -448,7 +448,7 @@
            }
            catch (Throwable t)
            {
              throw new IllegalStateException("Unexpected error decoding dn "+
              throw new RuntimeException("Unexpected error decoding dn "+
                  newBaseDn, t);
            }
            if (newElement != null)
@@ -1180,7 +1180,7 @@
          }
          catch (Throwable t)
          {
            throw new IllegalStateException("Unexpected error: "+t, t);
            throw new RuntimeException("Unexpected error: "+t, t);
          }
          if (baseDN.getEntries() > 0)
          {

 opends/src/guitools/org/opends/guitools/controlpanel/ui/AbstractNewEntryPanel.java

@@ -22,7 +22,7 @@
 * CDDL HEADER END
 *
 *
 *      Copyright 2008 Sun Microsystems, Inc.
 *      Copyright 2008-2009 Sun Microsystems, Inc.
 */

package org.opends.guitools.controlpanel.ui;
@@ -168,7 +168,7 @@
      catch (Throwable t)
      {
        // Unexpected error: getEntry() should work after calling checkSyntax
        throw new IllegalStateException("Unexpected error: "+t, t);
        throw new RuntimeException("Unexpected error: "+t, t);
      }
      String dn = entry.getDN().toString();
      // Checking for the existence of an entry is fast enough so we can do
@@ -208,7 +208,7 @@
      catch (Throwable t)
      {
        // Unexpected error: getEntry() should work after calling checkSyntax
        throw new IllegalStateException("Unexpected error: "+t, t);
        throw new RuntimeException("Unexpected error: "+t, t);
      }
    }
    if (errors.size() > 0)

 opends/src/guitools/org/opends/guitools/controlpanel/ui/AbstractVLVIndexPanel.java

@@ -22,7 +22,7 @@
 * CDDL HEADER END
 *
 *
 *      Copyright 2008 Sun Microsystems, Inc.
 *      Copyright 2008-2009 Sun Microsystems, Inc.
 */


@@ -604,7 +604,7 @@
    catch (Throwable t)
    {
      // Bug
      throw new IllegalStateException("Unexpected error: "+t, t);
      throw new RuntimeException("Unexpected error: "+t, t);
    }
    return confirm;
  }
@@ -730,7 +730,7 @@
      }
      catch (Throwable t)
      {
        throw new IllegalStateException("Unexpected error: "+t, t);
        throw new RuntimeException("Unexpected error: "+t, t);
      }
      newElements.add(dn);
    }

 opends/src/guitools/org/opends/guitools/controlpanel/ui/AddToGroupPanel.java

@@ -22,7 +22,7 @@
 * CDDL HEADER END
 *
 *
 *      Copyright 2008 Sun Microsystems, Inc.
 *      Copyright 2008-2009 Sun Microsystems, Inc.
 */

package org.opends.guitools.controlpanel.ui;
@@ -446,7 +446,7 @@
      }
      catch (OpenDsException ode)
      {
        throw new IllegalStateException(
        throw new RuntimeException(
            "Unexpected error decoding dn. Details: "+ode.getMessageObject(),
            ode);
      }
@@ -475,7 +475,7 @@
      catch (Throwable t)
      {
        // Unexpected error: getEntry() should work after calling checkSyntax
        throw new IllegalStateException("Unexpected error: "+t, t);
        throw new RuntimeException("Unexpected error: "+t, t);
      }
    }
    if (errors.size() > 0)

 opends/src/guitools/org/opends/guitools/controlpanel/ui/BrowseEntriesPanel.java

@@ -993,7 +993,7 @@
        }
        catch (OpenDsException ode)
        {
          throw new IllegalStateException(
          throw new RuntimeException(
              "Unexpected error decoding dn. Details: "+ode.getMessageObject(),
              ode);
        }

 opends/src/guitools/org/opends/guitools/controlpanel/ui/BrowseGeneralMonitoringPanel.java

@@ -534,7 +534,7 @@
          entryPane.updateJavaInformation();
          break;
        default:
          throw new IllegalStateException("Unknown node type: "+type);
          throw new RuntimeException("Unknown node type: "+type);
        }
      }
      else
@@ -673,7 +673,7 @@
      }
      else
      {
        throw new IllegalStateException("Unexpected tree node: "+value);
        throw new RuntimeException("Unexpected tree node: "+value);
      }
      return icon;
    }

 opends/src/guitools/org/opends/guitools/controlpanel/ui/JavaInformationMonitoringPanel.java

@@ -331,7 +331,7 @@
        }
        else
        {
          throw new IllegalStateException("Unexpected component: "+l);
          throw new RuntimeException("Unexpected component: "+l);
        }
      }
    }
@@ -349,7 +349,7 @@
        }
        else
        {
          throw new IllegalStateException("Unexpected component: "+l);
          throw new RuntimeException("Unexpected component: "+l);
        }
      }
    }

 opends/src/guitools/org/opends/guitools/controlpanel/ui/LDAPEntryPanel.java

@@ -22,7 +22,7 @@
 * CDDL HEADER END
 *
 *
 *      Copyright 2008 Sun Microsystems, Inc.
 *      Copyright 2008-2009 Sun Microsystems, Inc.
 */

package org.opends.guitools.controlpanel.ui;
@@ -461,7 +461,7 @@
    }
    catch (Throwable t)
    {
      throw new IllegalStateException("Error decoding DNs: "+t, t);
      throw new RuntimeException("Error decoding DNs: "+t, t);
    }
  }

@@ -493,7 +493,7 @@
    }
    catch (Throwable t)
    {
      throw new IllegalStateException("Error decoding DNs: "+t, t);
      throw new RuntimeException("Error decoding DNs: "+t, t);
    }
    return isReadOnly;
  }
@@ -537,7 +537,7 @@
    }
    catch (Throwable t)
    {
      throw new IllegalStateException("Error decoding DNs: "+t, t);
      throw new RuntimeException("Error decoding DNs: "+t, t);
    }
    return canDelete;
  }

 opends/src/guitools/org/opends/guitools/controlpanel/ui/NewGroupPanel.java

@@ -22,7 +22,7 @@
 * CDDL HEADER END
 *
 *
 *      Copyright 2008 Sun Microsystems, Inc.
 *      Copyright 2008-2009 Sun Microsystems, Inc.
 */

package org.opends.guitools.controlpanel.ui;
@@ -764,7 +764,7 @@
          }
          catch (OpenDsException ode)
          {
            throw new IllegalStateException("Unexpected error decoding DN: "+
            throw new RuntimeException("Unexpected error decoding DN: "+
                member, ode);
          }
        }

 opends/src/guitools/org/opends/guitools/controlpanel/ui/NewOrganizationalUnitPanel.java

@@ -22,7 +22,7 @@
 * CDDL HEADER END
 *
 *
 *      Copyright 2008 Sun Microsystems, Inc.
 *      Copyright 2008-2009 Sun Microsystems, Inc.
 */

package org.opends.guitools.controlpanel.ui;
@@ -161,7 +161,7 @@
      catch (IOException ioe)
      {
        // This should not occur
        throw new IllegalStateException("Unexpected error: "+ioe, ioe);
        throw new RuntimeException("Unexpected error: "+ioe, ioe);
      }
    }
  }

 opends/src/guitools/org/opends/guitools/controlpanel/ui/NewUserPanel.java

@@ -22,7 +22,7 @@
 * CDDL HEADER END
 *
 *
 *      Copyright 2008 Sun Microsystems, Inc.
 *      Copyright 2008-2009 Sun Microsystems, Inc.
 */

package org.opends.guitools.controlpanel.ui;
@@ -226,7 +226,7 @@
      catch (IOException ioe)
      {
        // This should not occur
        throw new IllegalStateException("Unexpected error: "+ioe, ioe);
        throw new RuntimeException("Unexpected error: "+ioe, ioe);
      }
    }
  }

 opends/src/guitools/org/opends/guitools/controlpanel/ui/SimplifiedViewEntryPanel.java

@@ -1701,7 +1701,7 @@
    }
    catch (Throwable t)
    {
      throw new IllegalStateException("Unexpected error: "+t, t);
      throw new RuntimeException("Unexpected error: "+t, t);
    }
    return sb.toString();
  }
@@ -2068,7 +2068,7 @@
          }
          catch (ParseException pe)
          {
            throw new IllegalStateException("Unexpected error: "+pe);
            throw new RuntimeException("Unexpected error: "+pe);
          }
        }
        else

 opends/src/guitools/org/opends/guitools/controlpanel/ui/StatusGenericPanel.java

@@ -1358,7 +1358,7 @@
          }
          catch (Throwable t)
          {
            throw new IllegalStateException("Unexpected error: "+t, t);
            throw new RuntimeException("Unexpected error: "+t, t);
          }
        }
        hmBaseDNs.put(backendID, baseDNs);
@@ -1476,7 +1476,7 @@
            }
            catch (Throwable t)
            {
              throw new IllegalStateException("Unexpected error: "+t, t);
              throw new RuntimeException("Unexpected error: "+t, t);
            }
            dns.add(dn);
            SortedSet<AbstractIndexDescriptor> indexes =
@@ -1878,7 +1878,7 @@
      int n = Integer.parseInt(stringValue);
      if ((n > maxValue) || (n < minValue))
      {
        throw new IllegalStateException("Invalid value");
        throw new RuntimeException("Invalid value");
      }
    }
    catch (Throwable t)

 opends/src/guitools/org/opends/guitools/controlpanel/ui/StatusPanel.java

@@ -386,7 +386,7 @@
      }
      catch (Throwable t)
      {
        throw new IllegalStateException("Unexpected error: "+t, t);
        throw new RuntimeException("Unexpected error: "+t, t);
      }
    }

@@ -884,7 +884,7 @@
      break;

    default:
      throw new IllegalStateException("Unknown status: "+desc.getStatus());
      throw new RuntimeException("Unknown status: "+desc.getStatus());
    }
    return status.toString();
  }

 opends/src/guitools/org/opends/guitools/controlpanel/ui/TableViewEntryPanel.java

@@ -403,7 +403,7 @@
    }
    catch (Throwable t)
    {
      throw new IllegalStateException("Unexpected error: "+t, t);
      throw new RuntimeException("Unexpected error: "+t, t);
    }
    return sb.toString();
  }

 opends/src/guitools/org/opends/guitools/controlpanel/ui/TaskToSchedulePanel.java

@@ -664,7 +664,7 @@
    }
    else
    {
      throw new IllegalStateException("Unknown schedule type: "+type);
      throw new RuntimeException("Unknown schedule type: "+type);
    }
    return schedule;
  }

 opends/src/guitools/org/opends/guitools/controlpanel/ui/VLVIndexPanel.java

@@ -930,7 +930,7 @@
      }
      catch (OpenDsException odse)
      {
        throw new IllegalStateException("Unexpected error parsing DN "+
        throw new RuntimeException("Unexpected error parsing DN "+
            getBaseDN()+": "+odse, odse);
      }
      if (indexToModify.getScope() != scope)

 opends/src/guitools/org/opends/guitools/controlpanel/ui/ViewEntryPanel.java

@@ -618,7 +618,7 @@
        }
        catch (ParseException pe)
        {
         throw new IllegalStateException("Unexpected error: "+pe, pe);
         throw new RuntimeException("Unexpected error: "+pe, pe);
        }
      }
      else

 opends/src/guitools/org/opends/guitools/controlpanel/ui/components/ScheduleSummaryPanel.java

@@ -160,7 +160,7 @@
    }
    else
    {
      throw new IllegalStateException("Unknown schedule type: "+type);
      throw new RuntimeException("Unknown schedule type: "+type);
    }
  }


 opends/src/guitools/org/opends/guitools/controlpanel/util/ConfigFromDirContext.java

@@ -136,7 +136,7 @@
    }
    catch (Throwable t)
    {
      throw new IllegalStateException("Could not decode DNs: "+t, t);
      throw new RuntimeException("Could not decode DNs: "+t, t);
    }
  }


 opends/src/guitools/org/opends/guitools/controlpanel/util/NumSubordinateHacker.java

@@ -22,7 +22,7 @@
 * CDDL HEADER END
 *
 *
 *      Copyright 2008 Sun Microsystems, Inc.
 *      Copyright 2008-2009 Sun Microsystems, Inc.
 */

package org.opends.guitools.controlpanel.util;
@@ -82,7 +82,7 @@
          }
          catch (OpenDsException oe)
          {
            throw new IllegalStateException("Error decoding DN of url: "+
            throw new RuntimeException("Error decoding DN of url: "+
                parentUrl);
          }
        }
@@ -119,7 +119,7 @@
          }
          catch (OpenDsException oe)
          {
            throw new IllegalStateException("Error decoding DN of url: "+
            throw new RuntimeException("Error decoding DN of url: "+
                url);
          }
        }

 opends/src/guitools/org/opends/guitools/controlpanel/util/Utilities.java

@@ -1191,7 +1191,7 @@
            b = (byte) 0xF0;
            break;
          default:
            throw new IllegalStateException("Unexpected byte: "+escapedByte1);
            throw new RuntimeException("Unexpected byte: "+escapedByte1);
          }

          byte escapedByte2 = stringBytes[++i];
@@ -1251,7 +1251,7 @@
            b |= 0x0F;
            break;
          default:
            throw new IllegalStateException("Unexpected byte: "+escapedByte2);
            throw new RuntimeException("Unexpected byte: "+escapedByte2);
          }

          decodedBytes[pos++] = b;
@@ -1265,7 +1265,7 @@
    catch (UnsupportedEncodingException uee)
    {
//    This is a bug, UTF-8 should be supported always by the JVM
      throw new IllegalStateException("UTF-8 encoding not supported", uee);
      throw new RuntimeException("UTF-8 encoding not supported", uee);
    }
  }