OPENDJ-2778 Fix upgrade return code

Gaetan Boismal

15.40.2016 9b7843793e41330e503f2a87751eeae5380e4fef

OPENDJ-2778 Fix upgrade return code

If a post upgrade task (such as rebuild-index) was failed, the upgrade
tool printed the error but returned 0 instead of an error code.

 opendj-server-legacy/src/main/java/org/opends/server/tools/upgrade/Upgrade.java

@@ -785,6 +785,7 @@
        catch (ClientException e)
        {
          context.notify(e.getMessageObject(), WARNING);
          needToExitWithErrorCode();
          isOk = false;
        }
      }