mirror of https://github.com/OpenIdentityPlatform/OpenDJ.git

Jean-Noel Rouvignac
17.57.2014 a1661cae30dc07497774b141ab0ec2ff5b567feb
OPENDJ-1368 Remove AttributeValue

Code review: Matthew Swift


Removing the last calls to AttributeValue.getNormalizedValue().


SortValues.java:
Added types field + getter.

SortValuesSet.java:
In add(), remove(), binarySearch() and attributeValuesToDatabase(), passed in AttributeType array as a parameter.

VLVIndex.java:
In getSortValuesSet(), containsValues() and encodeKey(), passed in AttributeType array as a parameter.
Added getSortTypes() and encodeKey().

VLVKeyComparator.java:
In compare(), passed in AttributeType array as a parameter.

VerifyJob.java, TestVerifyJob.java, TestVLVIndex.java:
Consequence of the changes above.

TestVLVIndex.java:
Extracted method getSortValuesSet().

StringPrepProfileTestCase.java:
Removed unused import.
2 files modified
4 ■■■■ changed files
opendj3-server-dev/src/server/org/opends/server/types/SortKey.java 2 ●●●●● patch | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/types/SortOrder.java 2 ●●●●● patch | view | raw | blame | history
opendj3-server-dev/src/server/org/opends/server/types/SortKey.java
@@ -37,6 +37,8 @@
 * contain a specific ordering matching rule that should be used for
 * the sorting process, although if none is provided it will use the
 * default ordering matching rule for the attribute type.
 * <p>
 * FIXME: replace with the equivalent SDK type.
 */
@org.opends.server.types.PublicAPI(
     stability=org.opends.server.types.StabilityLevel.VOLATILE,
opendj3-server-dev/src/server/org/opends/server/types/SortOrder.java
@@ -39,6 +39,8 @@
 * will only be used if the first and second values are equal, etc.
 * If all of the sort key attributes for two entries are identical,
 * then the relative order for those entries is undefined.
 * <p>
 * FIXME: replace with the SDK's SortKey?
 */
@org.opends.server.types.PublicAPI(
     stability=org.opends.server.types.StabilityLevel.VOLATILE,