mirror of https://github.com/OpenIdentityPlatform/OpenDJ.git

neil_a_wilson
10.23.2006 bb40b9a02cf40af0349d8e3576f51133d264d4b1
Make all of the plugin result objects immutable, and create a default SUCCESS
instance for each of them that may be used if all processing completed
successfully. Update all uses of the plugin result objects to use this SUCCESS
instance where applicable.

OpenDS Issue Number: 774
22 files modified
1136 ■■■■ changed files
opends/src/server/org/opends/server/api/plugin/IntermediateResponsePluginResult.java 101 ●●●● patch | view | raw | blame | history
opends/src/server/org/opends/server/api/plugin/LDIFPluginResult.java 59 ●●●● patch | view | raw | blame | history
opends/src/server/org/opends/server/api/plugin/PostConnectPluginResult.java 57 ●●●● patch | view | raw | blame | history
opends/src/server/org/opends/server/api/plugin/PostDisconnectPluginResult.java 36 ●●●●● patch | view | raw | blame | history
opends/src/server/org/opends/server/api/plugin/PostOperationPluginResult.java 57 ●●●● patch | view | raw | blame | history
opends/src/server/org/opends/server/api/plugin/PostResponsePluginResult.java 57 ●●●● patch | view | raw | blame | history
opends/src/server/org/opends/server/api/plugin/PreOperationPluginResult.java 82 ●●●● patch | view | raw | blame | history
opends/src/server/org/opends/server/api/plugin/PreParsePluginResult.java 82 ●●●● patch | view | raw | blame | history
opends/src/server/org/opends/server/api/plugin/SearchEntryPluginResult.java 99 ●●●● patch | view | raw | blame | history
opends/src/server/org/opends/server/api/plugin/SearchReferencePluginResult.java 100 ●●●● patch | view | raw | blame | history
opends/src/server/org/opends/server/api/plugin/StartupPluginResult.java 96 ●●●● patch | view | raw | blame | history
opends/src/server/org/opends/server/core/PluginConfigManager.java 88 ●●●● patch | view | raw | blame | history
opends/src/server/org/opends/server/plugins/EntryUUIDPlugin.java 8 ●●●● patch | view | raw | blame | history
opends/src/server/org/opends/server/plugins/LDAPADListPlugin.java 2 ●●● patch | view | raw | blame | history
opends/src/server/org/opends/server/plugins/LastModPlugin.java 6 ●●●● patch | view | raw | blame | history
opends/src/server/org/opends/server/plugins/PasswordPolicyImportPlugin.java 2 ●●● patch | view | raw | blame | history
opends/src/server/org/opends/server/plugins/profiler/ProfilerPlugin.java 2 ●●● patch | view | raw | blame | history
opends/tests/unit-tests-testng/src/server/org/opends/server/plugins/DelayPreOpPlugin.java 2 ●●● patch | view | raw | blame | history
opends/tests/unit-tests-testng/src/server/org/opends/server/plugins/DisconnectClientPlugin.java 72 ●●●● patch | view | raw | blame | history
opends/tests/unit-tests-testng/src/server/org/opends/server/plugins/InvocationCounterPlugin.java 88 ●●●● patch | view | raw | blame | history
opends/tests/unit-tests-testng/src/server/org/opends/server/plugins/ShortCircuitPlugin.java 36 ●●●● patch | view | raw | blame | history
opends/tests/unit-tests-testng/src/server/org/opends/server/plugins/UpdatePreOpPlugin.java 4 ●●●● patch | view | raw | blame | history
opends/src/server/org/opends/server/api/plugin/IntermediateResponsePluginResult.java
@@ -47,21 +47,30 @@
  /**
   * An intermediate response plugin result instance that indicates
   * all processing was successful.
   */
  public static final IntermediateResponsePluginResult SUCCESS =
       new IntermediateResponsePluginResult();
  // Indicates whether any further intermediate response plugins
  // should be invoked for this operation.
  private boolean continuePluginProcessing;
  private final boolean continuePluginProcessing;
  // Indicates whether processing should continue for the associated
  // operation.
  private boolean continueOperation;
  private final boolean continueOperation;
  // Indicates whether the intermediate response plugin terminated the
  // client connection.
  private boolean connectionTerminated;
  private final boolean connectionTerminated;
  // Indicates whether the associated intermediate response message
  // should be sent to the client.
  private boolean sendIntermediateResponse;
  private final boolean sendIntermediateResponse;
@@ -73,14 +82,9 @@
   * be returned to the client, and that processing on the associated
   * operation should continue.
   */
  public IntermediateResponsePluginResult()
  private IntermediateResponsePluginResult()
  {
    assert debugConstructor(CLASS_NAME);
    this.connectionTerminated     = false;
    this.continuePluginProcessing = true;
    this.sendIntermediateResponse = true;
    this.continueOperation        = true;
    this(false, true, true, true);
  }
@@ -142,24 +146,6 @@
  /**
   * Specifies whether the intermediate response plugin terminated the
   * client connection.
   *
   * @param  connectionTerminated  Specifies whether the intermediate
   *                               response plugin terminated the
   *                               client connection.
   */
  public void setConnectionTerminated(boolean connectionTerminated)
  {
    assert debugEnter(CLASS_NAME, "setConnectionTerminated",
                      String.valueOf(connectionTerminated));
    this.connectionTerminated = connectionTerminated;
  }
  /**
   * Indicates whether any further intermediate response plugins
   * should be invoked for this operation.
   *
@@ -177,26 +163,6 @@
  /**
   * Specifies whether any further intermediate response plugins
   * should be invoked for this operation.
   *
   * @param  continuePluginProcessing  Specifies whether any further
   *                                   intermediate response plugins
   *                                   should be invoked for this
   *                                   operation.
   */
  public void setContinuePluginProcessing(
                   boolean continuePluginProcessing)
  {
    assert debugEnter(CLASS_NAME, "setContinuePluginProcessing",
                      String.valueOf(continuePluginProcessing));
    this.continuePluginProcessing = continuePluginProcessing;
  }
  /**
   * Indicates whether the associated intermediate response message
   * should be sent to the client.
   *
@@ -214,26 +180,6 @@
  /**
   * Specifies whether the associated intermediate response message
   * should be sent to the client.
   *
   * @param  sendIntermediateResponse  Specifies whether the
   *                                   associated intermediate
   *                                   response message should be sent
   *                                   to the client.
   */
  public void setSendIntermediateResponse(
                   boolean sendIntermediateResponse)
  {
    assert debugEnter(CLASS_NAME, "setSendIntermediateResponse",
                      String.valueOf(sendIntermediateResponse));
    this.sendIntermediateResponse = sendIntermediateResponse;
  }
  /**
   * Indicates whether processing should continue for the associated
   * operation.
   *
@@ -250,23 +196,6 @@
  /**
   * Specifies whether processing should continue for the associated
   * operation.
   *
   * @param  continueOperation  Specifies whether processing should
   *                            continue for the associated operation.
   */
  public void setContinueOperation(boolean continueOperation)
  {
    assert debugEnter(CLASS_NAME, "setContinueOperation",
                      String.valueOf(continueOperation));
    this.continueOperation = continueOperation;
  }
  /**
   * Retrieves a string representation of this intermediate response
   * plugin result.
   *
opends/src/server/org/opends/server/api/plugin/LDIFPluginResult.java
@@ -46,13 +46,22 @@
  /**
   * An LDIF plugin result instance that indicates all processing was
   * successful.
   */
  public static final LDIFPluginResult SUCCESS =
       new LDIFPluginResult();
  // Indicates whether any further LDIF import/export plugins should
  // be invoked for the associated entry.
  private boolean continuePluginProcessing;
  private final boolean continuePluginProcessing;
  // Indicates whether the associated entry should still be
  // imported/exported.
  private boolean continueEntryProcessing;
  private final boolean continueEntryProcessing;
@@ -61,12 +70,9 @@
   * this case, it will indicate that all processing should continue
   * as normal.
   */
  public LDIFPluginResult()
  private LDIFPluginResult()
  {
    assert debugConstructor(CLASS_NAME);
    this.continuePluginProcessing = true;
    this.continueEntryProcessing  = true;
    this(true, true);
  }
@@ -114,26 +120,6 @@
  /**
   * Specifies whether any further LDIF import/export plugins should
   * be invoked for the associated entry.
   *
   * @param  continuePluginProcessing  Specifies whether any further
   *                                   LDIF import/export plugins
   *                                   should be invoked for the
   *                                   associated entry.
   */
  public void setContinuePluginProcessing(
                   boolean continuePluginProcessing)
  {
    assert debugEnter(CLASS_NAME, "setContinuePluginProcessing",
                      String.valueOf(continuePluginProcessing));
    this.continuePluginProcessing = continuePluginProcessing;
  }
  /**
   * Indicates whether the associated entry should still be
   * imported/exported.
   *
@@ -150,25 +136,6 @@
  /**
   * Specifies whether the associated entry should still be
   * imported/exported.
   *
   * @param  continueEntryProcessing  Specifies whether the associated
   *                                  entry should still be
   *                                  imported/exported.
   */
  public void setContinueEntryProcessing(
                   boolean continueEntryProcessing)
  {
    assert debugEnter(CLASS_NAME, "setContinueEntryProcessing",
                      String.valueOf(continueEntryProcessing));
    this.continueEntryProcessing = continueEntryProcessing;
  }
  /**
   * Retrieves a string representation of this post-response plugin
   * result.
   *
opends/src/server/org/opends/server/api/plugin/PostConnectPluginResult.java
@@ -46,13 +46,22 @@
  /**
   * A post-connect plugin result instance that indicates all
   * processing was  successful.
   */
  public static final PostConnectPluginResult SUCCESS =
       new PostConnectPluginResult();
  // Indicates whether any further post-connect plugins should be
  // invoked for this connection.
  private boolean continuePluginProcessing;
  private final boolean continuePluginProcessing;
  // Indicates whether the post-connect plugin terminated the client
  // connection.
  private boolean connectionTerminated;
  private final boolean connectionTerminated;
@@ -62,12 +71,9 @@
   * not been terminated and that further post-connect plugin
   * processing should be allowed.
   */
  public PostConnectPluginResult()
  private PostConnectPluginResult()
  {
    assert debugConstructor(CLASS_NAME);
    this.connectionTerminated     = false;
    this.continuePluginProcessing = true;
    this(false, true);
  }
@@ -113,24 +119,6 @@
  /**
   * Specifies whether the post-connect plugin terminated the client
   * connection.
   *
   * @param  connectionTerminated  Specifies whether the post-connect
   *                               plugin terminated the client
   *                               connection.
   */
  public void setConnectionTerminated(boolean connectionTerminated)
  {
    assert debugEnter(CLASS_NAME, "setConnectionTerminated",
                      String.valueOf(connectionTerminated));
    this.connectionTerminated = connectionTerminated;
  }
  /**
   * Indicates whether any further post-connect plugins should be
   * invoked for this connection.
   *
@@ -148,25 +136,6 @@
  /**
   * Specifies whether any further post-connect plugins should be
   * invoked for this connection.
   *
   * @param  continuePluginProcessing  Specifies whether any further
   *                                   post-connect plugins should be
   *                                   invoked for this connection.
   */
  public void setContinuePluginProcessing(
                   boolean continuePluginProcessing)
  {
    assert debugEnter(CLASS_NAME, "setContinuePluginProcessing",
                      String.valueOf(continuePluginProcessing));
    this.continuePluginProcessing = continuePluginProcessing;
  }
  /**
   * Retrieves a string representation of this post-connect plugin
   * result.
   *
opends/src/server/org/opends/server/api/plugin/PostDisconnectPluginResult.java
@@ -46,9 +46,18 @@
  /**
   * A post-disconnect plugin result instance that indicates all
   * processing was successful.
   */
  public static final PostDisconnectPluginResult SUCCESS =
       new PostDisconnectPluginResult();
  // Indicates whether any further post-disconnect plugins should be
  // invoked for this connection.
  private boolean continuePluginProcessing;
  private final boolean continuePluginProcessing;
@@ -57,11 +66,9 @@
   * settings.  In this case, it will indicate that the further
   * post-disconnect plugin processing should be allowed.
   */
  public PostDisconnectPluginResult()
  private PostDisconnectPluginResult()
  {
    assert debugConstructor(CLASS_NAME);
    this.continuePluginProcessing = true;
    this(true);
  }
@@ -102,25 +109,6 @@
  /**
   * Specifies whether any further post-disconnect plugins should be
   * invoked for this connection.
   *
   * @param  continuePluginProcessing  Specifies whether any further
   *                                   post-disconnect plugins should
   *                                   be invoked for this connection.
   */
  public void setContinuePluginProcessing(
                   boolean continuePluginProcessing)
  {
    assert debugEnter(CLASS_NAME, "setContinuePluginProcessing",
                      String.valueOf(continuePluginProcessing));
    this.continuePluginProcessing = continuePluginProcessing;
  }
  /**
   * Retrieves a string representation of this post-connect plugin
   * result.
   *
opends/src/server/org/opends/server/api/plugin/PostOperationPluginResult.java
@@ -46,13 +46,22 @@
  /**
   * A post-operation plugin result instance that indicates all
   * processing was  successful.
   */
  public static final PostOperationPluginResult SUCCESS =
       new PostOperationPluginResult();
  // Indicates whether any further post-operation plugins should be
  // invoked for this operation.
  private boolean continuePluginProcessing;
  private final boolean continuePluginProcessing;
  // Indicates whether the post-operation plugin terminated the client
  // connection.
  private boolean connectionTerminated;
  private final boolean connectionTerminated;
@@ -62,12 +71,9 @@
   * not been terminated and that further post-operation plugin
   * processing should be allowed.
   */
  public PostOperationPluginResult()
  private PostOperationPluginResult()
  {
    assert debugConstructor(CLASS_NAME);
    this.connectionTerminated     = false;
    this.continuePluginProcessing = true;
    this(false, true);
  }
@@ -115,24 +121,6 @@
  /**
   * Specifies whether the post-operation plugin terminated the client
   * connection.
   *
   * @param  connectionTerminated  Specifies whether the
   *                               post-operation plugin terminated
   *                               the client connection.
   */
  public void setConnectionTerminated(boolean connectionTerminated)
  {
    assert debugEnter(CLASS_NAME, "setConnectionTerminated",
                      String.valueOf(connectionTerminated));
    this.connectionTerminated = connectionTerminated;
  }
  /**
   * Indicates whether any further post-operation plugins should be
   * invoked for this operation.
   *
@@ -150,25 +138,6 @@
  /**
   * Specifies whether any further post-operation plugins should be
   * invoked for this operation.
   *
   * @param  continuePluginProcessing  Specifies whether any further
   *                                   post-operation plugins should
   *                                   be invoked for this operation.
   */
  public void setContinuePluginProcessing(
                   boolean continuePluginProcessing)
  {
    assert debugEnter(CLASS_NAME, "setContinuePluginProcessing",
                      String.valueOf(continuePluginProcessing));
    this.continuePluginProcessing = continuePluginProcessing;
  }
  /**
   * Retrieves a string representation of this post-connect plugin
   * result.
   *
opends/src/server/org/opends/server/api/plugin/PostResponsePluginResult.java
@@ -46,13 +46,22 @@
  /**
   * A post-response plugin result instance that indicates all
   * processing was successful.
   */
  public static final PostResponsePluginResult SUCCESS =
       new PostResponsePluginResult();
  // Indicates whether any further post-response plugins should be
  // invoked for this operation.
  private boolean continuePluginProcessing;
  private final boolean continuePluginProcessing;
  // Indicates whether the post-response plugin terminated the client
  // connection.
  private boolean connectionTerminated;
  private final boolean connectionTerminated;
@@ -62,12 +71,9 @@
   * not been terminated and that further post-response plugin
   * processing should be allowed.
   */
  public PostResponsePluginResult()
  private PostResponsePluginResult()
  {
    assert debugConstructor(CLASS_NAME);
    this.connectionTerminated     = false;
    this.continuePluginProcessing = true;
    this(false, true);
  }
@@ -114,25 +120,6 @@
  /**
   * Specifies whether any further post-response plugins should be
   * invoked for this operation.
   *
   * @param  continuePluginProcessing  Specifies whether any further
   *                                   post-response plugins should be
   *                                   invoked for this operation.
   */
  public void setContinuePluginProcessing(
                   boolean continuePluginProcessing)
  {
    assert debugEnter(CLASS_NAME, "setContinuePluginProcessing",
                      String.valueOf(continuePluginProcessing));
    this.continuePluginProcessing = continuePluginProcessing;
  }
  /**
   * Indicates whether the post-response plugin terminated the client
   * connection.
   *
@@ -149,24 +136,6 @@
  /**
   * Specifies whether the post-response plugin terminated the client
   * connection.
   *
   * @param  connectionTerminated  Specifies whether the post-response
   *                               plugin terminated the client
   *                               connection.
   */
  public void setConnectionTerminated(boolean connectionTerminated)
  {
    assert debugEnter(CLASS_NAME, "setConnectionTerminated",
                      String.valueOf(connectionTerminated));
    this.connectionTerminated = connectionTerminated;
  }
  /**
   * Retrieves a string representation of this post-response plugin
   * result.
   *
opends/src/server/org/opends/server/api/plugin/PreOperationPluginResult.java
@@ -46,17 +46,26 @@
  /**
   * A pre-operation plugin result instance that indicates all
   * processing was successful.
   */
  public static final PreOperationPluginResult SUCCESS =
       new PreOperationPluginResult();
  // Indicates whether any further pre-operation plugins should be
  // invoked for this operation.
  private boolean continuePluginProcessing;
  private final boolean continuePluginProcessing;
  // Indicates whether the pre-operation plugin terminated the client
  // connection.
  private boolean connectionTerminated;
  private final boolean connectionTerminated;
  // Indicates whether the server should immediately send the response
  // from this plugin to the client with no further processing.
  private boolean sendResponseImmediately;
  private final boolean sendResponseImmediately;
@@ -68,13 +77,9 @@
   * and that the post-operation plugin processing should not be
   * skipped.
   */
  public PreOperationPluginResult()
  private PreOperationPluginResult()
  {
    assert debugConstructor(CLASS_NAME);
    this.connectionTerminated     = false;
    this.continuePluginProcessing = true;
    this.sendResponseImmediately  = false;
    this(false, true, false);
  }
@@ -128,24 +133,6 @@
  /**
   * Specifies whether the post-response plugin terminated the client
   * connection.
   *
   * @param  connectionTerminated  Specifies whether the post-response
   *                               plugin terminated the client
   *                               connection.
   */
  public void setConnectionTerminated(boolean connectionTerminated)
  {
    assert debugEnter(CLASS_NAME, "setConnectionTerminated",
                      String.valueOf(connectionTerminated));
    this.connectionTerminated = connectionTerminated;
  }
  /**
   * Indicates whether any further post-response plugins should be
   * invoked for this operation.
   *
@@ -163,25 +150,6 @@
  /**
   * Specifies whether any further post-response plugins should be
   * invoked for this operation.
   *
   * @param  continuePluginProcessing  Specifies whether any further
   *                                   post-response plugins should be
   *                                   invoked for this operation.
   */
  public void setContinuePluginProcessing(
                   boolean continuePluginProcessing)
  {
    assert debugEnter(CLASS_NAME, "setContinuePluginProcessing",
                      String.valueOf(continuePluginProcessing));
    this.continuePluginProcessing = continuePluginProcessing;
  }
  /**
   * Indicates whether the server should send the response set by this
   * plugin to the client immediately with no further processing on
   * the operation.
@@ -201,28 +169,6 @@
  /**
   * Specifies whether the server should send the response set by this
   * plugin to the client immediately with no further processing on
   * the operation.
   *
   * @param  sendResponseImmediately  Indicates whether the server
   *                                  should send the response set by
   *                                  this plugin to the client
   *                                  immediately with no further
   *                                  processing on the operation.
   */
  public void setSendResponseImmediately(
                   boolean sendResponseImmediately)
  {
    assert debugEnter(CLASS_NAME, "setSendResponseImmediately",
                      String.valueOf(sendResponseImmediately));
    this.sendResponseImmediately = sendResponseImmediately;
  }
  /**
   * Retrieves a string representation of this post-response plugin
   * result.
   *
opends/src/server/org/opends/server/api/plugin/PreParsePluginResult.java
@@ -46,17 +46,26 @@
  /**
   * A pre-parse plugin result instance that indicates all processing
   * was successful.
   */
  public static final PreParsePluginResult SUCCESS =
       new PreParsePluginResult();
  // Indicates whether any further pre-operation plugins should be
  // invoked for this operation.
  private boolean continuePluginProcessing;
  private final boolean continuePluginProcessing;
  // Indicates whether the pre-operation plugin terminated the client
  // connection.
  private boolean connectionTerminated;
  private final boolean connectionTerminated;
  // Indicates whether the server should immediately send the response
  // from this plugin to the client with no further processing.
  private boolean sendResponseImmediately;
  private final boolean sendResponseImmediately;
@@ -68,13 +77,9 @@
   * that the pre-operation and post-operation plugin processing
   * should not be skipped.
   */
  public PreParsePluginResult()
  private PreParsePluginResult()
  {
    assert debugConstructor(CLASS_NAME);
    this.connectionTerminated     = false;
    this.continuePluginProcessing = true;
    this.sendResponseImmediately  = false;
    this(false, true, false);
  }
@@ -128,24 +133,6 @@
  /**
   * Specifies whether the post-response plugin terminated the client
   * connection.
   *
   * @param  connectionTerminated  Specifies whether the post-response
   *                               plugin terminated the client
   *                               connection.
   */
  public void setConnectionTerminated(boolean connectionTerminated)
  {
    assert debugEnter(CLASS_NAME, "setConnectionTerminated",
                      String.valueOf(connectionTerminated));
    this.connectionTerminated = connectionTerminated;
  }
  /**
   * Indicates whether any further post-response plugins should be
   * invoked for this operation.
   *
@@ -163,25 +150,6 @@
  /**
   * Specifies whether any further post-response plugins should be
   * invoked for this operation.
   *
   * @param  continuePluginProcessing  Specifies whether any further
   *                                   post-response plugins should be
   *                                   invoked for this operation.
   */
  public void setContinuePluginProcessing(
                   boolean continuePluginProcessing)
  {
    assert debugEnter(CLASS_NAME, "setContinuePluginProcessing",
                      String.valueOf(continuePluginProcessing));
    this.continuePluginProcessing = continuePluginProcessing;
  }
  /**
   * Indicates whether the server should send the response set by this
   * plugin to the client immediately with no further processing on
   * the operation.
@@ -201,28 +169,6 @@
  /**
   * Specifies whether the server should send the response set by this
   * plugin to the client immediately with no further processing on
   * the operation.
   *
   * @param  sendResponseImmediately  Indicates whether the server
   *                                  should send the response set by
   *                                  this plugin to the client
   *                                  immediately with no further
   *                                  processing on the operation.
   */
  public void setSendResponseImmediately(
                   boolean sendResponseImmediately)
  {
    assert debugEnter(CLASS_NAME, "setSendResponseImmediately",
                      String.valueOf(sendResponseImmediately));
    this.sendResponseImmediately = sendResponseImmediately;
  }
  /**
   * Retrieves a string representation of this post-response plugin
   * result.
   *
opends/src/server/org/opends/server/api/plugin/SearchEntryPluginResult.java
@@ -46,21 +46,30 @@
  /**
   * A search entry plugin result instance that indicates all
   * processing was successful.
   */
  public static final SearchEntryPluginResult SUCCESS =
       new SearchEntryPluginResult();
  // Indicates whether any further search result entry plugins should
  // be invoked for this operation.
  private boolean continuePluginProcessing;
  private final boolean continuePluginProcessing;
  // Indicates whether processing should continue for the associated
  // search operation.
  private boolean continueSearch;
  private final boolean continueSearch;
  // Indicates whether the search result entry plugin terminated the
  // client connection.
  private boolean connectionTerminated;
  private final boolean connectionTerminated;
  // Indicates whether the associated entry should be sent to the
  // client.
  private boolean sendEntry;
  private final boolean sendEntry;
@@ -71,14 +80,9 @@
   * should continue, that the entry should be returned to the client,
   * and that processing on the search operation should continue.
   */
  public SearchEntryPluginResult()
  private SearchEntryPluginResult()
  {
    assert debugConstructor(CLASS_NAME);
    this.connectionTerminated     = false;
    this.continuePluginProcessing = true;
    this.sendEntry                = true;
    this.continueSearch           = true;
    this(false, true, true, true);
  }
@@ -136,24 +140,6 @@
  /**
   * Specifies whether the search result entry plugin terminated the
   * client connection.
   *
   * @param  connectionTerminated  Specifies whether the search result
   *                               entry plugin terminated the client
   *                               connection.
   */
  public void setConnectionTerminated(boolean connectionTerminated)
  {
    assert debugEnter(CLASS_NAME, "setConnectionTerminated",
                      String.valueOf(connectionTerminated));
    this.connectionTerminated = connectionTerminated;
  }
  /**
   * Indicates whether any further search result entry plugins should
   * be invoked for this operation.
   *
@@ -171,26 +157,6 @@
  /**
   * Specifies whether any further search result entry plugins should
   * be invoked for this operation.
   *
   * @param  continuePluginProcessing  Specifies whether any further
   *                                   search result entry plugins
   *                                   should be invoked for this
   *                                   operation.
   */
  public void setContinuePluginProcessing(
                   boolean continuePluginProcessing)
  {
    assert debugEnter(CLASS_NAME, "setContinuePluginProcessing",
                      String.valueOf(continuePluginProcessing));
    this.continuePluginProcessing = continuePluginProcessing;
  }
  /**
   * Indicates whether the associated search result entry should be
   * sent to the client.
   *
@@ -208,23 +174,6 @@
  /**
   * Specifies whether the associated search result entry should be
   * sent to the client.
   *
   * @param  sendEntry  Specifies whether the associated search result
   *                    entry should be sent to the client.
   */
  public void setSendEntry(boolean sendEntry)
  {
    assert debugEnter(CLASS_NAME, "setSendEntry",
                      String.valueOf(sendEntry));
    this.sendEntry = sendEntry;
  }
  /**
   * Indicates whether processing should continue for the associated
   * search operation (i.e., if it should continue looking for more
   * matching entries).
@@ -242,24 +191,6 @@
  /**
   * Specifies whether processing should continue for the associated
   * search operation.
   *
   * @param  continueSearch  Specifies whether processing should
   *                         continue for the associated search
   *                         operation.
   */
  public void setContinueSearch(boolean continueSearch)
  {
    assert debugEnter(CLASS_NAME, "setContinueSearch",
                      String.valueOf(continueSearch));
    this.continueSearch = continueSearch;
  }
  /**
   * Retrieves a string representation of this search result entry
   * plugin result.
   *
opends/src/server/org/opends/server/api/plugin/SearchReferencePluginResult.java
@@ -46,21 +46,30 @@
  /**
   * A search reference plugin result instance that indicates all
   * processing was successful.
   */
  public static final SearchReferencePluginResult SUCCESS =
       new SearchReferencePluginResult();
  // Indicates whether any further search result reference plugins
  // should be invoked for this operation.
  private boolean continuePluginProcessing;
  private final boolean continuePluginProcessing;
  // Indicates whether processing should continue for the associated
  // search operation.
  private boolean continueSearch;
  private final boolean continueSearch;
  // Indicates whether the search result reference plugin terminated
  // the client connection.
  private boolean connectionTerminated;
  private final boolean connectionTerminated;
  // Indicates whether the associated reference should be sent to the
  // client.
  private boolean sendReference;
  private final boolean sendReference;
@@ -72,14 +81,9 @@
   * to the client, and that processing on the search operation should
   * continue.
   */
  public SearchReferencePluginResult()
  private SearchReferencePluginResult()
  {
    assert debugConstructor(CLASS_NAME);
    this.connectionTerminated     = false;
    this.continuePluginProcessing = true;
    this.sendReference            = true;
    this.continueSearch           = true;
    this(false, true, true, true);
  }
@@ -137,24 +141,6 @@
  /**
   * Specifies whether the search result reference plugin terminated
   * the client connection.
   *
   * @param  connectionTerminated  Specifies whether the search result
   *                               reference plugin terminated the
   *                               client connection.
   */
  public void setConnectionTerminated(boolean connectionTerminated)
  {
    assert debugEnter(CLASS_NAME, "setConnectionTerminated",
                      String.valueOf(connectionTerminated));
    this.connectionTerminated = connectionTerminated;
  }
  /**
   * Indicates whether any further search result reference plugins
   * should be invoked for this operation.
   *
@@ -172,26 +158,6 @@
  /**
   * Specifies whether any further search result reference plugins
   * should be invoked for this operation.
   *
   * @param  continuePluginProcessing  Specifies whether any further
   *                                   search result reference plugins
   *                                   should be invoked for this
   *                                   operation.
   */
  public void setContinuePluginProcessing(
                   boolean continuePluginProcessing)
  {
    assert debugEnter(CLASS_NAME, "setContinuePluginProcessing",
                      String.valueOf(continuePluginProcessing));
    this.continuePluginProcessing = continuePluginProcessing;
  }
  /**
   * Indicates whether the associated search result reference should
   * be sent to the client.
   *
@@ -209,24 +175,6 @@
  /**
   * Specifies whether the associated search result reference should
   * be sent to the client.
   *
   * @param  sendReference  Specifies whether the associated search
   *                        result reference should be sent to the
   *                        client.
   */
  public void setSendReference(boolean sendReference)
  {
    assert debugEnter(CLASS_NAME, "setSendReference",
                      String.valueOf(sendReference));
    this.sendReference = sendReference;
  }
  /**
   * Indicates whether processing should continue for the associated
   * search operation (i.e., if it should continue looking for more
   * matching entries).
@@ -244,24 +192,6 @@
  /**
   * Specifies whether processing should continue for the associated
   * search operation.
   *
   * @param  continueSearch  Specifies whether processing should
   *                         continue for the associated search
   *                         operation.
   */
  public void setContinueSearch(boolean continueSearch)
  {
    assert debugEnter(CLASS_NAME, "setContinueSearch",
                      String.valueOf(continueSearch));
    this.continueSearch = continueSearch;
  }
  /**
   * Retrieves a string representation of this search result reference
   * plugin result.
   *
opends/src/server/org/opends/server/api/plugin/StartupPluginResult.java
@@ -47,20 +47,29 @@
  /**
   * A startup plugin result instance that indicates all processing
   * was successful.
   */
  public static final StartupPluginResult SUCCESS =
       new StartupPluginResult();
  // Indicates whether the startup plugin completed successfully.
  private boolean completedSuccessfully;
  private final boolean completedSuccessfully;
  // Indicates whether the server should continue with the startup
  // process.
  private boolean continueStartup;
  private final boolean continueStartup;
  // The unique identifier for any error message generated by the
  // startup plugin.
  private int errorID;
  private final int errorID;
  // A human-readable message that explains any error that might have
  // occurred.
  private String errorMessage;
  private final String errorMessage;
@@ -70,14 +79,9 @@
   * successfully, that the startup process should continue, and that
   * there is no error message.
   */
  public StartupPluginResult()
  private StartupPluginResult()
  {
    assert debugConstructor(CLASS_NAME);
    this.completedSuccessfully = true;
    this.continueStartup       = true;
    this.errorID               = 0;
    this.errorMessage          = null;
    this(true, true, 0, null);
  }
@@ -134,24 +138,6 @@
  /**
   * Specifies whether the startup plugin completed its processing
   * successfully.
   *
   * @param  completedSuccessfully  Specifies whether the startup
   *                                plugin completed its processing
   *                                successfully.
   */
  public void setCompletedSuccessfully(boolean completedSuccessfully)
  {
    assert debugEnter(CLASS_NAME, "setCompletedSuccessfully",
                      String.valueOf(completedSuccessfully));
    this.completedSuccessfully = completedSuccessfully;
  }
  /**
   * Indicates whether the Directory Server should continue with its
   * startup process.
   *
@@ -169,24 +155,6 @@
  /**
   * Specifies whether the Directory Server should continue with its
   * startup process.
   *
   * @param  continueStartup  Specifies whether the Directory Server
   *                          should continue with its startup
   *                          process.
   */
  public void setContinueStartup(boolean continueStartup)
  {
    assert debugEnter(CLASS_NAME, "setContinueStartup",
                      String.valueOf(continueStartup));
    this.continueStartup = continueStartup;
  }
  /**
   * Retrieves the unique ID for the error message generated by the
   * startup plugin.
   *
@@ -203,23 +171,6 @@
  /**
   * Specifies the unique ID for the error message generated by the
   * startup plugin.
   *
   * @param  errorID  The unique ID for the error message generated by
   *                  the startup plugin.
   */
  public void setErrorID(int errorID)
  {
    assert debugEnter(CLASS_NAME, "setErrorID",
                      String.valueOf(errorID));
    this.errorID = errorID;
  }
  /**
   * Retrieves the human-readable error message generated by the
   * startup plugin.
   *
@@ -237,23 +188,6 @@
  /**
   * Specifies the human-readable error message generated by the
   * startup plugin.
   *
   * @param  errorMessage  The human-readable error message generated
   *                       by the startup plugin.
   */
  public void setErrorMessage(String errorMessage)
  {
    assert debugEnter(CLASS_NAME, "setErrorMessage",
                      String.valueOf(errorMessage));
    this.errorMessage = errorMessage;
  }
  /**
   * Retrieves a string representation of this startup plugin result.
   *
   * @return  A string representation of this startup plugin result.
opends/src/server/org/opends/server/core/PluginConfigManager.java
@@ -1682,7 +1682,7 @@
    {
      // This should only happen if there were no startup plugins registered,
      // which is fine.
      result = new StartupPluginResult();
      result = StartupPluginResult.SUCCESS;
    }
    return result;
@@ -1802,7 +1802,7 @@
    {
      // This should only happen if there were no post-connect plugins
      // registered, which is fine.
      result = new PostConnectPluginResult();
      result = PostConnectPluginResult.SUCCESS;
    }
    return result;
@@ -1879,7 +1879,7 @@
    {
      // This should only happen if there were no post-disconnect plugins
      // registered, which is fine.
      result = new PostDisconnectPluginResult();
      result = PostDisconnectPluginResult.SUCCESS;
    }
    return result;
@@ -1945,7 +1945,7 @@
    {
      // This should only happen if there were no LDIF import plugins
      // registered, which is fine.
      result = new LDIFPluginResult();
      result = LDIFPluginResult.SUCCESS;
    }
    return result;
@@ -2011,7 +2011,7 @@
    {
      // This should only happen if there were no LDIF export plugins
      // registered, which is fine.
      result = new LDIFPluginResult();
      result = LDIFPluginResult.SUCCESS;
    }
    return result;
@@ -2093,7 +2093,7 @@
    {
      // This should only happen if there were no pre-parse abandon plugins
      // registered, which is fine.
      result = new PreParsePluginResult();
      result = PreParsePluginResult.SUCCESS;
    }
    return result;
@@ -2173,7 +2173,7 @@
    {
      // This should only happen if there were no pre-parse add plugins
      // registered, which is fine.
      result = new PreParsePluginResult();
      result = PreParsePluginResult.SUCCESS;
    }
    return result;
@@ -2253,7 +2253,7 @@
    {
      // This should only happen if there were no pre-parse bind plugins
      // registered, which is fine.
      result = new PreParsePluginResult();
      result = PreParsePluginResult.SUCCESS;
    }
    return result;
@@ -2335,7 +2335,7 @@
    {
      // This should only happen if there were no pre-parse compare plugins
      // registered, which is fine.
      result = new PreParsePluginResult();
      result = PreParsePluginResult.SUCCESS;
    }
    return result;
@@ -2417,7 +2417,7 @@
    {
      // This should only happen if there were no pre-parse delete plugins
      // registered, which is fine.
      result = new PreParsePluginResult();
      result = PreParsePluginResult.SUCCESS;
    }
    return result;
@@ -2499,7 +2499,7 @@
    {
      // This should only happen if there were no pre-parse extended plugins
      // registered, which is fine.
      result = new PreParsePluginResult();
      result = PreParsePluginResult.SUCCESS;
    }
    return result;
@@ -2581,7 +2581,7 @@
    {
      // This should only happen if there were no pre-parse modify plugins
      // registered, which is fine.
      result = new PreParsePluginResult();
      result = PreParsePluginResult.SUCCESS;
    }
    return result;
@@ -2663,7 +2663,7 @@
    {
      // This should only happen if there were no pre-parse modify DN plugins
      // registered, which is fine.
      result = new PreParsePluginResult();
      result = PreParsePluginResult.SUCCESS;
    }
    return result;
@@ -2745,7 +2745,7 @@
    {
      // This should only happen if there were no pre-parse search plugins
      // registered, which is fine.
      result = new PreParsePluginResult();
      result = PreParsePluginResult.SUCCESS;
    }
    return result;
@@ -2827,7 +2827,7 @@
    {
      // This should only happen if there were no pre-parse unbind plugins
      // registered, which is fine.
      result = new PreParsePluginResult();
      result = PreParsePluginResult.SUCCESS;
    }
    return result;
@@ -2907,7 +2907,7 @@
    {
      // This should only happen if there were no pre-operation add plugins
      // registered, which is fine.
      result = new PreOperationPluginResult();
      result = PreOperationPluginResult.SUCCESS;
    }
    return result;
@@ -2987,7 +2987,7 @@
    {
      // This should only happen if there were no pre-operation bind plugins
      // registered, which is fine.
      result = new PreOperationPluginResult();
      result = PreOperationPluginResult.SUCCESS;
    }
    return result;
@@ -3070,7 +3070,7 @@
    {
      // This should only happen if there were no pre-operation compare plugins
      // registered, which is fine.
      result = new PreOperationPluginResult();
      result = PreOperationPluginResult.SUCCESS;
    }
    return result;
@@ -3152,7 +3152,7 @@
    {
      // This should only happen if there were no pre-operation delete plugins
      // registered, which is fine.
      result = new PreOperationPluginResult();
      result = PreOperationPluginResult.SUCCESS;
    }
    return result;
@@ -3235,7 +3235,7 @@
    {
      // This should only happen if there were no pre-operation extended plugins
      // registered, which is fine.
      result = new PreOperationPluginResult();
      result = PreOperationPluginResult.SUCCESS;
    }
    return result;
@@ -3317,7 +3317,7 @@
    {
      // This should only happen if there were no pre-operation modify plugins
      // registered, which is fine.
      result = new PreOperationPluginResult();
      result = PreOperationPluginResult.SUCCESS;
    }
    return result;
@@ -3400,7 +3400,7 @@
    {
      // This should only happen if there were no pre-operation modify DN
      // plugins registered, which is fine.
      result = new PreOperationPluginResult();
      result = PreOperationPluginResult.SUCCESS;
    }
    return result;
@@ -3483,7 +3483,7 @@
    {
      // This should only happen if there were no pre-operation search plugins
      // registered, which is fine.
      result = new PreOperationPluginResult();
      result = PreOperationPluginResult.SUCCESS;
    }
    return result;
@@ -3566,7 +3566,7 @@
    {
      // This should only happen if there were no post-operation abandon plugins
      // registered, which is fine.
      result = new PostOperationPluginResult();
      result = PostOperationPluginResult.SUCCESS;
    }
    return result;
@@ -3646,7 +3646,7 @@
    {
      // This should only happen if there were no post-operation add plugins
      // registered, which is fine.
      result = new PostOperationPluginResult();
      result = PostOperationPluginResult.SUCCESS;
    }
    return result;
@@ -3726,7 +3726,7 @@
    {
      // This should only happen if there were no post-operation bind plugins
      // registered, which is fine.
      result = new PostOperationPluginResult();
      result = PostOperationPluginResult.SUCCESS;
    }
    return result;
@@ -3809,7 +3809,7 @@
    {
      // This should only happen if there were no post-operation compare plugins
      // registered, which is fine.
      result = new PostOperationPluginResult();
      result = PostOperationPluginResult.SUCCESS;
    }
    return result;
@@ -3892,7 +3892,7 @@
    {
      // This should only happen if there were no post-operation delete plugins
      // registered, which is fine.
      result = new PostOperationPluginResult();
      result = PostOperationPluginResult.SUCCESS;
    }
    return result;
@@ -3975,7 +3975,7 @@
    {
      // This should only happen if there were no post-operation extended
      // plugins registered, which is fine.
      result = new PostOperationPluginResult();
      result = PostOperationPluginResult.SUCCESS;
    }
    return result;
@@ -4058,7 +4058,7 @@
    {
      // This should only happen if there were no post-operation modify plugins
      // registered, which is fine.
      result = new PostOperationPluginResult();
      result = PostOperationPluginResult.SUCCESS;
    }
    return result;
@@ -4141,7 +4141,7 @@
    {
      // This should only happen if there were no post-operation modify DN
      // plugins registered, which is fine.
      result = new PostOperationPluginResult();
      result = PostOperationPluginResult.SUCCESS;
    }
    return result;
@@ -4224,7 +4224,7 @@
    {
      // This should only happen if there were no post-operation search plugins
      // registered, which is fine.
      result = new PostOperationPluginResult();
      result = PostOperationPluginResult.SUCCESS;
    }
    return result;
@@ -4307,7 +4307,7 @@
    {
      // This should only happen if there were no post-operation unbind plugins
      // registered, which is fine.
      result = new PostOperationPluginResult();
      result = PostOperationPluginResult.SUCCESS;
    }
    return result;
@@ -4381,7 +4381,7 @@
    {
      // This should only happen if there were no post-response add plugins
      // registered, which is fine.
      result = new PostResponsePluginResult();
      result = PostResponsePluginResult.SUCCESS;
    }
    return result;
@@ -4455,7 +4455,7 @@
    {
      // This should only happen if there were no post-response bind plugins
      // registered, which is fine.
      result = new PostResponsePluginResult();
      result = PostResponsePluginResult.SUCCESS;
    }
    return result;
@@ -4530,7 +4530,7 @@
    {
      // This should only happen if there were no post-response compare plugins
      // registered, which is fine.
      result = new PostResponsePluginResult();
      result = PostResponsePluginResult.SUCCESS;
    }
    return result;
@@ -4604,7 +4604,7 @@
    {
      // This should only happen if there were no post-response delete plugins
      // registered, which is fine.
      result = new PostResponsePluginResult();
      result = PostResponsePluginResult.SUCCESS;
    }
    return result;
@@ -4679,7 +4679,7 @@
    {
      // This should only happen if there were no post-response extended plugins
      // registered, which is fine.
      result = new PostResponsePluginResult();
      result = PostResponsePluginResult.SUCCESS;
    }
    return result;
@@ -4753,7 +4753,7 @@
    {
      // This should only happen if there were no post-response modify plugins
      // registered, which is fine.
      result = new PostResponsePluginResult();
      result = PostResponsePluginResult.SUCCESS;
    }
    return result;
@@ -4828,7 +4828,7 @@
    {
      // This should only happen if there were no post-response modify DN
      // plugins registered, which is fine.
      result = new PostResponsePluginResult();
      result = PostResponsePluginResult.SUCCESS;
    }
    return result;
@@ -4902,7 +4902,7 @@
    {
      // This should only happen if there were no post-response search plugins
      // registered, which is fine.
      result = new PostResponsePluginResult();
      result = PostResponsePluginResult.SUCCESS;
    }
    return result;
@@ -4975,7 +4975,7 @@
    {
      // This should only happen if there were no search result entry plugins
      // registered, which is fine.
      result = new SearchEntryPluginResult();
      result = SearchEntryPluginResult.SUCCESS;
    }
    return result;
@@ -5049,7 +5049,7 @@
    {
      // This should only happen if there were no search result reference
      // plugins registered, which is fine.
      result = new SearchReferencePluginResult();
      result = SearchReferencePluginResult.SUCCESS;
    }
    return result;
@@ -5120,7 +5120,7 @@
    {
      // This should only happen if there were no intermediate response plugins
      // registered, which is fine.
      result = new IntermediateResponsePluginResult();
      result = IntermediateResponsePluginResult.SUCCESS;
    }
    return result;
opends/src/server/org/opends/server/plugins/EntryUUIDPlugin.java
@@ -172,7 +172,7 @@
    List<Attribute> uuidList = entry.getAttribute(entryUUIDType);
    if (uuidList != null)
    {
      return new LDIFPluginResult();
      return LDIFPluginResult.SUCCESS;
    }
@@ -193,7 +193,7 @@
    // We shouldn't ever need to return a non-success result.
    return new LDIFPluginResult();
    return LDIFPluginResult.SUCCESS;
  }
@@ -217,7 +217,7 @@
    List<Attribute> uuidList = operationalAttributes.get(entryUUIDType);
    if (uuidList != null)
    {
      return new PreOperationPluginResult();
      return PreOperationPluginResult.SUCCESS;
    }
@@ -235,7 +235,7 @@
    // Add the attribute to the entry and return.
    addOperation.setAttribute(entryUUIDType, uuidList);
    return new PreOperationPluginResult();
    return PreOperationPluginResult.SUCCESS;
  }
}
opends/src/server/org/opends/server/plugins/LDAPADListPlugin.java
@@ -187,7 +187,7 @@
    }
    return new PreParsePluginResult();
    return PreParsePluginResult.SUCCESS;
  }
}
opends/src/server/org/opends/server/plugins/LastModPlugin.java
@@ -200,7 +200,7 @@
    // We shouldn't ever need to return a non-success result.
    return new PreOperationPluginResult();
    return PreOperationPluginResult.SUCCESS;
  }
@@ -275,7 +275,7 @@
    // We shouldn't ever need to return a non-success result.
    return new PreOperationPluginResult();
    return PreOperationPluginResult.SUCCESS;
  }
@@ -326,7 +326,7 @@
    // We shouldn't ever need to return a non-success result.
    return new PreOperationPluginResult();
    return PreOperationPluginResult.SUCCESS;
  }
}
opends/src/server/org/opends/server/plugins/PasswordPolicyImportPlugin.java
@@ -339,7 +339,7 @@
    }
    return new LDIFPluginResult();
    return LDIFPluginResult.SUCCESS;
  }
}
opends/src/server/org/opends/server/plugins/profiler/ProfilerPlugin.java
@@ -381,7 +381,7 @@
      profilerThread.start();
    }
    return new StartupPluginResult();
    return StartupPluginResult.SUCCESS;
  }
opends/tests/unit-tests-testng/src/server/org/opends/server/plugins/DelayPreOpPlugin.java
@@ -246,7 +246,7 @@
    if (delayDuration <= 0)
    {
      return new PreOperationPluginResult();
      return PreOperationPluginResult.SUCCESS;
    }
    long stopSleepTime = System.currentTimeMillis() + delayDuration;
opends/tests/unit-tests-testng/src/server/org/opends/server/plugins/DisconnectClientPlugin.java
@@ -165,7 +165,7 @@
    }
    else
    {
      return new PreParsePluginResult();
      return PreParsePluginResult.SUCCESS;
    }
  }
@@ -184,7 +184,7 @@
    }
    else
    {
      return new PreParsePluginResult();
      return PreParsePluginResult.SUCCESS;
    }
  }
@@ -203,7 +203,7 @@
    }
    else
    {
      return new PreParsePluginResult();
      return PreParsePluginResult.SUCCESS;
    }
  }
@@ -223,7 +223,7 @@
    }
    else
    {
      return new PreParsePluginResult();
      return PreParsePluginResult.SUCCESS;
    }
  }
@@ -243,7 +243,7 @@
    }
    else
    {
      return new PreParsePluginResult();
      return PreParsePluginResult.SUCCESS;
    }
  }
@@ -263,7 +263,7 @@
    }
    else
    {
      return new PreParsePluginResult();
      return PreParsePluginResult.SUCCESS;
    }
  }
@@ -283,7 +283,7 @@
    }
    else
    {
      return new PreParsePluginResult();
      return PreParsePluginResult.SUCCESS;
    }
  }
@@ -303,7 +303,7 @@
    }
    else
    {
      return new PreParsePluginResult();
      return PreParsePluginResult.SUCCESS;
    }
  }
@@ -323,7 +323,7 @@
    }
    else
    {
      return new PreParsePluginResult();
      return PreParsePluginResult.SUCCESS;
    }
  }
@@ -343,7 +343,7 @@
    }
    else
    {
      return new PreParsePluginResult();
      return PreParsePluginResult.SUCCESS;
    }
  }
@@ -363,7 +363,7 @@
    }
    else
    {
      return new PreOperationPluginResult();
      return PreOperationPluginResult.SUCCESS;
    }
  }
@@ -383,7 +383,7 @@
    }
    else
    {
      return new PreOperationPluginResult();
      return PreOperationPluginResult.SUCCESS;
    }
  }
@@ -404,7 +404,7 @@
    }
    else
    {
      return new PreOperationPluginResult();
      return PreOperationPluginResult.SUCCESS;
    }
  }
@@ -425,7 +425,7 @@
    }
    else
    {
      return new PreOperationPluginResult();
      return PreOperationPluginResult.SUCCESS;
    }
  }
@@ -446,7 +446,7 @@
    }
    else
    {
      return new PreOperationPluginResult();
      return PreOperationPluginResult.SUCCESS;
    }
  }
@@ -467,7 +467,7 @@
    }
    else
    {
      return new PreOperationPluginResult();
      return PreOperationPluginResult.SUCCESS;
    }
  }
@@ -488,7 +488,7 @@
    }
    else
    {
      return new PreOperationPluginResult();
      return PreOperationPluginResult.SUCCESS;
    }
  }
@@ -509,7 +509,7 @@
    }
    else
    {
      return new PreOperationPluginResult();
      return PreOperationPluginResult.SUCCESS;
    }
  }
@@ -530,7 +530,7 @@
    }
    else
    {
      return new PostOperationPluginResult();
      return PostOperationPluginResult.SUCCESS;
    }
  }
@@ -550,7 +550,7 @@
    }
    else
    {
      return new PostOperationPluginResult();
      return PostOperationPluginResult.SUCCESS;
    }
  }
@@ -570,7 +570,7 @@
    }
    else
    {
      return new PostOperationPluginResult();
      return PostOperationPluginResult.SUCCESS;
    }
  }
@@ -591,7 +591,7 @@
    }
    else
    {
      return new PostOperationPluginResult();
      return PostOperationPluginResult.SUCCESS;
    }
  }
@@ -612,7 +612,7 @@
    }
    else
    {
      return new PostOperationPluginResult();
      return PostOperationPluginResult.SUCCESS;
    }
  }
@@ -633,7 +633,7 @@
    }
    else
    {
      return new PostOperationPluginResult();
      return PostOperationPluginResult.SUCCESS;
    }
  }
@@ -654,7 +654,7 @@
    }
    else
    {
      return new PostOperationPluginResult();
      return PostOperationPluginResult.SUCCESS;
    }
  }
@@ -675,7 +675,7 @@
    }
    else
    {
      return new PostOperationPluginResult();
      return PostOperationPluginResult.SUCCESS;
    }
  }
@@ -696,7 +696,7 @@
    }
    else
    {
      return new PostOperationPluginResult();
      return PostOperationPluginResult.SUCCESS;
    }
  }
@@ -717,7 +717,7 @@
    }
    else
    {
      return new PostOperationPluginResult();
      return PostOperationPluginResult.SUCCESS;
    }
  }
@@ -737,7 +737,7 @@
    }
    else
    {
      return new PostResponsePluginResult();
      return PostResponsePluginResult.SUCCESS;
    }
  }
@@ -757,7 +757,7 @@
    }
    else
    {
      return new PostResponsePluginResult();
      return PostResponsePluginResult.SUCCESS;
    }
  }
@@ -778,7 +778,7 @@
    }
    else
    {
      return new PostResponsePluginResult();
      return PostResponsePluginResult.SUCCESS;
    }
  }
@@ -799,7 +799,7 @@
    }
    else
    {
      return new PostResponsePluginResult();
      return PostResponsePluginResult.SUCCESS;
    }
  }
@@ -820,7 +820,7 @@
    }
    else
    {
      return new PostResponsePluginResult();
      return PostResponsePluginResult.SUCCESS;
    }
  }
@@ -841,7 +841,7 @@
    }
    else
    {
      return new PostResponsePluginResult();
      return PostResponsePluginResult.SUCCESS;
    }
  }
@@ -862,7 +862,7 @@
    }
    else
    {
      return new PostResponsePluginResult();
      return PostResponsePluginResult.SUCCESS;
    }
  }
@@ -883,7 +883,7 @@
    }
    else
    {
      return new PostResponsePluginResult();
      return PostResponsePluginResult.SUCCESS;
    }
  }
opends/tests/unit-tests-testng/src/server/org/opends/server/plugins/InvocationCounterPlugin.java
@@ -133,7 +133,7 @@
       doPreParse(PreParseAbandonOperation abandonOperation)
  {
    preParseCounter.incrementAndGet();
    return new PreParsePluginResult();
    return PreParsePluginResult.SUCCESS;
  }
@@ -145,7 +145,7 @@
  public PreParsePluginResult doPreParse(PreParseAddOperation addOperation)
  {
    preParseCounter.incrementAndGet();
    return new PreParsePluginResult();
    return PreParsePluginResult.SUCCESS;
  }
@@ -157,7 +157,7 @@
  public PreParsePluginResult doPreParse(PreParseBindOperation bindOperation)
  {
    preParseCounter.incrementAndGet();
    return new PreParsePluginResult();
    return PreParsePluginResult.SUCCESS;
  }
@@ -170,7 +170,7 @@
       doPreParse(PreParseCompareOperation compareOperation)
  {
    preParseCounter.incrementAndGet();
    return new PreParsePluginResult();
    return PreParsePluginResult.SUCCESS;
  }
@@ -183,7 +183,7 @@
       doPreParse(PreParseDeleteOperation deleteOperation)
  {
    preParseCounter.incrementAndGet();
    return new PreParsePluginResult();
    return PreParsePluginResult.SUCCESS;
  }
@@ -196,7 +196,7 @@
       doPreParse(PreParseExtendedOperation extendedOperation)
  {
    preParseCounter.incrementAndGet();
    return new PreParsePluginResult();
    return PreParsePluginResult.SUCCESS;
  }
@@ -209,7 +209,7 @@
       doPreParse(PreParseModifyOperation modifyOperation)
  {
    preParseCounter.incrementAndGet();
    return new PreParsePluginResult();
    return PreParsePluginResult.SUCCESS;
  }
@@ -222,7 +222,7 @@
       doPreParse(PreParseModifyDNOperation modifyDNOperation)
  {
    preParseCounter.incrementAndGet();
    return new PreParsePluginResult();
    return PreParsePluginResult.SUCCESS;
  }
@@ -235,7 +235,7 @@
       doPreParse(PreParseSearchOperation searchOperation)
  {
    preParseCounter.incrementAndGet();
    return new PreParsePluginResult();
    return PreParsePluginResult.SUCCESS;
  }
@@ -248,7 +248,7 @@
       doPreParse(PreParseUnbindOperation unbindOperation)
  {
    preParseCounter.incrementAndGet();
    return new PreParsePluginResult();
    return PreParsePluginResult.SUCCESS;
  }
@@ -287,7 +287,7 @@
       doPreOperation(PreOperationAddOperation addOperation)
  {
    preOperationCounter.incrementAndGet();
    return new PreOperationPluginResult();
    return PreOperationPluginResult.SUCCESS;
  }
@@ -300,7 +300,7 @@
       doPreOperation(PreOperationBindOperation bindOperation)
  {
    preOperationCounter.incrementAndGet();
    return new PreOperationPluginResult();
    return PreOperationPluginResult.SUCCESS;
  }
@@ -313,7 +313,7 @@
       doPreOperation(PreOperationCompareOperation compareOperation)
  {
    preOperationCounter.incrementAndGet();
    return new PreOperationPluginResult();
    return PreOperationPluginResult.SUCCESS;
  }
@@ -326,7 +326,7 @@
       doPreOperation(PreOperationDeleteOperation deleteOperation)
  {
    preOperationCounter.incrementAndGet();
    return new PreOperationPluginResult();
    return PreOperationPluginResult.SUCCESS;
  }
@@ -339,7 +339,7 @@
       doPreOperation(PreOperationExtendedOperation extendedOperation)
  {
    preOperationCounter.incrementAndGet();
    return new PreOperationPluginResult();
    return PreOperationPluginResult.SUCCESS;
  }
@@ -352,7 +352,7 @@
       doPreOperation(PreOperationModifyOperation modifyOperation)
  {
    preOperationCounter.incrementAndGet();
    return new PreOperationPluginResult();
    return PreOperationPluginResult.SUCCESS;
  }
@@ -365,7 +365,7 @@
       doPreOperation(PreOperationModifyDNOperation modifyDNOperation)
  {
    preOperationCounter.incrementAndGet();
    return new PreOperationPluginResult();
    return PreOperationPluginResult.SUCCESS;
  }
@@ -378,7 +378,7 @@
       doPreOperation(PreOperationSearchOperation searchOperation)
  {
    preOperationCounter.incrementAndGet();
    return new PreOperationPluginResult();
    return PreOperationPluginResult.SUCCESS;
  }
@@ -417,7 +417,7 @@
       doPostOperation(PostOperationAbandonOperation abandonOperation)
  {
    postOperationCounter.incrementAndGet();
    return new PostOperationPluginResult();
    return PostOperationPluginResult.SUCCESS;
  }
@@ -430,7 +430,7 @@
       doPostOperation(PostOperationAddOperation addOperation)
  {
    postOperationCounter.incrementAndGet();
    return new PostOperationPluginResult();
    return PostOperationPluginResult.SUCCESS;
  }
@@ -443,7 +443,7 @@
       doPostOperation(PostOperationBindOperation bindOperation)
  {
    postOperationCounter.incrementAndGet();
    return new PostOperationPluginResult();
    return PostOperationPluginResult.SUCCESS;
  }
@@ -456,7 +456,7 @@
       doPostOperation(PostOperationCompareOperation compareOperation)
  {
    postOperationCounter.incrementAndGet();
    return new PostOperationPluginResult();
    return PostOperationPluginResult.SUCCESS;
  }
@@ -469,7 +469,7 @@
       doPostOperation(PostOperationDeleteOperation deleteOperation)
  {
    postOperationCounter.incrementAndGet();
    return new PostOperationPluginResult();
    return PostOperationPluginResult.SUCCESS;
  }
@@ -482,7 +482,7 @@
       doPostOperation(PostOperationExtendedOperation extendedOperation)
  {
    postOperationCounter.incrementAndGet();
    return new PostOperationPluginResult();
    return PostOperationPluginResult.SUCCESS;
  }
@@ -495,7 +495,7 @@
       doPostOperation(PostOperationModifyOperation modifyOperation)
  {
    postOperationCounter.incrementAndGet();
    return new PostOperationPluginResult();
    return PostOperationPluginResult.SUCCESS;
  }
@@ -508,7 +508,7 @@
       doPostOperation(PostOperationModifyDNOperation modifyDNOperation)
  {
    postOperationCounter.incrementAndGet();
    return new PostOperationPluginResult();
    return PostOperationPluginResult.SUCCESS;
  }
@@ -521,7 +521,7 @@
       doPostOperation(PostOperationSearchOperation searchOperation)
  {
    postOperationCounter.incrementAndGet();
    return new PostOperationPluginResult();
    return PostOperationPluginResult.SUCCESS;
  }
@@ -534,7 +534,7 @@
       doPostOperation(PostOperationUnbindOperation unbindOperation)
  {
    postOperationCounter.incrementAndGet();
    return new PostOperationPluginResult();
    return PostOperationPluginResult.SUCCESS;
  }
@@ -573,7 +573,7 @@
       doPostResponse(PostResponseAddOperation addOperation)
  {
    postResponseCounter.incrementAndGet();
    return new PostResponsePluginResult();
    return PostResponsePluginResult.SUCCESS;
  }
@@ -586,7 +586,7 @@
       doPostResponse(PostResponseBindOperation bindOperation)
  {
    postResponseCounter.incrementAndGet();
    return new PostResponsePluginResult();
    return PostResponsePluginResult.SUCCESS;
  }
@@ -599,7 +599,7 @@
       doPostResponse(PostResponseCompareOperation compareOperation)
  {
    postResponseCounter.incrementAndGet();
    return new PostResponsePluginResult();
    return PostResponsePluginResult.SUCCESS;
  }
@@ -612,7 +612,7 @@
       doPostResponse(PostResponseDeleteOperation deleteOperation)
  {
    postResponseCounter.incrementAndGet();
    return new PostResponsePluginResult();
    return PostResponsePluginResult.SUCCESS;
  }
@@ -625,7 +625,7 @@
       doPostResponse(PostResponseExtendedOperation extendedOperation)
  {
    postResponseCounter.incrementAndGet();
    return new PostResponsePluginResult();
    return PostResponsePluginResult.SUCCESS;
  }
@@ -638,7 +638,7 @@
       doPostResponse(PostResponseModifyOperation modifyOperation)
  {
    postResponseCounter.incrementAndGet();
    return new PostResponsePluginResult();
    return PostResponsePluginResult.SUCCESS;
  }
@@ -651,7 +651,7 @@
       doPostResponse(PostResponseModifyDNOperation modifyDNOperation)
  {
    postResponseCounter.incrementAndGet();
    return new PostResponsePluginResult();
    return PostResponsePluginResult.SUCCESS;
  }
@@ -664,7 +664,7 @@
       doPostResponse(PostResponseSearchOperation searchOperation)
  {
    postResponseCounter.incrementAndGet();
    return new PostResponsePluginResult();
    return PostResponsePluginResult.SUCCESS;
  }
@@ -704,7 +704,7 @@
                          SearchResultEntry searchEntry)
  {
    searchEntryCounter.incrementAndGet();
    return new SearchEntryPluginResult();
    return SearchEntryPluginResult.SUCCESS;
  }
@@ -745,7 +745,7 @@
                              SearchResultReference searchReference)
  {
    searchReferenceCounter.incrementAndGet();
    return new SearchReferencePluginResult();
    return SearchReferencePluginResult.SUCCESS;
  }
@@ -785,7 +785,7 @@
              IntermediateResponse intermediateResponse)
  {
    intermediateResponseCounter.incrementAndGet();
    return new IntermediateResponsePluginResult();
    return IntermediateResponsePluginResult.SUCCESS;
  }
@@ -825,7 +825,7 @@
                                                    clientConnection)
  {
    postConnectCounter.incrementAndGet();
    return new PostConnectPluginResult();
    return PostConnectPluginResult.SUCCESS;
  }
@@ -865,7 +865,7 @@
       int msgID, String message)
  {
    postDisconnectCounter.incrementAndGet();
    return new PostDisconnectPluginResult();
    return PostDisconnectPluginResult.SUCCESS;
  }
@@ -904,7 +904,7 @@
                                       Entry entry)
  {
    ldifImportCounter.incrementAndGet();
    return new LDIFPluginResult();
    return LDIFPluginResult.SUCCESS;
  }
@@ -943,7 +943,7 @@
                                       Entry entry)
  {
    ldifExportCounter.incrementAndGet();
    return new LDIFPluginResult();
    return LDIFPluginResult.SUCCESS;
  }
@@ -1002,7 +1002,7 @@
  public StartupPluginResult doStartup()
  {
    startupCalled = true;
    return new StartupPluginResult();
    return StartupPluginResult.SUCCESS;
  }
opends/tests/unit-tests-testng/src/server/org/opends/server/plugins/ShortCircuitPlugin.java
@@ -140,7 +140,7 @@
    }
    else
    {
      return new PreParsePluginResult();
      return PreParsePluginResult.SUCCESS;
    }
  }
@@ -162,7 +162,7 @@
    }
    else
    {
      return new PreParsePluginResult();
      return PreParsePluginResult.SUCCESS;
    }
  }
@@ -184,7 +184,7 @@
    }
    else
    {
      return new PreParsePluginResult();
      return PreParsePluginResult.SUCCESS;
    }
  }
@@ -207,7 +207,7 @@
    }
    else
    {
      return new PreParsePluginResult();
      return PreParsePluginResult.SUCCESS;
    }
  }
@@ -230,7 +230,7 @@
    }
    else
    {
      return new PreParsePluginResult();
      return PreParsePluginResult.SUCCESS;
    }
  }
@@ -254,7 +254,7 @@
    }
    else
    {
      return new PreParsePluginResult();
      return PreParsePluginResult.SUCCESS;
    }
  }
@@ -277,7 +277,7 @@
    }
    else
    {
      return new PreParsePluginResult();
      return PreParsePluginResult.SUCCESS;
    }
  }
@@ -301,7 +301,7 @@
    }
    else
    {
      return new PreParsePluginResult();
      return PreParsePluginResult.SUCCESS;
    }
  }
@@ -324,7 +324,7 @@
    }
    else
    {
      return new PreParsePluginResult();
      return PreParsePluginResult.SUCCESS;
    }
  }
@@ -347,7 +347,7 @@
    }
    else
    {
      return new PreParsePluginResult();
      return PreParsePluginResult.SUCCESS;
    }
  }
@@ -370,7 +370,7 @@
    }
    else
    {
      return new PreOperationPluginResult();
      return PreOperationPluginResult.SUCCESS;
    }
  }
@@ -393,7 +393,7 @@
    }
    else
    {
      return new PreOperationPluginResult();
      return PreOperationPluginResult.SUCCESS;
    }
  }
@@ -416,7 +416,7 @@
    }
    else
    {
      return new PreOperationPluginResult();
      return PreOperationPluginResult.SUCCESS;
    }
  }
@@ -439,7 +439,7 @@
    }
    else
    {
      return new PreOperationPluginResult();
      return PreOperationPluginResult.SUCCESS;
    }
  }
@@ -463,7 +463,7 @@
    }
    else
    {
      return new PreOperationPluginResult();
      return PreOperationPluginResult.SUCCESS;
    }
  }
@@ -486,7 +486,7 @@
    }
    else
    {
      return new PreOperationPluginResult();
      return PreOperationPluginResult.SUCCESS;
    }
  }
@@ -510,7 +510,7 @@
    }
    else
    {
      return new PreOperationPluginResult();
      return PreOperationPluginResult.SUCCESS;
    }
  }
@@ -533,7 +533,7 @@
    }
    else
    {
      return new PreOperationPluginResult();
      return PreOperationPluginResult.SUCCESS;
    }
  }
opends/tests/unit-tests-testng/src/server/org/opends/server/plugins/UpdatePreOpPlugin.java
@@ -166,7 +166,7 @@
      addOperation.addObjectClass(oc, oc.getPrimaryName());
    }
    return new PreOperationPluginResult();
    return PreOperationPluginResult.SUCCESS;
  }
@@ -191,7 +191,7 @@
      }
    }
    return new PreOperationPluginResult();
    return PreOperationPluginResult.SUCCESS;
  }