Code cleanup removing potential issues detected by FindBugs

Ludovic Poitou

20.09.2011 ebb48bfdd8278ab712dc837dade5dc74597bd025

Code cleanup removing potential issues detected by FindBugs

 opends/src/server/org/opends/server/extensions/FileBasedKeyManagerProvider.java

@@ -23,6 +23,7 @@
 *
 *
 *      Copyright 2006-2008 Sun Microsystems, Inc.
 *      Portions Copyright 2011 ForgeRock AS
 */
package org.opends.server.extensions;
import org.opends.messages.Message;
@@ -465,7 +466,15 @@
    }
    else if (configuration.getKeyStorePin() != null)
    {
      configuration.getKeyStorePin().toCharArray();
      String pinStr = configuration.getKeyStorePin();
      if (pinStr == null)
      {
        unacceptableReasons.add(
            ERR_FILE_KEYMANAGER_CANNOT_DETERMINE_PIN_FROM_ATTR.get(
              String.valueOf(cfgEntryDN),
              "null"));
        configAcceptable = false;
      }
    }
    else
    {

 opends/src/server/org/opends/server/extensions/PKCS11KeyManagerProvider.java

@@ -23,6 +23,7 @@
 *
 *
 *      Copyright 2006-2008 Sun Microsystems, Inc.
 *      Portions Copyright 2011 ForgeRock AS
 */
package org.opends.server.extensions;
import org.opends.messages.Message;
@@ -379,7 +380,16 @@
    }
    else if (configuration.getKeyStorePin() != null)
    {
      configuration.getKeyStorePin().toCharArray();
      String pinStr = configuration.getKeyStorePin();
      if (pinStr == null)
      {
        // We should have a pin from the configuration, but no.
        unacceptableReasons.add(
            ERR_PKCS11_KEYMANAGER_CANNOT_DETERMINE_PIN_FROM_ATTR.get(
              String.valueOf(cfgEntryDN),
              "null"));
        configAcceptable = false;
      }
    }
    else
    {