mirror of https://github.com/OpenIdentityPlatform/OpenDJ.git

Valera V Harseko
2 days ago f69863189e5a3bb0dd3b9ec0a9ef1a4b602a09ea
Escape commas in __P(basedn) default to fix JMeter plan compile

The benchmark plan failed to compile with "__P called with wrong number of
parameters. Actual: 3. Expected: >= 1 and <= 2": the default value in
${__P(basedn,dc=example,dc=com)} contains commas, which JMeter's function
parser treats as extra argument separators. Escape them as
${__P(basedn,dc=example\,dc=com)} in the ADMIN_CONNECT and BIND samplers.

Without this the tree never compiled, so no statistics.json was produced and
the summary step failed on jq. Verified locally with JMeter 5.6.3: the plan
now compiles and runs, and report generation produces statistics.json.
1 files modified
6 ■■■■ changed files
.github/benchmark/benchmark.jmx 6 ●●●● patch | view | raw | blame | history
.github/benchmark/benchmark.jmx
@@ -47,7 +47,7 @@
          <LDAPExtSampler guiclass="LdapExtTestSamplerGui" testclass="LDAPExtSampler" testname="ADMIN_CONNECT" enabled="true">
            <stringProp name="servername">${__P(host,localhost)}</stringProp>
            <stringProp name="port">${__P(port,1389)}</stringProp>
            <stringProp name="rootdn">ou=People,${__P(basedn,dc=example,dc=com)}</stringProp>
            <stringProp name="rootdn">ou=People,${__P(basedn,dc=example\,dc=com)}</stringProp>
            <stringProp name="scope">2</stringProp>
            <stringProp name="countlimit"></stringProp>
            <stringProp name="timelimit"></stringProp>
@@ -223,7 +223,7 @@
        <LDAPExtSampler guiclass="LdapExtTestSamplerGui" testclass="LDAPExtSampler" testname="BIND" enabled="true">
          <stringProp name="servername">${__P(host,localhost)}</stringProp>
          <stringProp name="port">${__P(port,1389)}</stringProp>
          <stringProp name="rootdn">ou=People,${__P(basedn,dc=example,dc=com)}</stringProp>
          <stringProp name="rootdn">ou=People,${__P(basedn,dc=example\,dc=com)}</stringProp>
          <stringProp name="scope">2</stringProp>
          <stringProp name="countlimit"></stringProp>
          <stringProp name="timelimit"></stringProp>
@@ -233,7 +233,7 @@
          <stringProp name="connection_timeout">60000</stringProp>
          <stringProp name="parseflag">false</stringProp>
          <stringProp name="secure">false</stringProp>
          <stringProp name="user_dn">cn=user_${__threadNum},ou=People,${__P(basedn,dc=example,dc=com)}</stringProp>
          <stringProp name="user_dn">cn=user_${__threadNum},ou=People,${__P(basedn,dc=example\,dc=com)}</stringProp>
          <stringProp name="user_pw">${__P(benchpw,benchPass1)}</stringProp>
          <stringProp name="comparedn"></stringProp>
          <stringProp name="comparefilt"></stringProp>