From b30f406570114a5a7de645fd46fc7b4bc619fb09 Mon Sep 17 00:00:00 2001
From: Jean-Noel Rouvignac <jean-noel.rouvignac@forgerock.com>
Date: Mon, 20 Oct 2014 12:11:48 +0000
Subject: [PATCH] Autorefactored simplifying expressions: - removed useless parentheses - added parentheses to disambiguate expressions - removed useless use of "this" keyword in method calls - removed useless null checks in conjunction with use of instanceof operator

---
 opendj-cli/src/main/java/com/forgerock/opendj/cli/Argument.java |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/opendj-cli/src/main/java/com/forgerock/opendj/cli/Argument.java b/opendj-cli/src/main/java/com/forgerock/opendj/cli/Argument.java
index 7868474..a8e8b4b 100644
--- a/opendj-cli/src/main/java/com/forgerock/opendj/cli/Argument.java
+++ b/opendj-cli/src/main/java/com/forgerock/opendj/cli/Argument.java
@@ -153,12 +153,12 @@
         this.description = description;
         this.isValueSetByProperty = false;
 
-        if ((shortIdentifier == null) && (longIdentifier == null)) {
+        if (shortIdentifier == null && longIdentifier == null) {
             final LocalizableMessage message = ERR_ARG_NO_IDENTIFIER.get(name);
             throw new ArgumentException(message);
         }
 
-        if (needsValue && (valuePlaceholder == null)) {
+        if (needsValue && valuePlaceholder == null) {
             final LocalizableMessage message = ERR_ARG_NO_VALUE_PLACEHOLDER.get(name);
             throw new ArgumentException(message);
         }
@@ -457,7 +457,7 @@
      *         <CODE>false</CODE> if it does not have any values.
      */
     public boolean hasValue() {
-        return (!values.isEmpty());
+        return !values.isEmpty();
     }
 
     /**

--
Gitblit v1.10.0