From 0565fb356eb92ac014ff0e3851f88b0967ffaae1 Mon Sep 17 00:00:00 2001
From: Jean-Noel Rouvignac <jean-noel.rouvignac@forgerock.com>
Date: Thu, 15 Jan 2015 10:49:31 +0000
Subject: [PATCH] Code cleanup.
---
opendj-cli/src/main/java/com/forgerock/opendj/cli/ArgumentGroup.java | 15 +++++++++------
1 files changed, 9 insertions(+), 6 deletions(-)
diff --git a/opendj-cli/src/main/java/com/forgerock/opendj/cli/ArgumentGroup.java b/opendj-cli/src/main/java/com/forgerock/opendj/cli/ArgumentGroup.java
index 3c33bb3..d6f24b5 100644
--- a/opendj-cli/src/main/java/com/forgerock/opendj/cli/ArgumentGroup.java
+++ b/opendj-cli/src/main/java/com/forgerock/opendj/cli/ArgumentGroup.java
@@ -22,7 +22,7 @@
*
*
* Copyright 2008 Sun Microsystems, Inc.
- * Portions copyright 2012-2014 ForgeRock AS.
+ * Portions copyright 2012-2015 ForgeRock AS.
*/
package com.forgerock.opendj.cli;
@@ -41,10 +41,8 @@
/** Description for this group of arguments. */
private LocalizableMessage description;
-
/** List of arguments belonging to this group. */
private List<Argument> args;
-
/** Governs groups position within usage statement. */
private final Integer priority;
@@ -64,6 +62,7 @@
}
/** {@inheritDoc} */
+ @Override
public int compareTo(final ArgumentGroup o) {
// Groups with higher priority numbers appear before
// those with lower priority in the usage output
@@ -78,7 +77,6 @@
* @return boolean where true indicates the add was successful
*/
public boolean addArgument(final Argument arg) {
- boolean success = false;
if (arg != null) {
final Character newShort = arg.getShortIdentifier();
final String newLong = arg.getLongIdentifier();
@@ -94,9 +92,9 @@
}
}
- success = this.args.add(arg);
+ return this.args.add(arg);
}
- return success;
+ return false;
}
/**
@@ -161,4 +159,9 @@
this.description = description;
}
+ /** {@inheritDoc} */
+ @Override
+ public String toString() {
+ return getClass().getSimpleName() + "(description=" + description + ")";
+ }
}
--
Gitblit v1.10.0