From b30f406570114a5a7de645fd46fc7b4bc619fb09 Mon Sep 17 00:00:00 2001
From: Jean-Noel Rouvignac <jean-noel.rouvignac@forgerock.com>
Date: Mon, 20 Oct 2014 12:11:48 +0000
Subject: [PATCH] Autorefactored simplifying expressions: - removed useless parentheses - added parentheses to disambiguate expressions - removed useless use of "this" keyword in method calls - removed useless null checks in conjunction with use of instanceof operator

---
 opendj-config/src/main/java/org/forgerock/opendj/config/AbstractManagedObjectDefinition.java |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/opendj-config/src/main/java/org/forgerock/opendj/config/AbstractManagedObjectDefinition.java b/opendj-config/src/main/java/org/forgerock/opendj/config/AbstractManagedObjectDefinition.java
index 139b6ae..70edbde 100644
--- a/opendj-config/src/main/java/org/forgerock/opendj/config/AbstractManagedObjectDefinition.java
+++ b/opendj-config/src/main/java/org/forgerock/opendj/config/AbstractManagedObjectDefinition.java
@@ -330,7 +330,7 @@
      *             definition was not found.
      */
     public final AbstractManagedObjectDefinition<? extends C, ? extends S> getChild(String name) {
-        if ((name == null) || (name.length() == 0)) {
+        if (name == null || name.length() == 0) {
             throw new IllegalArgumentException("null or empty managed object name");
         }
 
@@ -444,7 +444,7 @@
      *             requested property definition was not found.
      */
     public final PropertyDefinition<?> getPropertyDefinition(String name) {
-        if ((name == null) || (name.length() == 0)) {
+        if (name == null || name.length() == 0) {
             throw new IllegalArgumentException("null or empty property name");
         }
 
@@ -481,7 +481,7 @@
      *             requested relation definition was not found.
      */
     public final RelationDefinition<?, ?> getRelationDefinition(String name) {
-        if ((name == null) || (name.length() == 0)) {
+        if (name == null || name.length() == 0) {
             throw new IllegalArgumentException("null or empty relation name");
         }
 
@@ -533,7 +533,7 @@
      *             found.
      */
     public final AggregationPropertyDefinition<?, ?> getAggregationPropertyDefinition(String name) {
-        if ((name == null) || (name.length() == 0)) {
+        if (name == null || name.length() == 0) {
             throw new IllegalArgumentException("null or empty aggregation property name");
         }
 
@@ -740,7 +740,7 @@
      *         the {@link TopCfgDefn}.
      */
     public final boolean isTop() {
-        return (this instanceof TopCfgDefn);
+        return this instanceof TopCfgDefn;
     }
 
     /**

--
Gitblit v1.10.0