From 77b43a1d03725669362ff6b4740b8650770a2efb Mon Sep 17 00:00:00 2001
From: Matthew Swift <matthew.swift@forgerock.com>
Date: Sat, 25 Jan 2014 01:08:40 +0000
Subject: [PATCH] Fix various Findbugs warnings:
---
opendj-config/src/main/java/org/forgerock/opendj/config/ManagedObjectDefinitionResource.java | 12 +++++++++---
1 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/opendj-config/src/main/java/org/forgerock/opendj/config/ManagedObjectDefinitionResource.java b/opendj-config/src/main/java/org/forgerock/opendj/config/ManagedObjectDefinitionResource.java
index 443fbd1..630336b 100644
--- a/opendj-config/src/main/java/org/forgerock/opendj/config/ManagedObjectDefinitionResource.java
+++ b/opendj-config/src/main/java/org/forgerock/opendj/config/ManagedObjectDefinitionResource.java
@@ -22,10 +22,13 @@
*
*
* Copyright 2008 Sun Microsystems, Inc.
+ * Portions copyright 2014 ForgeRock AS.
*/
package org.forgerock.opendj.config;
+import static org.forgerock.util.Utils.closeSilently;
+
import java.io.BufferedInputStream;
import java.io.IOException;
import java.io.InputStream;
@@ -113,12 +116,15 @@
throw new MissingResourceException("Can't find resource " + path, baseName, "");
}
+ final InputStream is = new BufferedInputStream(stream);
p = new Properties();
try {
- p.load(new BufferedInputStream(stream));
+ p.load(is);
} catch (IOException e) {
- throw new MissingResourceException("Can't load resource " + path + " due to IO exception: "
- + e.getMessage(), baseName, "");
+ throw new MissingResourceException("Can't load resource " + path
+ + " due to IO exception: " + e.getMessage(), baseName, "");
+ } finally {
+ closeSilently(is);
}
// Cache the resource.
--
Gitblit v1.10.0