From 504a43fc479d884085df9895900608dc5b0aca6f Mon Sep 17 00:00:00 2001
From: Valery Kharseko <vharseko@3a-systems.ru>
Date: Fri, 31 Jul 2026 07:52:35 +0000
Subject: [PATCH] Fix CodeQL warning-severity alerts: dead checks, boxed locals and three null dereferences (#793)
---
opendj-config/src/main/java/org/forgerock/opendj/config/dsconfig/BuildVersion.java | 8 +++-----
1 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/opendj-config/src/main/java/org/forgerock/opendj/config/dsconfig/BuildVersion.java b/opendj-config/src/main/java/org/forgerock/opendj/config/dsconfig/BuildVersion.java
index 7f33935..8dcd3e4 100644
--- a/opendj-config/src/main/java/org/forgerock/opendj/config/dsconfig/BuildVersion.java
+++ b/opendj-config/src/main/java/org/forgerock/opendj/config/dsconfig/BuildVersion.java
@@ -13,6 +13,7 @@
*
* Copyright 2008 Sun Microsystems, Inc.
* Portions Copyright 2013-2016 ForgeRock AS.
+ * Portions Copyright 2026 3A Systems, LLC.
*/
package org.forgerock.opendj.config.dsconfig;
@@ -191,11 +192,8 @@
if (major == version.major) {
if (minor == version.minor) {
if (point == version.point) {
- if (rev == version.rev) {
- return 0;
- } else if (rev.compareTo(version.rev) < 0) {
- return -1;
- }
+ // Compares the revisions as strings: they are VCS revisions, not numbers.
+ return Integer.signum(rev.compareTo(version.rev));
} else if (point < version.point) {
return -1;
}
--
Gitblit v1.10.0