From 41d93d231b0c81eff8a0c9b301f9ea9818440727 Mon Sep 17 00:00:00 2001
From: Jean-Noel Rouvignac <jean-noel.rouvignac@forgerock.com>
Date: Mon, 20 Jan 2014 16:32:41 +0000
Subject: [PATCH] Code review: Matthew Swift

---
 opendj-ldap-sdk/src/main/java/org/forgerock/opendj/ldap/ErrorResultException.java |   47 +++++++++++++++++++++++++++++++++++++++++++++++
 1 files changed, 47 insertions(+), 0 deletions(-)

diff --git a/opendj-ldap-sdk/src/main/java/org/forgerock/opendj/ldap/ErrorResultException.java b/opendj-ldap-sdk/src/main/java/org/forgerock/opendj/ldap/ErrorResultException.java
index 45949d3..df73d31 100644
--- a/opendj-ldap-sdk/src/main/java/org/forgerock/opendj/ldap/ErrorResultException.java
+++ b/opendj-ldap-sdk/src/main/java/org/forgerock/opendj/ldap/ErrorResultException.java
@@ -70,6 +70,28 @@
      *             If the provided result code does not represent a failure.
      * @throws NullPointerException
      *             If {@code resultCode} was {@code null}.
+     * @deprecated use {@link #newErrorResult(ResultCode, CharSequence)} instead
+     */
+    @Deprecated
+    public static ErrorResultException newErrorResult(ResultCode resultCode,
+            String diagnosticMessage) {
+        return newErrorResult(resultCode, (CharSequence) diagnosticMessage);
+    }
+
+    /**
+     * Creates a new error result exception with the provided result code and
+     * diagnostic message.
+     *
+     * @param resultCode
+     *            The result code.
+     * @param diagnosticMessage
+     *            The diagnostic message, which may be empty or {@code null}
+     *            indicating that none was provided.
+     * @return The new error result exception.
+     * @throws IllegalArgumentException
+     *             If the provided result code does not represent a failure.
+     * @throws NullPointerException
+     *             If {@code resultCode} was {@code null}.
      */
     public static ErrorResultException newErrorResult(ResultCode resultCode,
             CharSequence diagnosticMessage) {
@@ -112,6 +134,31 @@
      *             If the provided result code does not represent a failure.
      * @throws NullPointerException
      *             If {@code resultCode} was {@code null}.
+     * @deprecated use {@link #newErrorResult(ResultCode, CharSequence, Throwable)} instead
+     */
+    @Deprecated
+    public static ErrorResultException newErrorResult(ResultCode resultCode,
+            String diagnosticMessage, Throwable cause) {
+        return newErrorResult(resultCode, (CharSequence) diagnosticMessage, cause);
+    }
+
+    /**
+     * Creates a new error result exception with the provided result code,
+     * diagnostic message, and cause.
+     *
+     * @param resultCode
+     *            The result code.
+     * @param diagnosticMessage
+     *            The diagnostic message, which may be empty or {@code null}
+     *            indicating that none was provided.
+     * @param cause
+     *            The throwable cause, which may be {@code null} indicating that
+     *            none was provided.
+     * @return The new error result exception.
+     * @throws IllegalArgumentException
+     *             If the provided result code does not represent a failure.
+     * @throws NullPointerException
+     *             If {@code resultCode} was {@code null}.
      */
     public static ErrorResultException newErrorResult(ResultCode resultCode,
             CharSequence diagnosticMessage, Throwable cause) {

--
Gitblit v1.10.0