From 74fe31b8864568224d9461e712d8e34e8eb8ba97 Mon Sep 17 00:00:00 2001
From: Valery Kharseko <vharseko@3a-systems.ru>
Date: Wed, 05 Aug 2026 08:33:01 +0000
Subject: [PATCH] Fix CodeQL note-severity alerts: shadowed locals, and the array cases of the debug formatter (#848)
---
opendj-ldap-toolkit/src/main/java/com/forgerock/opendj/ldap/tools/PerformanceRunner.java | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/opendj-ldap-toolkit/src/main/java/com/forgerock/opendj/ldap/tools/PerformanceRunner.java b/opendj-ldap-toolkit/src/main/java/com/forgerock/opendj/ldap/tools/PerformanceRunner.java
index fde226f..a64cd2b 100644
--- a/opendj-ldap-toolkit/src/main/java/com/forgerock/opendj/ldap/tools/PerformanceRunner.java
+++ b/opendj-ldap-toolkit/src/main/java/com/forgerock/opendj/ldap/tools/PerformanceRunner.java
@@ -129,14 +129,14 @@
@Override
public void run() {
Promise<?, LdapException> promise;
- Connection connection;
+ Connection connectionToUse;
final double targetTimeMs = 1000.0 / (targetThroughput / (double) (numThreads * numConnections));
double sleepTimeMs = 0;
while (!stopRequested && !localStopRequested
&& (maxIterations <= 0 || count < maxIterations)) {
try {
- connection = getConnectionToUse();
+ connectionToUse = getConnectionToUse();
} catch (final InterruptedException e) {
// Ignore and check stop requested
continue;
@@ -146,7 +146,7 @@
}
long startTimeNs = System.nanoTime();
- promise = performOperation(connection, dataSources.get(), startTimeNs);
+ promise = performOperation(connectionToUse, dataSources.get(), startTimeNs);
statsThread.incrementOperationCount();
try {
promise.getOrThrow();
@@ -161,8 +161,8 @@
}
// Ignore. Handled by result handler
} finally {
- if (this.connection == null) {
- connection.close();
+ if (connection == null) {
+ connectionToUse.close();
}
}
--
Gitblit v1.10.0