From 0b7ce981041f545596271bdcd7a2cf2831f066bc Mon Sep 17 00:00:00 2001
From: Jean-Noël Rouvignac <jean-noel.rouvignac@forgerock.com>
Date: Tue, 15 Dec 2015 13:59:12 +0000
Subject: [PATCH] OPENDJ-2311 Option -V/--version don't work for SDK tools

---
 opendj-sdk/opendj-cli/src/main/java/com/forgerock/opendj/cli/ArgumentParser.java |   23 ++++++++++++-----------
 1 files changed, 12 insertions(+), 11 deletions(-)

diff --git a/opendj-sdk/opendj-cli/src/main/java/com/forgerock/opendj/cli/ArgumentParser.java b/opendj-sdk/opendj-cli/src/main/java/com/forgerock/opendj/cli/ArgumentParser.java
index 5264d89..f38e603 100644
--- a/opendj-sdk/opendj-cli/src/main/java/com/forgerock/opendj/cli/ArgumentParser.java
+++ b/opendj-sdk/opendj-cli/src/main/java/com/forgerock/opendj/cli/ArgumentParser.java
@@ -124,7 +124,17 @@
     /** Indicates whether the version argument was provided. */
     private boolean versionPresent;
     /** The handler to call to print the product version. */
-    private VersionHandler versionHandler;
+    private VersionHandler versionHandler = new VersionHandler() {
+        @Override
+        public void printVersion() {
+            // display nothing at all
+        }
+
+        @Override
+        public String toString() {
+            return "<no version displayed>";
+        }
+    };
 
     /** The set of arguments defined for this parser, referenced by short ID. */
     private final HashMap<Character, Argument> shortIDMap = new HashMap<>();
@@ -1068,15 +1078,6 @@
         return LocalizableMessage.raw(getUsage());
     }
 
-    /**
-     * Returns the version handler.
-     *
-     * @return the version handler
-     */
-    VersionHandler getVersionHandler() {
-        return versionHandler;
-    }
-
     /** Prints the version. */
     void printVersion() {
         versionPresent = true;
@@ -1208,7 +1209,7 @@
                         // usage information.
                         writeToUsageOutputStream(getUsage());
                         return;
-                    } else if (versionHandler != null && OPTION_LONG_PRODUCT_VERSION.equals(argName)) {
+                    } else if (OPTION_LONG_PRODUCT_VERSION.equals(argName)) {
                         // "--version" will always be interpreted as requesting version information.
                         printVersion();
                         return;

--
Gitblit v1.10.0