From 41388e8178bd91411face44bba066a5b1e6b34c0 Mon Sep 17 00:00:00 2001
From: jvergara <jvergara@localhost>
Date: Wed, 29 Oct 2008 07:26:36 +0000
Subject: [PATCH] Modify some code to create unmodifiable collections only once in the life cycle of the descriptor objects.

---
 opendj-sdk/opends/src/guitools/org/opends/guitools/controlpanel/datamodel/ServerDescriptor.java |   15 ++++++---------
 1 files changed, 6 insertions(+), 9 deletions(-)

diff --git a/opendj-sdk/opends/src/guitools/org/opends/guitools/controlpanel/datamodel/ServerDescriptor.java b/opendj-sdk/opends/src/guitools/org/opends/guitools/controlpanel/datamodel/ServerDescriptor.java
index 3d70f1e..3beec85 100644
--- a/opendj-sdk/opends/src/guitools/org/opends/guitools/controlpanel/datamodel/ServerDescriptor.java
+++ b/opendj-sdk/opends/src/guitools/org/opends/guitools/controlpanel/datamodel/ServerDescriptor.java
@@ -119,7 +119,7 @@
    */
   public Set<DN> getAdministrativeUsers()
   {
-    return Collections.unmodifiableSet(administrativeUsers);
+    return administrativeUsers;
   }
 
   /**
@@ -128,8 +128,7 @@
    */
   public void setAdministrativeUsers(Set<DN> administrativeUsers)
   {
-    this.administrativeUsers.clear();
-    this.administrativeUsers.addAll(administrativeUsers);
+    this.administrativeUsers = Collections.unmodifiableSet(administrativeUsers);
   }
 
   /**
@@ -377,7 +376,7 @@
    */
   public Set<BackendDescriptor> getBackends()
   {
-    return Collections.unmodifiableSet(backends);
+    return backends;
   }
 
   /**
@@ -386,8 +385,7 @@
    */
   public void setBackends(Set<BackendDescriptor> backends)
   {
-    this.backends.clear();
-    this.backends.addAll(backends);
+    this.backends = Collections.unmodifiableSet(backends);
   }
 
   /**
@@ -396,7 +394,7 @@
    */
   public Set<ConnectionHandlerDescriptor> getConnectionHandlers()
   {
-    return Collections.unmodifiableSet(listeners);
+    return listeners;
   }
 
   /**
@@ -405,8 +403,7 @@
    */
   public void setConnectionHandlers(Set<ConnectionHandlerDescriptor> listeners)
   {
-    this.listeners.clear();
-    this.listeners.addAll(listeners);
+    this.listeners = Collections.unmodifiableSet(listeners);
   }
 
   /**

--
Gitblit v1.10.0