From c449eff8b274a0224dd38e6dd6a23bb698d5bde3 Mon Sep 17 00:00:00 2001
From: Ludovic Poitou <ludovic.poitou@forgerock.com>
Date: Fri, 23 Dec 2011 10:08:41 +0000
Subject: [PATCH] Fix minor optimization proposed by FindBugs.
---
opendj-sdk/opends/src/quicksetup/org/opends/quicksetup/BuildInformation.java | 7 ++++++-
1 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/opendj-sdk/opends/src/quicksetup/org/opends/quicksetup/BuildInformation.java b/opendj-sdk/opends/src/quicksetup/org/opends/quicksetup/BuildInformation.java
index 06539c0..8dbad79 100644
--- a/opendj-sdk/opends/src/quicksetup/org/opends/quicksetup/BuildInformation.java
+++ b/opendj-sdk/opends/src/quicksetup/org/opends/quicksetup/BuildInformation.java
@@ -94,6 +94,7 @@
// return to continue.
Thread t = new Thread(new Runnable()
{
+ @Override
public void run()
{
while (!done[0])
@@ -352,7 +353,7 @@
* @return String representing the SVN URL repository
*/
public String getURLRepository() {
- return new String(values.get(URL_REPOSITORY));
+ return values.get(URL_REPOSITORY);
}
/**
@@ -401,6 +402,7 @@
/**
* {@inheritDoc}
*/
+ @Override
public String toString() {
StringBuilder sb = new StringBuilder();
sb.append(getName());
@@ -418,6 +420,7 @@
/**
* {@inheritDoc}
*/
+ @Override
public int compareTo(BuildInformation bi) {
if (getMajorVersion().equals(bi.getMajorVersion())) {
if (getMinorVersion().equals(bi.getMinorVersion())) {
@@ -442,6 +445,7 @@
/**
* {@inheritDoc}
*/
+ @Override
public boolean equals(Object o) {
return this == o ||
!(o == null || getClass() != o.getClass()) &&
@@ -451,6 +455,7 @@
/**
* {@inheritDoc}
*/
+ @Override
public int hashCode() {
int hc = 11;
hc = 31 * hc + getMajorVersion().hashCode();
--
Gitblit v1.10.0