From 43660e6fed07584f1a4b5df863382bf9670e8b1d Mon Sep 17 00:00:00 2001
From: Jean-Noel Rouvignac <jean-noel.rouvignac@forgerock.com>
Date: Fri, 26 Jul 2013 10:24:14 +0000
Subject: [PATCH] Comments to javadocs. Extracted method haveSimilarRights() from isApplicable(). Used interfaces instead of concrete classes.
---
opendj-sdk/opends/src/server/org/opends/server/authorization/dseecompat/TargetControl.java | 24 +++++++++++-------------
1 files changed, 11 insertions(+), 13 deletions(-)
diff --git a/opendj-sdk/opends/src/server/org/opends/server/authorization/dseecompat/TargetControl.java b/opendj-sdk/opends/src/server/org/opends/server/authorization/dseecompat/TargetControl.java
index 3dab9b7..3c69c27 100644
--- a/opendj-sdk/opends/src/server/org/opends/server/authorization/dseecompat/TargetControl.java
+++ b/opendj-sdk/opends/src/server/org/opends/server/authorization/dseecompat/TargetControl.java
@@ -23,29 +23,28 @@
*
*
* Copyright 2008 Sun Microsystems, Inc.
+ * Portions Copyright 2013 ForgeRock AS
*/
-
-
package org.opends.server.authorization.dseecompat;
import static org.opends.messages.AccessControlMessages.*;
+
import java.util.HashSet;
+import java.util.Set;
/**
* This class represents an ACI's targetcontrol keyword.
*/
-
public class TargetControl {
- /*
+ /**
* HashSet of OID strings parsed from the decode.
*/
- private HashSet<String> controlOIDS = new HashSet<String>();
+ private Set<String> controlOIDS = new HashSet<String>();
- /*
- * Enumeration representing the targetcontrol operator.
- */
-
+ /**
+ * Enumeration representing the targetcontrol operator.
+ */
private EnumTargetOperator op = EnumTargetOperator.EQUALITY;
/**
@@ -55,7 +54,8 @@
* @param controlOIDS Set of control OIDS to use in the evaluation (may
* contain wild-card '*').
*/
- private TargetControl(EnumTargetOperator op, HashSet<String> controlOIDS) {
+ private TargetControl(EnumTargetOperator op, Set<String> controlOIDS)
+ {
this.controlOIDS=controlOIDS;
this.op=op;
}
@@ -72,8 +72,7 @@
*/
public static TargetControl decode(EnumTargetOperator operator, String expr)
throws AciException {
- HashSet<String> controlOIDs =
- Aci.decodeOID(expr,
+ Set<String> controlOIDs = Aci.decodeOID(expr,
WARN_ACI_SYNTAX_INVALID_TARGETCONTROL_EXPRESSION.get(expr));
return new TargetControl(operator, controlOIDs);
}
@@ -99,4 +98,3 @@
return ret;
}
}
-
--
Gitblit v1.10.0