From 978b35311ac944b6846096f921a6257f7d9ee707 Mon Sep 17 00:00:00 2001
From: Jean-Noel Rouvignac <jean-noel.rouvignac@forgerock.com>
Date: Fri, 19 Apr 2013 07:24:20 +0000
Subject: [PATCH] SearchOperationBasis.java, InternalSearchOperation.java, AddRequestProtocolOp.java, ModifyRequestProtocolOp.java, SearchRequestProtocolOp.java: Replaced the use of collections' concrete classes by interfaces in the method signatures.
---
opendj-sdk/opends/src/server/org/opends/server/protocols/ldap/ModifyRequestProtocolOp.java | 27 ++++++++++++++++-----------
1 files changed, 16 insertions(+), 11 deletions(-)
diff --git a/opendj-sdk/opends/src/server/org/opends/server/protocols/ldap/ModifyRequestProtocolOp.java b/opendj-sdk/opends/src/server/org/opends/server/protocols/ldap/ModifyRequestProtocolOp.java
index e9b1ea9..01fcba1 100644
--- a/opendj-sdk/opends/src/server/org/opends/server/protocols/ldap/ModifyRequestProtocolOp.java
+++ b/opendj-sdk/opends/src/server/org/opends/server/protocols/ldap/ModifyRequestProtocolOp.java
@@ -23,24 +23,24 @@
*
*
* Copyright 2006-2008 Sun Microsystems, Inc.
+ * Portions Copyright 2013 ForgeRock AS
*/
package org.opends.server.protocols.ldap;
-
+import java.io.IOException;
import java.util.ArrayList;
import java.util.Iterator;
-import java.io.IOException;
+import java.util.List;
-import org.opends.server.protocols.asn1.*;
-import org.opends.server.types.RawModification;
+import org.opends.server.loggers.debug.DebugTracer;
+import org.opends.server.protocols.asn1.ASN1Writer;
import org.opends.server.types.ByteString;
+import org.opends.server.types.RawModification;
import static org.opends.server.loggers.debug.DebugLogger.*;
-import org.opends.server.loggers.debug.DebugTracer;
import static org.opends.server.protocols.ldap.LDAPConstants.*;
import static org.opends.server.util.ServerConstants.*;
-
/**
* This class defines the structures and methods for an LDAP modify request
* protocol op, which is used to alter the contents of an entry in the Directory
@@ -54,10 +54,10 @@
*/
private static final DebugTracer TRACER = getTracer();
- // The set of modifications for this modify request.
- private ArrayList<RawModification> modifications;
+ /** The set of modifications for this modify request. */
+ private List<RawModification> modifications;
- // The DN for this modify request.
+ /** The DN for this modify request. */
private ByteString dn;
@@ -84,7 +84,7 @@
* @param modifications The set of modifications for this modify request.
*/
public ModifyRequestProtocolOp(ByteString dn,
- ArrayList<RawModification> modifications)
+ List<RawModification> modifications)
{
this.dn = dn;
@@ -118,7 +118,7 @@
*
* @return The set of modifications for this modify request.
*/
- public ArrayList<RawModification> getModifications()
+ public List<RawModification> getModifications()
{
return modifications;
}
@@ -130,6 +130,7 @@
*
* @return The BER type for this protocol op.
*/
+ @Override
public byte getType()
{
return OP_TYPE_MODIFY_REQUEST;
@@ -142,6 +143,7 @@
*
* @return The name for this protocol op type.
*/
+ @Override
public String getProtocolOpName()
{
return "Modify Request";
@@ -153,6 +155,7 @@
* @param stream The ASN.1 output stream to write to.
* @throws IOException If a problem occurs while writing to the stream.
*/
+ @Override
public void write(ASN1Writer stream) throws IOException
{
stream.writeStartSequence(OP_TYPE_MODIFY_REQUEST);
@@ -176,6 +179,7 @@
*
* @param buffer The buffer to which the string should be appended.
*/
+ @Override
public void toString(StringBuilder buffer)
{
buffer.append("ModifyRequest(dn=");
@@ -207,6 +211,7 @@
* @param indent The number of spaces from the margin that the lines should
* be indented.
*/
+ @Override
public void toString(StringBuilder buffer, int indent)
{
StringBuilder indentBuf = new StringBuilder(indent);
--
Gitblit v1.10.0