From a85ac03de14ecb36a2a18558b47ef7d31462c073 Mon Sep 17 00:00:00 2001
From: Jean-Noel Rouvignac <jean-noel.rouvignac@forgerock.com>
Date: Tue, 07 Jul 2015 12:48:58 +0000
Subject: [PATCH] Code cleanups
---
opendj-server-legacy/src/main/java/org/opends/admin/ads/TopologyCache.java | 63 ++++++++++++++++++-------------
1 files changed, 36 insertions(+), 27 deletions(-)
diff --git a/opendj-server-legacy/src/main/java/org/opends/admin/ads/TopologyCache.java b/opendj-server-legacy/src/main/java/org/opends/admin/ads/TopologyCache.java
index 9404279..1d3c504 100644
--- a/opendj-server-legacy/src/main/java/org/opends/admin/ads/TopologyCache.java
+++ b/opendj-server-legacy/src/main/java/org/opends/admin/ads/TopologyCache.java
@@ -518,33 +518,8 @@
&& replica.getReplicationId() == replicaId)
{
// This statistic is optional.
- String s = ConnectionUtils.getFirstValue(sr,
- "approx-older-change-not-synchronized-millis");
- if (s != null)
- {
- try
- {
- replica.setAgeOfOldestMissingChange(Long.valueOf(s));
- }
- catch (Throwable t)
- {
- logger.warn(LocalizableMessage.raw(
- "Unexpected error reading age of oldest change: " + t, t));
- }
- }
- s = ConnectionUtils.getFirstValue(sr, "missing-changes");
- if (s != null)
- {
- try
- {
- replica.setMissingChanges(Integer.valueOf(s));
- }
- catch (Throwable t)
- {
- logger.warn(LocalizableMessage.raw(
- "Unexpected error reading missing changes: " + t, t));
- }
- }
+ setAgeOfOldestMissingChange(replica, sr);
+ setMissingChanges(replica, sr);
updatedReplicas.add(replica);
}
}
@@ -573,4 +548,38 @@
}
}
}
+
+ private void setMissingChanges(ReplicaDescriptor replica, SearchResult sr) throws NamingException
+ {
+ String s = ConnectionUtils.getFirstValue(sr, "missing-changes");
+ if (s != null)
+ {
+ try
+ {
+ replica.setMissingChanges(Integer.valueOf(s));
+ }
+ catch (Throwable t)
+ {
+ logger.warn(LocalizableMessage.raw(
+ "Unexpected error reading missing changes: " + t, t));
+ }
+ }
+ }
+
+ private void setAgeOfOldestMissingChange(ReplicaDescriptor replica, SearchResult sr) throws NamingException
+ {
+ String s = ConnectionUtils.getFirstValue(sr, "approx-older-change-not-synchronized-millis");
+ if (s != null)
+ {
+ try
+ {
+ replica.setAgeOfOldestMissingChange(Long.valueOf(s));
+ }
+ catch (Throwable t)
+ {
+ logger.warn(LocalizableMessage.raw(
+ "Unexpected error reading age of oldest change: " + t, t));
+ }
+ }
+ }
}
--
Gitblit v1.10.0