From 83f86f11c27378d650c3bfc7e55397687062edbc Mon Sep 17 00:00:00 2001
From: Jean-Noël Rouvignac <jean-noel.rouvignac@forgerock.com>
Date: Fri, 22 Apr 2016 14:23:28 +0000
Subject: [PATCH] Improvements suggested by UCDetector: remove dead code, add final keywords, change visibilities
---
opendj-server-legacy/src/main/java/org/opends/admin/ads/TopologyCacheException.java | 50 ++++++++++++++++++--------------------------------
1 files changed, 18 insertions(+), 32 deletions(-)
diff --git a/opendj-server-legacy/src/main/java/org/opends/admin/ads/TopologyCacheException.java b/opendj-server-legacy/src/main/java/org/opends/admin/ads/TopologyCacheException.java
index c796ab4..8a3d7ee 100644
--- a/opendj-server-legacy/src/main/java/org/opends/admin/ads/TopologyCacheException.java
+++ b/opendj-server-legacy/src/main/java/org/opends/admin/ads/TopologyCacheException.java
@@ -12,15 +12,14 @@
* information: "Portions Copyright [year] [name of copyright owner]".
*
* Copyright 2008 Sun Microsystems, Inc.
- * Portions Copyright 2013-2015 ForgeRock AS.
+ * Portions Copyright 2013-2016 ForgeRock AS.
*/
-
package org.opends.admin.ads;
-import org.opends.server.types.OpenDsException;
import javax.naming.NamingException;
import org.opends.admin.ads.util.ApplicationTrustManager;
+import org.opends.server.types.OpenDsException;
/**
* This class represents the Exception that can occur while reading server
@@ -29,43 +28,26 @@
public class TopologyCacheException extends OpenDsException {
private static final long serialVersionUID = 1709535837273360382L;
- private Type type;
- private String ldapUrl;
- private ApplicationTrustManager trustManager;
+ private final Type type;
+ private final String ldapUrl;
+ private final ApplicationTrustManager trustManager;
- /**
- * Error type.
- */
+ /** Error type. */
public enum Type
{
- /**
- * Error reading the ADS.
- */
+ /** Error reading the ADS. */
GENERIC_READING_ADS,
- /**
- * Creating connection to a particular server.
- */
+ /** Creating connection to a particular server. */
GENERIC_CREATING_CONNECTION,
- /**
- * Error reading the configuration of a particular server.
- */
+ /** Error reading the configuration of a particular server. */
GENERIC_READING_SERVER,
- /**
- * The DN provided in the DirContext of ADS is not of a global
- * administrator.
- */
+ /** The DN provided in the DirContext of ADS is not of a global administrator. */
NOT_GLOBAL_ADMINISTRATOR,
- /**
- * Not enough permissions to read the server configuration.
- */
+ /** Not enough permissions to read the server configuration. */
NO_PERMISSIONS,
- /**
- * Timeout reading the configuration of a particular server.
- */
+ /** Timeout reading the configuration of a particular server. */
TIMEOUT,
- /**
- * Unexpected error.
- */
+ /** Unexpected error. */
BUG
}
@@ -74,10 +56,12 @@
* ADSContextException occurs.
* @param ace the exception which is the cause of this exception.
*/
- public TopologyCacheException(ADSContextException ace)
+ TopologyCacheException(ADSContextException ace)
{
super(ace);
type = Type.GENERIC_READING_ADS;
+ ldapUrl = null;
+ trustManager = null;
}
/**
@@ -89,6 +73,8 @@
{
super(t);
this.type = type;
+ this.ldapUrl = null;
+ this.trustManager = null;
}
/**
--
Gitblit v1.10.0