From 0cf88d8e7998442eb6a0c91f8a3c0e9646b5c1a0 Mon Sep 17 00:00:00 2001
From: Valery Kharseko <vharseko@3a-systems.ru>
Date: Wed, 29 Jul 2026 14:20:11 +0000
Subject: [PATCH] Remove containers whose contents are never read (java/unused-container CodeQL alerts) (#784)
---
opendj-server-legacy/src/main/java/org/opends/guitools/controlpanel/browser/NodeSearcherQueue.java | 9 ++-------
1 files changed, 2 insertions(+), 7 deletions(-)
diff --git a/opendj-server-legacy/src/main/java/org/opends/guitools/controlpanel/browser/NodeSearcherQueue.java b/opendj-server-legacy/src/main/java/org/opends/guitools/controlpanel/browser/NodeSearcherQueue.java
index 8910c43..5c4deaf 100644
--- a/opendj-server-legacy/src/main/java/org/opends/guitools/controlpanel/browser/NodeSearcherQueue.java
+++ b/opendj-server-legacy/src/main/java/org/opends/guitools/controlpanel/browser/NodeSearcherQueue.java
@@ -13,6 +13,7 @@
*
* Copyright 2008-2010 Sun Microsystems, Inc.
* Portions Copyright 2015-2016 ForgeRock AS.
+ * Portions Copyright 2026 3A Systems, LLC.
*/
package org.opends.guitools.controlpanel.browser;
@@ -37,7 +38,6 @@
private final String name;
private final List<AbstractNodeTask> waitingQueue = new ArrayList<>();
private final Map<BasicNode, AbstractNodeTask> workingList = new HashMap<>();
- private final Map<BasicNode, BasicNode> cancelList = new HashMap<>();
private final ThreadGroup threadGroup;
@@ -111,7 +111,6 @@
// Mark the on-going task as cancelled
AbstractNodeTask task = workingList.get(node);
if (task != null) {
- cancelList.put(node, node);
task.cancel();
}
notify();
@@ -134,10 +133,7 @@
waitingQueue.clear();
for (Map.Entry<BasicNode, AbstractNodeTask> entry : workingList.entrySet())
{
- BasicNode node = entry.getKey();
- AbstractNodeTask task = entry.getValue();
- cancelList.put(node, node);
- task.cancel();
+ entry.getValue().cancel();
}
}
@@ -201,7 +197,6 @@
throw new IllegalArgumentException("null argument");
}
workingList.remove(task.getNode());
- cancelList.remove(task.getNode());
notify();
// System.out.println("Flushed " + task + " from " + _name);
}
--
Gitblit v1.10.0