From b8f523c95f4fd5fc705f2c6c2a2d98217b9da450 Mon Sep 17 00:00:00 2001
From: Jean-Noel Rouvignac <jean-noel.rouvignac@forgerock.com>
Date: Tue, 21 Apr 2015 20:10:37 +0000
Subject: [PATCH] Converted use of Collection.size() to Collection.isEmpty().

---
 opendj-server-legacy/src/main/java/org/opends/guitools/controlpanel/task/IndexTask.java |   37 ++++++++++++++++++-------------------
 1 files changed, 18 insertions(+), 19 deletions(-)

diff --git a/opendj-server-legacy/src/main/java/org/opends/guitools/controlpanel/task/IndexTask.java b/opendj-server-legacy/src/main/java/org/opends/guitools/controlpanel/task/IndexTask.java
index acdc20a..e07b8bf 100644
--- a/opendj-server-legacy/src/main/java/org/opends/guitools/controlpanel/task/IndexTask.java
+++ b/opendj-server-legacy/src/main/java/org/opends/guitools/controlpanel/task/IndexTask.java
@@ -85,13 +85,10 @@
     initializeBackendSet();
   }
 
-  /**
-   * Initialize the list of backends that are affected by this task.
-   *
-   */
+  /** Initialize the list of backends that are affected by this task. */
   private void initializeBackendSet()
   {
-    backendSet = new TreeSet<String>();
+    backendSet = new TreeSet<>();
     DN theDN = null;
     for (String baseDN : baseDNs)
     {
@@ -101,26 +98,28 @@
       }
       catch (Throwable t)
       {
-        throw new IllegalArgumentException("Could not decode dn "+
-            baseDN, t);
+        throw new IllegalArgumentException("Could not decode dn " + baseDN, t);
       }
-      for (BackendDescriptor backend :
-        getInfo().getServerDescriptor().getBackends())
+      BackendDescriptor backend = findBackendByID(theDN);
+      if (backend != null) {
+        backendSet.add(backend.getBackendID());
+      }
+    }
+  }
+
+  private BackendDescriptor findBackendByID(DN dn)
+  {
+    for (BackendDescriptor backend : getInfo().getServerDescriptor().getBackends())
+    {
+      for (BaseDNDescriptor b : backend.getBaseDns())
       {
-        for (BaseDNDescriptor b : backend.getBaseDns())
+        if (b.getDn().equals(dn))
         {
-          if (b.getDn().equals(theDN))
-          {
-            backendSet.add(backend.getBackendID());
-            break;
-          }
-        }
-        if (backendSet.size() > 0)
-        {
-          break;
+          return backend;
         }
       }
     }
+    return null;
   }
 
   /** {@inheritDoc} */

--
Gitblit v1.10.0