From 83f86f11c27378d650c3bfc7e55397687062edbc Mon Sep 17 00:00:00 2001
From: Jean-Noël Rouvignac <jean-noel.rouvignac@forgerock.com>
Date: Fri, 22 Apr 2016 14:23:28 +0000
Subject: [PATCH] Improvements suggested by UCDetector: remove dead code, add final keywords, change visibilities
---
opendj-server-legacy/src/main/java/org/opends/guitools/controlpanel/task/StartStopTask.java | 24 +++++++-----------------
1 files changed, 7 insertions(+), 17 deletions(-)
diff --git a/opendj-server-legacy/src/main/java/org/opends/guitools/controlpanel/task/StartStopTask.java b/opendj-server-legacy/src/main/java/org/opends/guitools/controlpanel/task/StartStopTask.java
index 787f158..f0c71d4 100644
--- a/opendj-server-legacy/src/main/java/org/opends/guitools/controlpanel/task/StartStopTask.java
+++ b/opendj-server-legacy/src/main/java/org/opends/guitools/controlpanel/task/StartStopTask.java
@@ -19,17 +19,18 @@
import java.util.ArrayList;
import java.util.Collection;
import java.util.HashSet;
+import java.util.List;
import java.util.Set;
+import org.forgerock.i18n.LocalizableMessage;
import org.opends.guitools.controlpanel.datamodel.BackendDescriptor;
import org.opends.guitools.controlpanel.datamodel.ControlPanelInfo;
import org.opends.guitools.controlpanel.ui.ProgressDialog;
-import org.forgerock.i18n.LocalizableMessage;
/** An abstract class used to re-factor some code between the start, stop and restart tasks. */
-public abstract class StartStopTask extends Task
+abstract class StartStopTask extends Task
{
- Set<String> backendSet;
+ private final Set<String> backendSet;
/**
* Constructor of the task.
@@ -46,7 +47,6 @@
{
backendSet.add(backend.getBackendID());
}
-
}
@Override
@@ -80,11 +80,8 @@
getInfo().stopPooling();
getInfo().regenerateDescriptor();
- ArrayList<String> arguments = getCommandLineArguments();
-
- String[] args = new String[arguments.size()];
-
- arguments.toArray(args);
+ List<String> arguments = getCommandLineArguments();
+ String[] args = arguments.toArray(new String[arguments.size()]);
returnCode = executeCommandLine(getCommandLinePath(), args);
postCommandLine();
@@ -109,13 +106,6 @@
*/
protected void postCommandLine()
{
- if (returnCode != 0)
- {
- state = State.FINISHED_WITH_ERROR;
- }
- else
- {
- state = State.FINISHED_SUCCESSFULLY;
- }
+ state = returnCode != 0 ? State.FINISHED_WITH_ERROR : State.FINISHED_SUCCESSFULLY;
}
}
--
Gitblit v1.10.0