From b8c6b80da1cb6118167a934daa480eb381c59e0e Mon Sep 17 00:00:00 2001
From: Jean-Noel Rouvignac <jean-noel.rouvignac@forgerock.com>
Date: Wed, 08 Jul 2015 08:06:00 +0000
Subject: [PATCH] opendj-server-legacy maven module: Enabled "NeedBraces" checkstyle rule. This brings opendj-server-legacy's checkstyle rules closer to ForgeRock's checkstyle rules.

---
 opendj-server-legacy/src/main/java/org/opends/guitools/controlpanel/ui/CustomAttributePanel.java |   19 ++++++++++---------
 1 files changed, 10 insertions(+), 9 deletions(-)

diff --git a/opendj-server-legacy/src/main/java/org/opends/guitools/controlpanel/ui/CustomAttributePanel.java b/opendj-server-legacy/src/main/java/org/opends/guitools/controlpanel/ui/CustomAttributePanel.java
index d560c53..1bdcf91 100644
--- a/opendj-server-legacy/src/main/java/org/opends/guitools/controlpanel/ui/CustomAttributePanel.java
+++ b/opendj-server-legacy/src/main/java/org/opends/guitools/controlpanel/ui/CustomAttributePanel.java
@@ -1068,25 +1068,26 @@
 
   private void checkEnableSaveChanges()
   {
-    if (ignoreChangeEvents) return;
-    boolean changed;
+    if (!ignoreChangeEvents)
+    {
+      saveChanges.setEnabled(hasChanged());
+    }
+  }
 
+  private boolean hasChanged()
+  {
     if (attribute != null)
     {
       try
       {
-        changed = !attribute.toString().equals(getNewAttribute().toString());
+        return !attribute.toString().equals(getNewAttribute().toString());
       }
       catch (Throwable t)
       {
-        changed = true;
+        return true;
       }
     }
-    else
-    {
-      changed = false;
-    }
-    saveChanges.setEnabled(changed);
+    return false;
   }
 
   private String getAttributeName()

--
Gitblit v1.10.0