From 9b22e6c88920b4d06ff0a8a67153452f8fd1bd1b Mon Sep 17 00:00:00 2001
From: Valery Kharseko <vharseko@3a-systems.ru>
Date: Tue, 04 Aug 2026 08:29:20 +0000
Subject: [PATCH] Fix CodeQL note-severity alerts: deprecated JDK calls and inefficient expressions (#823)
---
opendj-server-legacy/src/main/java/org/opends/guitools/controlpanel/ui/DeleteBaseDNPanel.java | 14 ++++----------
1 files changed, 4 insertions(+), 10 deletions(-)
diff --git a/opendj-server-legacy/src/main/java/org/opends/guitools/controlpanel/ui/DeleteBaseDNPanel.java b/opendj-server-legacy/src/main/java/org/opends/guitools/controlpanel/ui/DeleteBaseDNPanel.java
index 364ea46..4f167f3 100644
--- a/opendj-server-legacy/src/main/java/org/opends/guitools/controlpanel/ui/DeleteBaseDNPanel.java
+++ b/opendj-server-legacy/src/main/java/org/opends/guitools/controlpanel/ui/DeleteBaseDNPanel.java
@@ -13,6 +13,7 @@
*
* Copyright 2008-2009 Sun Microsystems, Inc.
* Portions Copyright 2014-2016 ForgeRock AS.
+ * Portions Copyright 2026 3A Systems, LLC.
*/
package org.opends.guitools.controlpanel.ui;
@@ -25,10 +26,10 @@
import java.awt.event.ActionListener;
import java.util.ArrayList;
import java.util.Collection;
-import java.util.Collections;
import java.util.HashMap;
import java.util.HashSet;
import java.util.LinkedHashSet;
+import java.util.List;
import java.util.Map;
import java.util.Set;
import java.util.SortedSet;
@@ -142,13 +143,7 @@
@Override
public void run()
{
- @SuppressWarnings("deprecation")
- Object[] s = list.getSelectedValues();
- Set<Object> selected = new HashSet<>();
- if (s != null)
- {
- Collections.addAll(selected, s);
- }
+ Set<Object> selected = new HashSet<>(list.getSelectedValuesList());
final DefaultListModel model = (DefaultListModel)list.getModel();
model.clear();
SortedSet<Integer> indices = new TreeSet<>();
@@ -333,8 +328,7 @@
ProgressDialog progressDialog = new ProgressDialog(
Utilities.createFrame(),
Utilities.getParentDialog(this), getTitle(), getInfo());
- @SuppressWarnings("deprecation")
- Object[] dns = list.getSelectedValues();
+ List<?> dns = list.getSelectedValuesList();
ArrayList<BaseDNDescriptor> baseDNsToDelete = new ArrayList<>();
for (Object o : dns)
{
--
Gitblit v1.10.0