From 8e398549fb76484e922d6ebfb8519d8dd3c1c2ac Mon Sep 17 00:00:00 2001
From: Gaetan Boismal <gaetan.boismal@forgerock.com>
Date: Fri, 10 Apr 2015 10:30:37 +0000
Subject: [PATCH] OPENDJ-1932 Code cleanup

---
 opendj-server-legacy/src/main/java/org/opends/guitools/controlpanel/ui/NewBaseDNPanel.java |   15 ++++++++++-----
 1 files changed, 10 insertions(+), 5 deletions(-)

diff --git a/opendj-server-legacy/src/main/java/org/opends/guitools/controlpanel/ui/NewBaseDNPanel.java b/opendj-server-legacy/src/main/java/org/opends/guitools/controlpanel/ui/NewBaseDNPanel.java
index 4c8786b..c47f7a3 100644
--- a/opendj-server-legacy/src/main/java/org/opends/guitools/controlpanel/ui/NewBaseDNPanel.java
+++ b/opendj-server-legacy/src/main/java/org/opends/guitools/controlpanel/ui/NewBaseDNPanel.java
@@ -118,6 +118,8 @@
  */
 public class NewBaseDNPanel extends StatusGenericPanel
 {
+  private static final int MAX_ENTRIES_NUMBER_GENERATED = 1000;
+  private static final int MAX_ENTRIES_NUMBER_GENERATED_LOCAL = 20000;
   private static final long serialVersionUID = -2680821576362341119L;
   private static final LocalizableMessage NEW_BACKEND_TEXT = INFO_CTRL_PANEL_NEW_BACKEND_LABEL.get();
 
@@ -635,11 +637,14 @@
   {
     if (importAutomaticallyGenerated.isSelected())
     {
-      String nEntries = numberOfEntries.getText();
-      int minValue = 1;
-      int maxValue = isLocal() ? 20000 : 1000;
-      LocalizableMessage errMsg = ERR_NUMBER_OF_ENTRIES_INVALID.get(minValue, maxValue);
-      checkIntValue(errors, nEntries, minValue, maxValue, errMsg);
+      final int minValue = 1;
+      final int maxValue = isLocal() ? MAX_ENTRIES_NUMBER_GENERATED_LOCAL
+                                     : MAX_ENTRIES_NUMBER_GENERATED;
+      final LocalizableMessage errorMsg = ERR_NUMBER_OF_ENTRIES_INVALID.get(minValue, maxValue);
+      if (!checkIntValue(errors, numberOfEntries.getText(), minValue, maxValue, errorMsg))
+      {
+        setSecondaryInvalid(lNumberOfEntries);
+      }
     }
   }
 

--
Gitblit v1.10.0