From e55ac3f6412e50890bd81a42aeddaa3ac1db6952 Mon Sep 17 00:00:00 2001
From: Jean-Noël Rouvignac <jean-noel.rouvignac@forgerock.com>
Date: Thu, 10 Mar 2016 13:36:54 +0000
Subject: [PATCH] Code cleanup
---
opendj-server-legacy/src/main/java/org/opends/guitools/controlpanel/ui/NewGroupPanel.java | 69 +++++++++++++---------------------
1 files changed, 27 insertions(+), 42 deletions(-)
diff --git a/opendj-server-legacy/src/main/java/org/opends/guitools/controlpanel/ui/NewGroupPanel.java b/opendj-server-legacy/src/main/java/org/opends/guitools/controlpanel/ui/NewGroupPanel.java
index 0fda2c5..d50f780 100644
--- a/opendj-server-legacy/src/main/java/org/opends/guitools/controlpanel/ui/NewGroupPanel.java
+++ b/opendj-server-legacy/src/main/java/org/opends/guitools/controlpanel/ui/NewGroupPanel.java
@@ -14,7 +14,6 @@
* Copyright 2008-2010 Sun Microsystems, Inc.
* Portions Copyright 2013-2016 ForgeRock AS.
*/
-
package org.opends.guitools.controlpanel.ui;
import static org.opends.messages.AdminToolMessages.*;
@@ -48,22 +47,19 @@
import javax.swing.event.DocumentEvent;
import javax.swing.event.DocumentListener;
+import org.forgerock.i18n.LocalizableMessage;
+import org.forgerock.i18n.LocalizedIllegalArgumentException;
+import org.forgerock.opendj.ldap.DN;
import org.opends.guitools.controlpanel.browser.BrowserController;
import org.opends.guitools.controlpanel.ui.nodes.BasicNode;
import org.opends.guitools.controlpanel.ui.nodes.BrowserNodeInfo;
import org.opends.guitools.controlpanel.ui.nodes.DndBrowserNodes;
import org.opends.guitools.controlpanel.util.Utilities;
-import org.forgerock.i18n.LocalizableMessage;
-import org.forgerock.i18n.LocalizedIllegalArgumentException;
-import org.forgerock.opendj.ldap.DN;
import org.opends.server.types.LDAPURL;
import org.opends.server.types.OpenDsException;
import org.opends.server.util.ServerConstants;
-/**
- * The panel to create a group.
- *
- */
+/** The panel to create a group. */
public class NewGroupPanel extends AbstractNewEntryPanel
{
private static final long serialVersionUID = -8173120152617813282L;
@@ -76,7 +72,6 @@
private JLabel lLDAPURL;
private JLabel lReferenceGroup;
-
private JLabel[] labels = {lName, lDescription, lMembers, lDn};
private JTextField name = Utilities.createLongTextField();
@@ -99,24 +94,18 @@
private JLabel dn = Utilities.createDefaultLabel();
-
- /**
- * An array containing the fields of this panel.
- */
+ /** An array containing the fields of this panel. */
protected final JTextField[] fields = {name, description, filter,
referenceGroup};
- /**
- * Default constructor.
- *
- */
+ /** Default constructor. */
public NewGroupPanel()
{
super();
createLayout();
}
- /** {@inheritDoc} */
+ @Override
public void setParent(BasicNode parentNode, BrowserController controller)
{
super.setParent(parentNode, controller);
@@ -129,36 +118,36 @@
filter.setText("ldap:///"+parentNode.getDN()+"??sub?(<your filter>)");
}
- /** {@inheritDoc} */
+ @Override
public LocalizableMessage getTitle()
{
return INFO_CTRL_PANEL_NEW_GROUP_PANEL_TITLE.get();
}
- /** {@inheritDoc} */
+ @Override
public Component getPreferredFocusComponent()
{
return name;
}
- /** {@inheritDoc} */
+ @Override
protected LocalizableMessage getProgressDialogTitle()
{
return INFO_CTRL_PANEL_NEW_GROUP_PANEL_TITLE.get();
}
- /** {@inheritDoc} */
+ @Override
protected boolean checkSyntaxBackground()
{
return staticGroup.isSelected();
}
- /** {@inheritDoc} */
+ @Override
protected void checkSyntax(ArrayList<LocalizableMessage> errors)
{
Runnable runnable = new Runnable()
{
- /** {@inheritDoc} */
+ @Override
public void run()
{
for (JLabel label : labels)
@@ -229,6 +218,7 @@
{
SwingUtilities.invokeLater(new Runnable()
{
+ @Override
public void run()
{
setSecondaryInvalid(lMemberDNs);
@@ -294,10 +284,7 @@
}
}
-
- /**
- * Creates the layout of the panel (but the contents are not populated here).
- */
+ /** Creates the layout of the panel (but the contents are not populated here). */
private void createLayout()
{
GridBagConstraints gbc = new GridBagConstraints();
@@ -348,7 +335,7 @@
staticGroup.setSelected(true);
ActionListener actionListener = new ActionListener()
{
- /** {@inheritDoc} */
+ @Override
public void actionPerformed(ActionEvent ev)
{
checkEnabling();
@@ -414,7 +401,7 @@
addMembers.addActionListener(new ActionListener()
{
- /** {@inheritDoc} */
+ @Override
public void actionPerformed(ActionEvent ev)
{
addMembersClicked();
@@ -488,7 +475,7 @@
Utilities.createButton(INFO_CTRL_PANEL_BROWSE_BUTTON_LABEL.get());
browseReferenceGroup.addActionListener(new ActionListener()
{
- /** {@inheritDoc} */
+ @Override
public void actionPerformed(ActionEvent ev)
{
browseReferenceGroupClicked();
@@ -496,22 +483,21 @@
});
p.add(browseReferenceGroup, gbc2);
-
DocumentListener listener = new DocumentListener()
{
- /** {@inheritDoc} */
+ @Override
public void insertUpdate(DocumentEvent ev)
{
updateDNValue();
}
- /** {@inheritDoc} */
+ @Override
public void changedUpdate(DocumentEvent ev)
{
insertUpdate(ev);
}
- /** {@inheritDoc} */
+ @Override
public void removeUpdate(DocumentEvent ev)
{
insertUpdate(ev);
@@ -525,27 +511,27 @@
DropTargetListener dropTargetlistener = new DropTargetListener()
{
- /** {@inheritDoc} */
+ @Override
public void dragEnter(DropTargetDragEvent e)
{
}
- /** {@inheritDoc} */
+ @Override
public void dragExit(DropTargetEvent e)
{
}
- /** {@inheritDoc} */
+ @Override
public void dragOver(DropTargetDragEvent e)
{
}
- /** {@inheritDoc} */
+ @Override
public void dropActionChanged(DropTargetDragEvent e)
{
}
- /** {@inheritDoc} */
+ @Override
public void drop(DropTargetDropEvent e)
{
try {
@@ -670,7 +656,7 @@
}
}
- /** {@inheritDoc} */
+ @Override
protected String getLDIF()
{
StringBuilder sb = new StringBuilder();
@@ -739,4 +725,3 @@
lReferenceGroup.setEnabled(virtualGroup.isSelected());
}
}
-
--
Gitblit v1.10.0