From 01bf9b6a5d324d45355659581e9ebbd1280834fe Mon Sep 17 00:00:00 2001
From: Jean-Noël Rouvignac <jean-noel.rouvignac@forgerock.com>
Date: Mon, 25 Apr 2016 14:41:26 +0000
Subject: [PATCH] Improvements suggested by UCDetector: remove dead code, add final keywords, change visibilities
---
opendj-server-legacy/src/main/java/org/opends/quicksetup/ui/CertificateDialog.java | 11 +++++------
1 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/opendj-server-legacy/src/main/java/org/opends/quicksetup/ui/CertificateDialog.java b/opendj-server-legacy/src/main/java/org/opends/quicksetup/ui/CertificateDialog.java
index 2913dbf..9704d8c 100644
--- a/opendj-server-legacy/src/main/java/org/opends/quicksetup/ui/CertificateDialog.java
+++ b/opendj-server-legacy/src/main/java/org/opends/quicksetup/ui/CertificateDialog.java
@@ -12,9 +12,8 @@
* information: "Portions Copyright [year] [name of copyright owner]".
*
* Copyright 2008-2009 Sun Microsystems, Inc.
- * Portions Copyright 2013-2015 ForgeRock AS.
+ * Portions Copyright 2013-2016 ForgeRock AS.
*/
-
package org.opends.quicksetup.ui;
import static org.opends.messages.QuickSetupMessages.*;
@@ -80,7 +79,7 @@
}
private static final long serialVersionUID = -8989965057591475064L;
private ReturnType returnValue = ReturnType.NOT_ACCEPTED;
- private UserDataCertificateException ce;
+ private final UserDataCertificateException ce;
private JButton doNotAcceptButton;
private JComponent certificateDetails;
private JEditorPane explanationPane;
@@ -391,7 +390,7 @@
p.setLayout(new GridBagLayout());
if (ce.getChain() != null && ce.getChain().length > 0)
{
- final JComboBox combo = new JComboBox();
+ final JComboBox<String> combo = new JComboBox<String>();
combo.setToolTipText(
INFO_CERTIFICATE_CHAIN_COMBO_TOOLTIP.get().toString());
final CardLayout cl = new CardLayout();
@@ -596,7 +595,7 @@
* @param cert the certificate object.
* @return the LocalizableMessage representation of the SHA1 fingerprint.
*/
- public static LocalizableMessage getSHA1FingerPrint(X509Certificate cert)
+ private static LocalizableMessage getSHA1FingerPrint(X509Certificate cert)
{
return getFingerPrint(cert, "SHA1");
}
@@ -606,7 +605,7 @@
* @param cert the certificate object.
* @return the LocalizableMessage representation of the MD5 fingerprint.
*/
- public static LocalizableMessage getMD5FingerPrint(X509Certificate cert)
+ private static LocalizableMessage getMD5FingerPrint(X509Certificate cert)
{
return getFingerPrint(cert, "MD5");
}
--
Gitblit v1.10.0