From 01bf9b6a5d324d45355659581e9ebbd1280834fe Mon Sep 17 00:00:00 2001
From: Jean-Noël Rouvignac <jean-noel.rouvignac@forgerock.com>
Date: Mon, 25 Apr 2016 14:41:26 +0000
Subject: [PATCH] Improvements suggested by UCDetector: remove dead code, add final keywords, change visibilities
---
opendj-server-legacy/src/main/java/org/opends/quicksetup/ui/QuickSetupStepPanel.java | 21 +++++++++++++--------
1 files changed, 13 insertions(+), 8 deletions(-)
diff --git a/opendj-server-legacy/src/main/java/org/opends/quicksetup/ui/QuickSetupStepPanel.java b/opendj-server-legacy/src/main/java/org/opends/quicksetup/ui/QuickSetupStepPanel.java
index 28f39c2..3f12105 100644
--- a/opendj-server-legacy/src/main/java/org/opends/quicksetup/ui/QuickSetupStepPanel.java
+++ b/opendj-server-legacy/src/main/java/org/opends/quicksetup/ui/QuickSetupStepPanel.java
@@ -16,13 +16,16 @@
*/
package org.opends.quicksetup.ui;
+import static org.opends.messages.QuickSetupMessages.*;
+
import java.awt.CardLayout;
import java.awt.Component;
import java.awt.GridBagConstraints;
import java.awt.GridBagLayout;
-
import java.util.HashMap;
import java.util.HashSet;
+import java.util.Map;
+import java.util.Set;
import javax.swing.Box;
import javax.swing.JEditorPane;
@@ -31,15 +34,14 @@
import javax.swing.event.HyperlinkEvent;
import javax.swing.event.HyperlinkListener;
-import org.opends.quicksetup.event.ButtonActionListener;
-import org.opends.quicksetup.event.ButtonEvent;
+import org.forgerock.i18n.LocalizableMessage;
import org.opends.quicksetup.ProgressDescriptor;
import org.opends.quicksetup.UserData;
+import org.opends.quicksetup.event.ButtonActionListener;
+import org.opends.quicksetup.event.ButtonEvent;
import org.opends.quicksetup.util.HtmlProgressMessageFormatter;
import org.opends.quicksetup.util.ProgressMessageFormatter;
import org.opends.quicksetup.util.URLWorker;
-import org.forgerock.i18n.LocalizableMessage;
-import static org.opends.messages.QuickSetupMessages.*;
/**
* This is an abstract class that is extended by all the classes that are in
@@ -54,7 +56,7 @@
private JPanel inputContainer;
private Component inputPanel;
- private HashSet<ButtonActionListener> buttonListeners = new HashSet<>();
+ private final Set<ButtonActionListener> buttonListeners = new HashSet<>();
private ProgressMessageFormatter formatter;
@@ -67,7 +69,7 @@
* We can use a HashMap (not multi-thread safe) because all
* the calls to this object are done in the event-thread.
*/
- private HashMap<String, URLWorker> hmURLWorkers = new HashMap<>();
+ private final Map<String, URLWorker> hmURLWorkers = new HashMap<>();
/**
* Creates a default instance.
@@ -93,11 +95,13 @@
*/
public void beginDisplay(UserData data)
{
+ // no-op
}
/** Called just after the panel is shown: used to set focus properly. */
public void endDisplay()
{
+ // no-op
}
/**
@@ -118,6 +122,7 @@
*/
public void displayProgress(ProgressDescriptor descriptor)
{
+ // no-op
}
/**
@@ -266,7 +271,7 @@
}
}
/** Creates the layout of the panel. */
- protected void createLayout()
+ private void createLayout()
{
setLayout(new GridBagLayout());
--
Gitblit v1.10.0