From d3e64655c9ebfefffbe641d58eeacdd8a8fb72dd Mon Sep 17 00:00:00 2001
From: Jean-Noel Rouvignac <jean-noel.rouvignac@forgerock.com>
Date: Mon, 17 Aug 2015 08:21:47 +0000
Subject: [PATCH] Code improvements

---
 opendj-server-legacy/src/main/java/org/opends/server/backends/pluggable/EntryContainer.java |   24 ++++++++----------------
 1 files changed, 8 insertions(+), 16 deletions(-)

diff --git a/opendj-server-legacy/src/main/java/org/opends/server/backends/pluggable/EntryContainer.java b/opendj-server-legacy/src/main/java/org/opends/server/backends/pluggable/EntryContainer.java
index 0ceece0..289e0bc 100644
--- a/opendj-server-legacy/src/main/java/org/opends/server/backends/pluggable/EntryContainer.java
+++ b/opendj-server-legacy/src/main/java/org/opends/server/backends/pluggable/EntryContainer.java
@@ -189,7 +189,6 @@
   ConfigurationAddListener<BackendIndexCfg>,
   ConfigurationDeleteListener<BackendIndexCfg>
   {
-    /** {@inheritDoc} */
     @Override
     public boolean isConfigurationAddAcceptable(final BackendIndexCfg cfg, List<LocalizableMessage> unacceptableReasons)
     {
@@ -205,7 +204,6 @@
       }
     }
 
-    /** {@inheritDoc} */
     @Override
     public ConfigChangeResult applyConfigurationAdd(final BackendIndexCfg cfg)
     {
@@ -236,7 +234,6 @@
       return ccr;
     }
 
-    /** {@inheritDoc} */
     @Override
     public boolean isConfigurationDeleteAcceptable(
         BackendIndexCfg cfg, List<LocalizableMessage> unacceptableReasons)
@@ -245,7 +242,6 @@
       return true;
     }
 
-    /** {@inheritDoc} */
     @Override
     public ConfigChangeResult applyConfigurationDelete(final BackendIndexCfg cfg)
     {
@@ -285,7 +281,6 @@
   ConfigurationAddListener<BackendVLVIndexCfg>,
   ConfigurationDeleteListener<BackendVLVIndexCfg>
   {
-    /** {@inheritDoc} */
     @Override
     public boolean isConfigurationAddAcceptable(
         BackendVLVIndexCfg cfg, List<LocalizableMessage> unacceptableReasons)
@@ -341,7 +336,6 @@
       return true;
     }
 
-    /** {@inheritDoc} */
     @Override
     public ConfigChangeResult applyConfigurationAdd(final BackendVLVIndexCfg cfg)
     {
@@ -372,7 +366,6 @@
       return ccr;
     }
 
-    /** {@inheritDoc} */
     @Override
     public boolean isConfigurationDeleteAcceptable(BackendVLVIndexCfg cfg, List<LocalizableMessage> unacceptableReasons)
     {
@@ -380,7 +373,6 @@
       return true;
     }
 
-    /** {@inheritDoc} */
     @Override
     public ConfigChangeResult applyConfigurationDelete(final BackendVLVIndexCfg cfg)
     {
@@ -605,7 +597,7 @@
   }
 
   /**
-   * Look for an VLV index for the given index name.
+   * Look for a VLV index for the given index name.
    *
    * @param vlvIndexName The vlv index name for which an vlv index is needed.
    * @return The VLV index or null if there is none with that name.
@@ -2539,8 +2531,7 @@
         @Override
         public Long run(ReadableTransaction txn) throws Exception
         {
-          final int baseDnIfExists = dn2id.get(txn, baseDN) != null ? 1 : 0;
-          return id2childrenCount.getTotalCount(txn) + baseDnIfExists;
+          return getNumberOfEntriesInBaseDN0(txn);
         }
       });
     }
@@ -2550,6 +2541,12 @@
     }
   }
 
+  long getNumberOfEntriesInBaseDN0(ReadableTransaction txn)
+  {
+    final int baseDnIfExists = dn2id.get(txn, baseDN) != null ? 1 : 0;
+    return id2childrenCount.getTotalCount(txn) + baseDnIfExists;
+  }
+
   /**
    * Determine whether the provided operation has the ManageDsaIT request
    * control.
@@ -2680,7 +2677,6 @@
     }
   }
 
-  /** {@inheritDoc} */
   @Override
   public DN getBaseDN()
   {
@@ -2702,7 +2698,6 @@
     return dn.parent();
   }
 
-  /** {@inheritDoc} */
   @Override
   public boolean isConfigurationChangeAcceptable(
       PluggableBackendCfg cfg, List<LocalizableMessage> unacceptableReasons)
@@ -2712,7 +2707,6 @@
     return true;
   }
 
-  /** {@inheritDoc} */
   @Override
   public ConfigChangeResult applyConfigurationChange(final PluggableBackendCfg cfg)
   {
@@ -3127,10 +3121,8 @@
     exclusiveLock.unlock();
   }
 
-  /** {@inheritDoc} */
   @Override
   public String toString() {
     return treePrefix;
   }
-
 }

--
Gitblit v1.10.0