From e24c2780b6d44c7e5d386e70a1fb3346149ccdc9 Mon Sep 17 00:00:00 2001
From: Valery Kharseko <vharseko@3a-systems.ru>
Date: Tue, 04 Aug 2026 07:15:33 +0000
Subject: [PATCH] Fix CodeQL note-severity alerts: array logging and uncaught NumberFormatException (#817)
---
opendj-server-legacy/src/main/java/org/opends/server/backends/pluggable/ID2Entry.java | 26 ++++++++++++++++++++++++--
1 files changed, 24 insertions(+), 2 deletions(-)
diff --git a/opendj-server-legacy/src/main/java/org/opends/server/backends/pluggable/ID2Entry.java b/opendj-server-legacy/src/main/java/org/opends/server/backends/pluggable/ID2Entry.java
index be1fd64..72bbded 100644
--- a/opendj-server-legacy/src/main/java/org/opends/server/backends/pluggable/ID2Entry.java
+++ b/opendj-server-legacy/src/main/java/org/opends/server/backends/pluggable/ID2Entry.java
@@ -32,6 +32,8 @@
import java.util.zip.InflaterInputStream;
import java.util.zip.InflaterOutputStream;
+import org.forgerock.i18n.LocalizableMessage;
+import org.forgerock.i18n.LocalizedIllegalArgumentException;
import org.forgerock.i18n.slf4j.LocalizedLogger;
import org.forgerock.opendj.io.ASN1;
import org.forgerock.opendj.io.ASN1Reader;
@@ -556,7 +558,27 @@
@Override
public ByteString generateKey(String data)
{
- EntryID entryID = new EntryID(Long.parseLong(data));
- return entryID.toByteString();
+ return new EntryID(parseEntryID(data)).toByteString();
+ }
+
+ /**
+ * Returns the entry ID held by the provided string.
+ *
+ * @param data
+ * The string representation of an entry ID
+ * @return the parsed entry ID
+ * @throws LocalizedIllegalArgumentException
+ * If the provided string does not hold an entry ID
+ */
+ static long parseEntryID(String data)
+ {
+ try
+ {
+ return Long.parseLong(data);
+ }
+ catch (NumberFormatException e)
+ {
+ throw new LocalizedIllegalArgumentException(LocalizableMessage.raw("Invalid entry ID: \"%s\"", data));
+ }
}
}
--
Gitblit v1.10.0