From 069a1256c6ebdc1142e525a44733bc32fd834061 Mon Sep 17 00:00:00 2001
From: Valery Kharseko <vharseko@3a-systems.ru>
Date: Tue, 04 Aug 2026 11:37:29 +0000
Subject: [PATCH] Fix CodeQL note-severity alerts: ignored error status of file and stream calls (#814)
---
opendj-server-legacy/src/main/java/org/opends/server/backends/task/TaskScheduler.java | 21 ++++-----------------
1 files changed, 4 insertions(+), 17 deletions(-)
diff --git a/opendj-server-legacy/src/main/java/org/opends/server/backends/task/TaskScheduler.java b/opendj-server-legacy/src/main/java/org/opends/server/backends/task/TaskScheduler.java
index 97e006d..8f2216d 100644
--- a/opendj-server-legacy/src/main/java/org/opends/server/backends/task/TaskScheduler.java
+++ b/opendj-server-legacy/src/main/java/org/opends/server/backends/task/TaskScheduler.java
@@ -1249,28 +1249,15 @@
writer.close();
- // See if there is a ".save" file. If so, then delete it.
- File saveFile = getFileForPath(backingFilePath + ".save");
- try
- {
- if (saveFile.exists())
- {
- saveFile.delete();
- }
- }
- catch (Exception e)
- {
- logger.traceException(e);
- }
-
-
// If there is an existing backing file, then rename it to ".save".
+ // renameFile() deletes an existing ".save" file and reports a failure to do so.
+ File saveFile = getFileForPath(backingFilePath + ".save");
File backingFile = getFileForPath(backingFilePath);
try
{
if (backingFile.exists())
{
- backingFile.renameTo(saveFile);
+ renameFile(backingFile, saveFile);
}
}
catch (Exception e)
@@ -1289,7 +1276,7 @@
File tmpFile = getFileForPath(tmpFilePath);
try
{
- tmpFile.renameTo(backingFile);
+ renameFile(tmpFile, backingFile);
}
catch (Exception e)
{
--
Gitblit v1.10.0