From 61b9eb1be03fc03a9f4bb0013a08ff44a1059503 Mon Sep 17 00:00:00 2001
From: Jean-Noël Rouvignac <jean-noel.rouvignac@forgerock.com>
Date: Wed, 20 Apr 2016 14:25:46 +0000
Subject: [PATCH] opendj-server-legacy: added @Override + Autorefactor'ed comments

---
 opendj-server-legacy/src/main/java/org/opends/server/extensions/JMXAlertHandler.java |   61 ++++++++----------------------
 1 files changed, 16 insertions(+), 45 deletions(-)

diff --git a/opendj-server-legacy/src/main/java/org/opends/server/extensions/JMXAlertHandler.java b/opendj-server-legacy/src/main/java/org/opends/server/extensions/JMXAlertHandler.java
index 6cacd90..7192a71 100644
--- a/opendj-server-legacy/src/main/java/org/opends/server/extensions/JMXAlertHandler.java
+++ b/opendj-server-legacy/src/main/java/org/opends/server/extensions/JMXAlertHandler.java
@@ -71,25 +71,18 @@
   private static final String CLASS_NAME =
        "org.opends.server.extensions.JMXAlertHandler";
 
-
-
   /** The current configuration for this alert handler. */
   private AlertHandlerCfg currentConfig;
 
   /** The sequence number generator used for this alert handler. */
   private AtomicLong sequenceNumber;
 
-  /**
-   * The DN of the configuration entry with which this alert handler is
-   * associated.
-   */
+  /** The DN of the configuration entry with which this alert handler is associated. */
   private DN configEntryDN;
 
   /** The JMX object name used for this JMX alert handler. */
   private ObjectName objectName;
 
-
-
   /**
    * Creates a new instance of this JMX alert handler.  No initialization should
    * be done here, as it should all be performed in the
@@ -100,9 +93,7 @@
     super();
   }
 
-
-
-  /** {@inheritDoc} */
+  @Override
   public void initializeAlertHandler(JMXAlertHandlerCfg configuration)
        throws ConfigException, InitializationException
   {
@@ -147,17 +138,13 @@
     }
   }
 
-
-
-  /** {@inheritDoc} */
+  @Override
   public AlertHandlerCfg getAlertHandlerConfiguration()
   {
     return currentConfig;
   }
 
-
-
-  /** {@inheritDoc} */
+  @Override
   public boolean isConfigurationAcceptable(AlertHandlerCfg configuration,
                                            List<LocalizableMessage> unacceptableReasons)
   {
@@ -165,29 +152,24 @@
     return isConfigurationChangeAcceptable(cfg, unacceptableReasons);
   }
 
-
-
-  /** {@inheritDoc} */
+  @Override
   public void finalizeAlertHandler()
   {
     // No action is required.
   }
 
-
-
   /**
    * Retrieves the JMX object name for this JMX alert handler.
    *
    * @return  The JMX object name for this JMX alert handler.
    */
+  @Override
   public ObjectName getObjectName()
   {
     return objectName;
   }
 
-
-
-  /** {@inheritDoc} */
+  @Override
   public void sendAlertNotification(AlertGenerator generator, String alertType,
                                     LocalizableMessage alertMessage)
   {
@@ -197,8 +179,6 @@
                                       alertMessage.toString()));
   }
 
-
-
   /**
    * Retrieves information about the types of JMX notifications that may be
    * generated.
@@ -206,6 +186,7 @@
    * @return  Information about the types of JMX notifications that may be
    *          generated.
    */
+  @Override
   public MBeanNotificationInfo[] getNotificationInfo()
   {
     ArrayList<MBeanNotificationInfo> notifications = new ArrayList<>();
@@ -219,8 +200,6 @@
     return notifications.toArray(new MBeanNotificationInfo[notifications.size()]);
   }
 
-
-
   /**
    * Obtain the value of a specific attribute of the Dynamic MBean.
    *
@@ -231,6 +210,7 @@
    * @throws  AttributeNotFoundException  If the specified attribute is not
    *                                      associated with this MBean.
    */
+  @Override
   public Attribute getAttribute(String attribute)
          throws AttributeNotFoundException
   {
@@ -239,8 +219,6 @@
     throw new AttributeNotFoundException(message.toString());
   }
 
-
-
   /**
    * Set the value of a specific attribute of the Dynamic MBean.
    *
@@ -253,6 +231,7 @@
    * @throws  InvalidAttributeValueException  If the provided value is not
    *                                          acceptable for this MBean.
    */
+  @Override
   public void setAttribute(Attribute attribute)
          throws AttributeNotFoundException, InvalidAttributeValueException
   {
@@ -261,8 +240,6 @@
     throw new AttributeNotFoundException(message.toString());
   }
 
-
-
   /**
    * Get the values of several attributes of the Dynamic MBean.
    *
@@ -270,14 +247,13 @@
    *
    * @return  The list of attributes retrieved.
    */
+  @Override
   public AttributeList getAttributes(String[] attributes)
   {
     // There are no attributes for this MBean.
     return new AttributeList();
   }
 
-
-
   /**
    * Sets the values of several attributes of the Dynamic MBean.
    *
@@ -287,14 +263,13 @@
    *
    * @return  The list of attributes that were set with their new values.
    */
+  @Override
   public AttributeList setAttributes(AttributeList attributes)
   {
     // There are no attributes for this MBean.
     return new AttributeList();
   }
 
-
-
   /**
    * Allows an action to be invoked on the Dynamic MBean.
    *
@@ -312,6 +287,7 @@
    * @throws  MBeanException  If a problem is encountered while invoking the
    *                          method.
    */
+  @Override
   public Object invoke(String actionName, Object[] params, String[] signature)
          throws MBeanException
   {
@@ -337,8 +313,6 @@
     throw new MBeanException(new ConfigException(message));
   }
 
-
-
   /**
    * Provides the exposed attributes and actions of the Dynamic MBean using an
    * MBeanInfo object.
@@ -346,6 +320,7 @@
    * @return  An instance of <CODE>MBeanInfo</CODE> allowing all attributes and
    *          actions exposed by this Dynamic MBean to be retrieved.
    */
+  @Override
   public MBeanInfo getMBeanInfo()
   {
     return new MBeanInfo(CLASS_NAME, "JMX Alert Handler",
@@ -353,9 +328,7 @@
                          new MBeanOperationInfo[0], getNotificationInfo());
   }
 
-
-
-  /** {@inheritDoc} */
+  @Override
   public boolean isConfigurationChangeAcceptable(
                       JMXAlertHandlerCfg configuration,
                       List<LocalizableMessage> unacceptableReasons)
@@ -363,9 +336,7 @@
     return true;
   }
 
-
-
-  /** {@inheritDoc} */
+  @Override
   public ConfigChangeResult applyConfigurationChange(
                                         JMXAlertHandlerCfg configuration)
   {

--
Gitblit v1.10.0