From 9b22e6c88920b4d06ff0a8a67153452f8fd1bd1b Mon Sep 17 00:00:00 2001
From: Valery Kharseko <vharseko@3a-systems.ru>
Date: Tue, 04 Aug 2026 08:29:20 +0000
Subject: [PATCH] Fix CodeQL note-severity alerts: deprecated JDK calls and inefficient expressions (#823)
---
opendj-server-legacy/src/main/java/org/opends/server/loggers/AbstractLogger.java | 10 ++++++----
1 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/opendj-server-legacy/src/main/java/org/opends/server/loggers/AbstractLogger.java b/opendj-server-legacy/src/main/java/org/opends/server/loggers/AbstractLogger.java
index d26ac7f..db6bbd7 100644
--- a/opendj-server-legacy/src/main/java/org/opends/server/loggers/AbstractLogger.java
+++ b/opendj-server-legacy/src/main/java/org/opends/server/loggers/AbstractLogger.java
@@ -13,6 +13,7 @@
*
* Copyright 2006-2008 Sun Microsystems, Inc.
* Portions Copyright 2011-2016 ForgeRock AS.
+ * Portions Copyright 2026 3A Systems, LLC.
*/
package org.opends.server.loggers;
@@ -373,10 +374,11 @@
String className = config.getJavaClass();
ClassPropertyDefinition pd = getJavaClassPropertyDefinition();
try {
- P publisher = pd.loadClass(className, logPublisherClass).newInstance();
+ P publisher = pd.loadClass(className, logPublisherClass).getDeclaredConstructor().newInstance();
return publisher.isConfigurationAcceptable(config, unacceptableReasons);
} catch (Exception e) {
- unacceptableReasons.add(invalidLoggerClassErrorMessage.get(className, config.dn(), e));
+ unacceptableReasons.add(invalidLoggerClassErrorMessage.get(className, config.dn(),
+ stackTraceToSingleLineString(e)));
return false;
}
}
@@ -386,14 +388,14 @@
String className = config.getJavaClass();
ClassPropertyDefinition pd = getJavaClassPropertyDefinition();
try {
- P logPublisher = pd.loadClass(className, logPublisherClass).newInstance();
+ P logPublisher = pd.loadClass(className, logPublisherClass).getDeclaredConstructor().newInstance();
logPublisher.initializeLogPublisher(config, serverContext);
return logPublisher;
}
catch (Exception e)
{
throw new ConfigException(
- invalidLoggerClassErrorMessage.get(className, config.dn(), e), e);
+ invalidLoggerClassErrorMessage.get(className, config.dn(), stackTraceToSingleLineString(e)), e);
}
}
--
Gitblit v1.10.0