From a632fbfad0ddbe8b343c6abe8e28dc41e3df9b7e Mon Sep 17 00:00:00 2001
From: Jean-Noel Rouvignac <jean-noel.rouvignac@forgerock.com>
Date: Fri, 10 Jul 2015 10:16:25 +0000
Subject: [PATCH] Code cleanup
---
opendj-server-legacy/src/main/java/org/opends/server/schema/NameFormSyntax.java | 112 +++++++++++++++-----------------------------------------
1 files changed, 30 insertions(+), 82 deletions(-)
diff --git a/opendj-server-legacy/src/main/java/org/opends/server/schema/NameFormSyntax.java b/opendj-server-legacy/src/main/java/org/opends/server/schema/NameFormSyntax.java
index cd949e1..f46a6f6 100644
--- a/opendj-server-legacy/src/main/java/org/opends/server/schema/NameFormSyntax.java
+++ b/opendj-server-legacy/src/main/java/org/opends/server/schema/NameFormSyntax.java
@@ -36,6 +36,7 @@
import java.util.List;
import org.forgerock.i18n.LocalizableMessage;
+import org.forgerock.i18n.LocalizableMessageDescriptor.Arg2;
import org.forgerock.opendj.ldap.ByteSequence;
import org.forgerock.opendj.ldap.ResultCode;
import org.forgerock.opendj.ldap.schema.ObjectClassType;
@@ -432,29 +433,10 @@
{
StringBuilder woidBuffer = new StringBuilder();
pos = readWOID(lowerStr, woidBuffer, (pos));
+ attrs.add(getAttributeType(schema, allowUnknownElements, oid, woidBuffer,
+ ERR_ATTR_SYNTAX_NAME_FORM_UNKNOWN_REQUIRED_ATTR));
- AttributeType attr = schema.getAttributeType(woidBuffer.toString());
- if (attr == null)
- {
- // This isn't good because it means that the name form requires
- // an attribute type that we don't know anything about.
- if (allowUnknownElements)
- {
- attr = DirectoryServer.getDefaultAttributeType(
- woidBuffer.toString());
- }
- else
- {
- throw new DirectoryException(ResultCode.CONSTRAINT_VIOLATION,
- ERR_ATTR_SYNTAX_NAME_FORM_UNKNOWN_REQUIRED_ATTR.get(oid, woidBuffer));
- }
- }
-
- attrs.add(attr);
-
-
- // The next character must be either a dollar sign or a closing
- // parenthesis.
+ // The next character must be either a dollar sign or a closing parenthesis.
c = valueStr.charAt(pos++);
if (c == ')')
{
@@ -474,25 +456,8 @@
{
StringBuilder woidBuffer = new StringBuilder();
pos = readWOID(lowerStr, woidBuffer, (pos-1));
-
- AttributeType attr = schema.getAttributeType(woidBuffer.toString());
- if (attr == null)
- {
- // This isn't good because it means that the name form requires an
- // attribute type that we don't know anything about.
- if (allowUnknownElements)
- {
- attr = DirectoryServer.getDefaultAttributeType(
- woidBuffer.toString());
- }
- else
- {
- throw new DirectoryException(ResultCode.CONSTRAINT_VIOLATION,
- ERR_ATTR_SYNTAX_NAME_FORM_UNKNOWN_REQUIRED_ATTR.get(oid, woidBuffer));
- }
- }
-
- attrs.add(attr);
+ attrs.add(getAttributeType(schema, allowUnknownElements, oid, woidBuffer,
+ ERR_ATTR_SYNTAX_NAME_FORM_UNKNOWN_REQUIRED_ATTR));
}
requiredAttributes.addAll(attrs);
@@ -512,29 +477,10 @@
{
StringBuilder woidBuffer = new StringBuilder();
pos = readWOID(lowerStr, woidBuffer, (pos));
+ attrs.add(getAttributeType(schema, allowUnknownElements, oid, woidBuffer,
+ ERR_ATTR_SYNTAX_NAME_FORM_UNKNOWN_OPTIONAL_ATTR));
- AttributeType attr = schema.getAttributeType(woidBuffer.toString());
- if (attr == null)
- {
- // This isn't good because it means that the name form allows an
- // attribute type that we don't know anything about.
- if (allowUnknownElements)
- {
- attr = DirectoryServer.getDefaultAttributeType(
- woidBuffer.toString());
- }
- else
- {
- throw new DirectoryException(ResultCode.CONSTRAINT_VIOLATION,
- ERR_ATTR_SYNTAX_NAME_FORM_UNKNOWN_OPTIONAL_ATTR.get(oid, woidBuffer));
- }
- }
-
- attrs.add(attr);
-
-
- // The next character must be either a dollar sign or a closing
- // parenthesis.
+ // The next character must be either a dollar sign or a closing parenthesis.
c = valueStr.charAt(pos++);
if (c == ')')
{
@@ -554,25 +500,8 @@
{
StringBuilder woidBuffer = new StringBuilder();
pos = readWOID(lowerStr, woidBuffer, (pos-1));
-
- AttributeType attr = schema.getAttributeType(woidBuffer.toString());
- if (attr == null)
- {
- // This isn't good because it means that the name form allows an
- // attribute type that we don't know anything about.
- if (allowUnknownElements)
- {
- attr = DirectoryServer.getDefaultAttributeType(
- woidBuffer.toString());
- }
- else
- {
- throw new DirectoryException(ResultCode.CONSTRAINT_VIOLATION,
- ERR_ATTR_SYNTAX_NAME_FORM_UNKNOWN_OPTIONAL_ATTR.get(oid, woidBuffer));
- }
- }
-
- attrs.add(attr);
+ attrs.add(getAttributeType(schema, allowUnknownElements, oid, woidBuffer,
+ ERR_ATTR_SYNTAX_NAME_FORM_UNKNOWN_OPTIONAL_ATTR));
}
optionalAttributes.addAll(attrs);
@@ -606,6 +535,25 @@
optionalAttributes, extraProperties);
}
+ private static AttributeType getAttributeType(Schema schema, boolean allowUnknownElements, String oid,
+ StringBuilder woidBuffer, Arg2<Object, Object> msg) throws DirectoryException
+ {
+ String woidString = woidBuffer.toString();
+ AttributeType attr = schema.getAttributeType(woidString);
+ if (attr == null)
+ {
+ // This isn't good because it means that the name form
+ // refers to an attribute type that we don't know anything about.
+ if (!allowUnknownElements)
+ {
+ throw new DirectoryException(ResultCode.CONSTRAINT_VIOLATION,
+ msg.get(oid, woidString));
+ }
+ attr = DirectoryServer.getDefaultAttributeType(woidString);
+ }
+ return attr;
+ }
+
/**
* Reads the next token name from the name form definition, skipping over any
* leading or trailing spaces, and appends it to the provided buffer.
--
Gitblit v1.10.0