From 504a43fc479d884085df9895900608dc5b0aca6f Mon Sep 17 00:00:00 2001
From: Valery Kharseko <vharseko@3a-systems.ru>
Date: Fri, 31 Jul 2026 07:52:35 +0000
Subject: [PATCH] Fix CodeQL warning-severity alerts: dead checks, boxed locals and three null dereferences (#793)
---
opendj-server-legacy/src/main/java/org/opends/server/tasks/ImportTask.java | 10 ++++++++++
1 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/opendj-server-legacy/src/main/java/org/opends/server/tasks/ImportTask.java b/opendj-server-legacy/src/main/java/org/opends/server/tasks/ImportTask.java
index 648c97b..f2f12a2 100644
--- a/opendj-server-legacy/src/main/java/org/opends/server/tasks/ImportTask.java
+++ b/opendj-server-legacy/src/main/java/org/opends/server/tasks/ImportTask.java
@@ -13,6 +13,7 @@
*
* Copyright 2006-2009 Sun Microsystems, Inc.
* Portions Copyright 2013-2016 ForgeRock AS.
+ * Portions Copyright 2026 3A Systems, LLC.
*/
package org.opends.server.tasks;
@@ -475,6 +476,15 @@
}
}
+ if (backend == null)
+ {
+ // Unlike initializeTask(), this method does not reject an include branch which resolves to no
+ // backend, so none of them having resolved leaves nothing to import into. The message of the
+ // backend ID case is reused here rather than adding a new one for a malformed task.
+ logger.error(ERR_LDIFIMPORT_NO_BACKENDS_FOR_ID);
+ return TaskState.STOPPED_BY_ERROR;
+ }
+
// Find backends with subordinate base DNs that should be excluded from the import.
defaultIncludeBranches = new HashSet<>(backend.getBaseDNs());
for (Backend<?> subBackend : getServerContext().getBackendConfigManager().getSubordinateBackends(backend))
--
Gitblit v1.10.0