From 4c7057e45ba8a2f3bc1f0b02b3edf14886fd1956 Mon Sep 17 00:00:00 2001
From: Valery Kharseko <vharseko@3a-systems.ru>
Date: Tue, 04 Aug 2026 08:31:56 +0000
Subject: [PATCH] Fix CodeQL note-severity alerts: uncaught NumberFormatException in the tools, the GUI and SNMP (#829)
---
opendj-server-legacy/src/main/java/org/opends/server/tools/InstallDS.java | 20 ++++++++++++++------
1 files changed, 14 insertions(+), 6 deletions(-)
diff --git a/opendj-server-legacy/src/main/java/org/opends/server/tools/InstallDS.java b/opendj-server-legacy/src/main/java/org/opends/server/tools/InstallDS.java
index 2594512..23619e6 100644
--- a/opendj-server-legacy/src/main/java/org/opends/server/tools/InstallDS.java
+++ b/opendj-server-legacy/src/main/java/org/opends/server/tools/InstallDS.java
@@ -14,6 +14,7 @@
* Copyright 2006-2010 Sun Microsystems, Inc.
* Portions Copyright 2011 profiq s.r.o.
* Portions Copyright 2011-2016 ForgeRock AS.
+ * Portions Copyright 2026 3A Systems, LLC.
*/
package org.opends.server.tools;
@@ -291,10 +292,10 @@
}
lastResetDirectoryManagerDN = DN.valueOf(argParser.directoryManagerDNArg.getDefaultValue());
- lastResetLdapPort = Integer.parseInt(argParser.ldapPortArg.getDefaultValue());
- lastResetLdapsPort = Integer.parseInt(argParser.ldapsPortArg.getDefaultValue());
- lastResetAdminConnectorPort = Integer.parseInt(argParser.adminConnectorPortArg.getDefaultValue());
- lastResetJmxPort = Integer.parseInt(argParser.jmxPortArg.getDefaultValue());
+ lastResetLdapPort = argParser.ldapPortArg.getDefaultIntValue(-1);
+ lastResetLdapsPort = argParser.ldapsPortArg.getDefaultIntValue(-1);
+ lastResetAdminConnectorPort = argParser.adminConnectorPortArg.getDefaultIntValue(-1);
+ lastResetJmxPort = argParser.jmxPortArg.getDefaultIntValue(-1);
// Validate user provided data
try
@@ -758,8 +759,15 @@
}
else if (argParser.sampleDataArg.isPresent())
{
- dataOptions = NewSuffixOptions.createAutomaticallyGenerated(baseDNs,
- Integer.valueOf(argParser.sampleDataArg.getValue()));
+ try
+ {
+ dataOptions = NewSuffixOptions.createAutomaticallyGenerated(baseDNs, argParser.sampleDataArg.getIntValue());
+ }
+ catch (final ArgumentException ae)
+ {
+ errorMessages.add(ae.getMessageObject());
+ dataOptions = NewSuffixOptions.createEmpty(baseDNs);
+ }
}
else
{
--
Gitblit v1.10.0