From bd8b80653a50e445f59cac7c1e80309dba23712e Mon Sep 17 00:00:00 2001
From: Valery Kharseko <vharseko@3a-systems.ru>
Date: Tue, 04 Aug 2026 08:28:21 +0000
Subject: [PATCH] Fix CodeQL note-severity alerts: dead parameters of private methods (#834)
---
opendj-server-legacy/src/main/java/org/opends/server/tools/LDAPAuthenticationHandler.java | 10 ++--------
1 files changed, 2 insertions(+), 8 deletions(-)
diff --git a/opendj-server-legacy/src/main/java/org/opends/server/tools/LDAPAuthenticationHandler.java b/opendj-server-legacy/src/main/java/org/opends/server/tools/LDAPAuthenticationHandler.java
index a9704c2..d00be4c 100644
--- a/opendj-server-legacy/src/main/java/org/opends/server/tools/LDAPAuthenticationHandler.java
+++ b/opendj-server-legacy/src/main/java/org/opends/server/tools/LDAPAuthenticationHandler.java
@@ -393,7 +393,7 @@
case SASL_MECHANISM_EXTERNAL:
return doSASLExternal(bindDN, saslProperties, requestControls, responseControls);
case SASL_MECHANISM_GSSAPI:
- return doSASLGSSAPI(bindDN, bindPassword, saslProperties, requestControls, responseControls);
+ return doSASLGSSAPI(bindDN, bindPassword, saslProperties);
case SASL_MECHANISM_PLAIN:
return doSASLPlain(bindDN, bindPassword, saslProperties, requestControls, responseControls);
default:
@@ -1747,10 +1747,6 @@
* to process the SASL bind. SASL EXTERNAL does not
* take any properties, so this should be empty or
* <CODE>null</CODE>.
- * @param requestControls The set of controls to include the request to the
- * server.
- * @param responseControls A list to hold the set of controls included in
- * the response from the server.
*
* @return A message providing additional information about the bind if
* appropriate, or <CODE>null</CODE> if there is no special
@@ -1764,9 +1760,7 @@
*/
private String doSASLGSSAPI(ByteSequence bindDN,
ByteSequence bindPassword,
- Map<String,List<String>> saslProperties,
- List<Control> requestControls,
- List<Control> responseControls)
+ Map<String,List<String>> saslProperties)
throws ClientException, LDAPException
{
String kdc = null;
--
Gitblit v1.10.0