From 5360b07bd36e6b3479c1bb3f911bb34f8d661b1f Mon Sep 17 00:00:00 2001
From: Nicolas Capponi <nicolas.capponi@forgerock.com>
Date: Wed, 21 Sep 2016 15:15:44 +0000
Subject: [PATCH] OPENDJ-2413 Apply PR comments: remove builders in parameters classes, simplify configuration retrieval Include also other minor changes and renaming
---
opendj-server-legacy/src/main/java/org/opends/server/util/embedded/RebuildIndexParameters.java | 53 ++++++++++++-----------------------------------------
1 files changed, 12 insertions(+), 41 deletions(-)
diff --git a/opendj-server-legacy/src/main/java/org/opends/server/util/embedded/RebuildIndexParameters.java b/opendj-server-legacy/src/main/java/org/opends/server/util/embedded/RebuildIndexParameters.java
index 8c8769c..eb80ea2 100644
--- a/opendj-server-legacy/src/main/java/org/opends/server/util/embedded/RebuildIndexParameters.java
+++ b/opendj-server-legacy/src/main/java/org/opends/server/util/embedded/RebuildIndexParameters.java
@@ -15,16 +15,14 @@
*/
package org.opends.server.util.embedded;
-/**
- * Parameters to rebuild the indexes of a directory server.
- */
+/** Parameters to rebuild the indexes of a directory server. */
public final class RebuildIndexParameters
{
private String baseDN;
private RebuildIndexParameters()
{
- // private constructor to force usage of the associated Builder
+ // prefer usage of static method for creation
}
/**
@@ -32,9 +30,9 @@
*
* @return a builder
*/
- public static Builder rebuildIndexParams()
+ public static RebuildIndexParameters rebuildIndexParams()
{
- return new Builder();
+ return new RebuildIndexParameters();
}
/**
@@ -53,42 +51,15 @@
}
/**
- * Builder for this class.
+ * Sets the base Dn for user information in the directory server.
+ *
+ * @param baseDN
+ * the baseDN
+ * @return this builder
*/
- public static final class Builder
+ public RebuildIndexParameters baseDN(String baseDN)
{
- private RebuildIndexParameters params;
-
- private Builder()
- {
- params = new RebuildIndexParameters();
- }
-
- /**
- * Generates the parameters from this builder.
- * <p>
- * After this call, the builder is reset and can be used to generate other parameters.
- *
- * @return the rebuild index parameters
- */
- public RebuildIndexParameters toParams()
- {
- RebuildIndexParameters p = params;
- this.params = new RebuildIndexParameters();
- return p;
- }
-
- /**
- * Sets the base Dn for user information in the directory server.
- *
- * @param baseDN
- * the baseDN
- * @return this builder
- */
- public Builder baseDN(String baseDN)
- {
- params.baseDN = baseDN;
- return this;
- }
+ this.baseDN = baseDN;
+ return this;
}
}
--
Gitblit v1.10.0