From 3872f27722f9bf2f6a601a86bdc769aa933801d0 Mon Sep 17 00:00:00 2001
From: Jean-Noel Rouvignac <jean-noel.rouvignac@forgerock.com>
Date: Tue, 21 Apr 2015 15:07:12 +0000
Subject: [PATCH] AutoRefactor'ed TestNG assertions Code cleanup: - factorized code by extracting methods
---
opendj-server-legacy/src/test/java/org/opends/server/backends/task/TaskBackendTestCase.java | 13 +++++++------
1 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/opendj-server-legacy/src/test/java/org/opends/server/backends/task/TaskBackendTestCase.java b/opendj-server-legacy/src/test/java/org/opends/server/backends/task/TaskBackendTestCase.java
index cfbdfc6..3a2e45d 100644
--- a/opendj-server-legacy/src/test/java/org/opends/server/backends/task/TaskBackendTestCase.java
+++ b/opendj-server-legacy/src/test/java/org/opends/server/backends/task/TaskBackendTestCase.java
@@ -43,6 +43,7 @@
import org.testng.annotations.DataProvider;
import org.testng.annotations.Test;
+import static org.opends.server.TestCaseUtils.*;
import static org.opends.server.util.ServerConstants.*;
import static org.testng.Assert.*;
@@ -173,7 +174,7 @@
int resultCode = TestCaseUtils.applyModifications(true,
"dn: " + taskDN,
"changetype: delete");
- assertFalse(resultCode == 0);
+ assertNotEquals(resultCode, 0);
assertTrue(DirectoryServer.entryExists(DN.valueOf(taskDN)));
}
@@ -322,7 +323,7 @@
"changetype: modify",
"replace: description",
"description: foo");
- assertFalse(resultCode == 0);
+ assertNotEquals(resultCode, 0);
// Perform a modification to cancel the task.
@@ -383,7 +384,7 @@
"changetype: modify",
"add: description",
"description: foo");
- assertFalse(resultCode == 0);
+ assertNotEquals(resultCode, 0);
// Perform a modification to delete that task.
@@ -500,7 +501,7 @@
// Make sure recurring task iteration got scheduled.
long tasksCountAfter = taskBackend.numSubordinates(DN.valueOf(
"cn=Scheduled Tasks,cn=tasks"), true);
- assertTrue(tasksCountAfter == (tasksCountBefore + 1));
+ assertEquals(tasksCountAfter, tasksCountBefore + 1);
// Perform a modification to update a non-state attribute.
int resultCode =
@@ -508,7 +509,7 @@
"changetype: modify",
"replace: ds-recurring-task-schedule",
"ds-recurring-task-schedule: * * * * *");
- assertFalse(resultCode == 0);
+ assertNotEquals(resultCode, 0);
// Delete recurring task.
resultCode =
@@ -520,7 +521,7 @@
// Make sure recurring task iteration got canceled and removed.
tasksCountAfter = taskBackend.numSubordinates(DN.valueOf(
"cn=Scheduled Tasks,cn=tasks"), true);
- assertTrue(tasksCountAfter == tasksCountBefore);
+ assertEquals(tasksCountAfter, tasksCountBefore);
}
--
Gitblit v1.10.0