From b8c6b80da1cb6118167a934daa480eb381c59e0e Mon Sep 17 00:00:00 2001
From: Jean-Noel Rouvignac <jean-noel.rouvignac@forgerock.com>
Date: Wed, 08 Jul 2015 08:06:00 +0000
Subject: [PATCH] opendj-server-legacy maven module: Enabled "NeedBraces" checkstyle rule. This brings opendj-server-legacy's checkstyle rules closer to ForgeRock's checkstyle rules.
---
opendj-server-legacy/src/test/java/org/opends/server/replication/plugin/TopologyViewTest.java | 10 ++++++++++
1 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/opendj-server-legacy/src/test/java/org/opends/server/replication/plugin/TopologyViewTest.java b/opendj-server-legacy/src/test/java/org/opends/server/replication/plugin/TopologyViewTest.java
index 646d2d9..b7d2941 100644
--- a/opendj-server-legacy/src/test/java/org/opends/server/replication/plugin/TopologyViewTest.java
+++ b/opendj-server-legacy/src/test/java/org/opends/server/replication/plugin/TopologyViewTest.java
@@ -273,7 +273,9 @@
String serverStr = rd.getReplicationServer();
rdPort = HostPort.valueOf(serverStr).getPort();
if (rdPort == rsPort)
+ {
rightPort = true;
+ }
}
if (connected && rightPort)
{
@@ -1050,7 +1052,9 @@
public boolean equals(Object obj)
{
if (obj == null || getClass() != obj.getClass())
+ {
return false;
+ }
TopoView other = (TopoView) obj;
return checkLists(dsList, other.dsList)
&& checkLists(rsList, other.rsList);
@@ -1059,18 +1063,24 @@
private boolean checkLists(List<?> list, List<?> otherList)
{
if (otherList.size() != list.size())
+ {
return false;
+ }
for (Object otherObj : otherList)
{
int found = 0;
for (Object thisObj : list)
{
if (thisObj.equals(otherObj))
+ {
found++;
+ }
}
// Not found
if (found == 0)
+ {
return false;
+ }
// Should never see twice as dsInfo structure in a dsList
assertFalse(found > 1);
// Ok, found exactly once in the list, examine next structure
--
Gitblit v1.10.0